a2dd8ecc33
Inspect style bits independently on style change.
2002-10-19 00:19:28 +00:00
b50692ee82
Rewrite StyleChanged procedure
...
o some bugs have been fixed
o cleaner, simpler code
Fix some corner case, icon size computation bugs.
Assorted docs updates.
2002-10-19 00:18:48 +00:00
323f9c23f0
Keep track of per-column information inside the listview.
...
Cache header rectangles.
Used the cached info instead of calling to the header each time.
Update the listview as we track column width changes.
Unify column handling between {Insert,Delete}Column, and width
changes.
Simplify RefreshReport, by using the new column info.
2002-10-19 00:18:11 +00:00
a72e9f617e
Do not query items that are just being inserted.
2002-10-19 00:17:24 +00:00
f8f559fa3c
Reorganize things a bit so that we no longer need the 'valid' flag on
...
each item.
Small comments update.
2002-10-19 00:16:37 +00:00
c18c7332b8
Instrument SetItemT to change only _one_ item at a time. That is, if
...
we have to change focus, we call it recursively to first remove the
focus from the item that has it. This allows simpler, and more correct
invalidation handling.
2002-10-17 21:55:41 +00:00
8f38417376
Unify set_{owner,main}_item functions.
...
Fix {old,new}state and lParam reporting in LVN_ITEMCHANG{ING,ED}.
Fix sanity check conditions for LVS_OWNERDATA.
2002-10-17 21:54:57 +00:00
96dca36cc8
More, better tracing to help nail down some crashes.
...
Fix typo in GetItemT (found, and fixed by Huw Davies).
Exit right away from GetItemT if nothing is asked (mask == 0).
Assorted code cleanups.
2002-10-17 21:53:56 +00:00
305fb4c3dd
Deal with sparsely populated listviews.
...
Crash on internal corruption.
2002-10-17 21:38:21 +00:00
ef4a6fc7e5
Add ability to create an iterator over a range list.
...
Fix memory leak when destroying ranges.
Add function that will to a 'deep' clone of a range list.
Add function that will subtract a range list from another.
Do not crash on NULL ranges (similar in spirit to HDPAs).
Fancy deselection routines uses the above infrastructure to deselect
the minimum possible.
Modify SetGroupSelection to take advantage of all this new
infrastructure, to avoid flicker on selection extension.
2002-10-17 21:37:24 +00:00
fa81ec674b
Change the definition of ranges to exclude the upper bound.
2002-10-17 21:36:29 +00:00
bac35001fe
Handle range tracing in a consistent fashion.
2002-10-17 21:35:47 +00:00
58b2ad925b
Remove dated comments.
2002-10-17 21:35:08 +00:00
66dd824dbc
Better encapsulation of the ranges concept.
2002-10-17 21:34:15 +00:00
be8189bd9c
Notification code cleanup, more traces, etc.
2002-10-17 01:20:18 +00:00
89eb8fdba3
We need to provide focus info always in ICON mode (spotted by Huw
...
Davies).
2002-10-16 19:57:31 +00:00
bcfffe7b08
Duplicate selected items list in LISTVIEW_RemoveAllSelections to
...
prevent infinite loops.
2002-10-16 19:56:06 +00:00
3dd4dabffb
Remember the global colors in custom draw mode.
2002-10-16 19:05:43 +00:00
ef9adbb6f5
Compute only the old state that we're gonna look at.
2002-10-16 19:05:02 +00:00
8d2f7224f1
Instrument SetItemT to avoid repainting if nothing changed.
...
Teach RemoveAllSelections to skip an item, so we can eliminate the
flicker when we click on a selected item.
2002-10-16 19:04:07 +00:00
3c9591b413
Fix bug in edit label when sending the text to the app.
...
Cleanup the handling of nEditLabelItem.
2002-10-16 19:03:25 +00:00
07a6a3975a
Edit label cleanup.
2002-10-16 19:02:32 +00:00
6b4a11af0a
Fix bug in ranges_shift which was corrupting selections.
...
Fix click notification (found and fixed by Alexandre Julliard).
Fix bug in setting item's state (some selection changes were lost).
Simplify selection code substantially.
Add a lot of debug tracing.
2002-10-16 19:01:38 +00:00
db14dbf12b
Fix iterator creation for LVS_LIST mode.
...
Do not update the infoPtr->nItemWidth in set_main_item.
Better handling of text bk colour in custom draw.
Rename GetItemListOrigin to GetItemOrigin.
A bunch of code cleanups, simplifications, etc.
2002-10-15 21:08:09 +00:00
17dce17a58
No longer compute the ill-defined bounds in GetItemMetrics.
...
Fix a bunch of bug in subitem metrics computation.
Properly implement GetSubItemRect in terms of GetItemMetrics.
Documentation updates, and code cleanups.
2002-10-15 21:07:01 +00:00
3a5105c957
Teach GetItemMetrics to deal with subitems in report mode as well.
...
Unify Draw{,Sub}Item, simplify RefreshReport.
2002-10-15 21:06:14 +00:00
f378bbd5a5
Fix iterator creation for LVS_LIST mode.
...
Use assert() instead of hand-made hack.
2002-10-15 21:05:29 +00:00
3baa344a43
Fix iterators to properly deal with LVS_{,SMALL}ICON modes.
...
Unify the Refresh{List,Icon} functions.
Simplify HitTest to make full use of the iterators.
Fix selection bounds in HitTest.
Avoid empty default to silence warning in gcc 3.2.
2002-10-15 21:03:10 +00:00
50b4688c7e
Iterator updates:
...
Add the notion of a special item which sits at the start of the
list.
Add the ability to iterate in both directions through the list.
Document the iterator interface.
Remove iterator_visibleitems.
Rename iterator_clippeditems to iterator_visibleitems for
consistency.
Use the new bidirectionality to paint the items in decreasing order.
2002-10-15 21:01:57 +00:00
00ea0868ba
Rename GetItemHeight to CalculateMaxHeight, for consistency
...
Fix usage of nItemWidth vs. iconSpacing.cx
Misc cleanups.
2002-10-11 23:34:32 +00:00
a1ca0122b9
Use the item box rather than the bounds when invalidating.
...
Implement 'bPartial' in EnsureVisible.
2002-10-11 23:33:25 +00:00
ed29ffdea4
Unify DrawLargeItem with DrawItem.
2002-10-11 18:47:03 +00:00
0b93d5c4c5
Use GetItemMetrics instead of GetItemMeasures.
...
Remove GetItemMeasures.
Add GetItemBox which only returns the boundary of the item.
2002-10-11 18:46:21 +00:00
ac756afcc2
Be real tough on internal programming errors.
2002-10-11 18:00:28 +00:00
dda1e31ce7
Remove support for owner drawn listviews in non-REPORT mode. We need
...
to do this since Windows supports owner draw *only* in report mode,
and hence apps are not prepared to handle drawing in other modes.
2002-10-11 17:59:39 +00:00
4150f31f58
Use GetItemMetrics instead of GetItemMeasures when drawing.
2002-10-11 17:58:56 +00:00
01b5226508
Make use of the new GetItemMetrics in HitTest, to avoid code
...
duplication.
2002-10-11 17:58:11 +00:00
f1f447931e
Separate item metrics computation from positioning
...
Add support for computing state icon metrics.
2002-10-11 17:57:27 +00:00
5feaff534b
LVS_OWNERDRAWFIXED should only take effect in REPORT mode.
2002-10-11 04:19:20 +00:00
1c6c29e313
Fix drawing bug introduced with the custom notification
...
reorganization.
2002-10-10 22:57:45 +00:00
01dbe3999e
Simplify the report mode, and item drawing considerably.
...
Fix full row select in report mode.
2002-10-10 22:55:21 +00:00
ffd4bd37d0
Handle custom draw notifications properly.
...
Various cleanups, and simplifications.
2002-10-10 22:54:06 +00:00
d2d4baf96b
Remove superfluous abstractions which make the code harder to
...
understand.
2002-10-10 22:52:56 +00:00
6d6be0e1d4
Move the custom draw notifications into the Draw.*Item functions.
2002-10-10 22:52:12 +00:00
a994fb8135
Move the custom draw item notifications down into DrawLargeItem.
2002-10-10 22:51:27 +00:00
7ac890984d
Fix silly redraw bug introduced in previous patch.
...
Tidy up, and simplify large item drawing.
2002-10-10 22:50:49 +00:00
50ed9b9962
Implement WM_SETREDRAW properly.
2002-10-10 22:50:09 +00:00
12dca97b9d
Rework the mouse click notifications
...
Assorted cleanups, and simplifications.
2002-10-10 22:49:29 +00:00
1094c63c0e
Use (semi)standard HitTest, rather then our own little invention.
...
Get rid of GetItemAtPt.
Fix HitTest but in REPORT mode.
2002-10-10 22:48:36 +00:00
bc54d78532
- change the internal functions in windows/cursoricon.c to use 32bit
...
handles
- move the implementation of ExtractAssociatedIcon16 to
ExtractAssociatedIconA
- convert HICON to a void*
- fixed some handle conversions that happened to be in the way while
doing the above
2002-10-10 21:22:09 +00:00
8b3da5e3ba
Scroll the listview when doing multiple selections.
2002-10-10 18:56:50 +00:00
05b4a09357
Narrow down the items we iterate over in LIST, and REPORT mode.
...
Fix a Client --> List coordinate transformations in FindItem.
Fix bug in HitItem (in LIST and REPORT mode).
Avoid the last bit of drawing in REPORT mode.
2002-10-10 03:13:14 +00:00
9d678ff740
Draw _only_ the items that are invalidated.
...
Fix serious bug when deleting from a range.
Pass in a range to the ranges_{add,del} functions.
Tidy up the RefreshIcon function.
Assorted cleanups.
2002-10-10 03:12:05 +00:00
0295e4fceb
Reimplement FindItem (cleaner, faster, more compliant with MSDN).
2002-10-10 03:10:20 +00:00
1313431b1b
Rewrite HitTest to make it pretty, and very fast.
2002-10-10 03:08:45 +00:00
a80ced02e9
Introduce the notion of item iterators, and use them to clean up code.
2002-10-10 03:07:04 +00:00
00e3435f54
Separate range manipulation functions from selection ranges.
2002-10-10 03:05:28 +00:00
764607d931
Fix large item label calculation when not focused.
...
Fancy focus rectangle handling.
2002-10-10 03:04:34 +00:00
b2056c22b5
Fix focus handling when deleting items, or changing modes.
...
Better label rect calculation in ICON mode.
2002-10-10 03:03:39 +00:00
c95b2a0202
Fix large item handling focus in ICON mode.
2002-10-10 03:02:30 +00:00
bbf878ded6
No need to go through the heavy duty rect computation when in OWNERDRAW.
2002-10-10 03:01:10 +00:00
a625dd394d
Factor out owner draw code, so that it works for all modes.
...
Documentation updates.
2002-10-10 02:59:34 +00:00
b8d5715bc1
Factor out the computation of item position, so it can be used
...
independently of the rectangles.
2002-10-10 02:58:47 +00:00
f29d0ce05b
Unify LISTVIEW_UpdateLargeItemLabelRect, and GetItemMeasures.
...
Optimize GetItemMeasures to the max.
Centralize the DrawText's DT_* flags.
2002-10-10 02:57:50 +00:00
1fc91d2d65
Get rid of 'goto's in GetItemMeasures.
...
Move LISTVIEW_UpdateLargeItemLabelRect close to where it's used.
2002-10-10 02:56:57 +00:00
cf4670cba2
Fix braino in calculation of LVS_LIST origin.
...
Invalidate the entire window when we are invalidating the list.
2002-10-10 02:56:13 +00:00
74e43dd023
Fixed bug that caused item texts to be empty.
2002-10-08 01:55:32 +00:00
783bab61de
Fix nasty bug generated by UINT vs. INT (resulted in bogus
...
comparisons).
Fix LVIR_SELECTBOUNDS computation, for REPORT mode.
Fix dependency generation in GetItemMeasures.
Fix rectangle computation for REPORT mode (corner case problems).
Better debug messages.
Assorted cleanups.
2002-10-07 22:43:42 +00:00
97ffbfad72
Cleaned up the rectangle handling, and fixed numerous bugs in
...
rectangle calculations.
2002-10-07 22:42:44 +00:00
1446a06ce9
Fix inaccurate listview scrolling with PgUp/Down and Home/End keys.
2002-10-07 21:44:01 +00:00
3ac601d52b
Fix silly bug in SetItemPosition (we should set it, not create a new
...
one).
2002-10-07 18:51:52 +00:00
b9cacc438a
Maintain the item position in {,SMALL}ICON mode separataly from the
...
item, so that we have it even in LVS_OWNERDATA.
2002-10-07 18:50:21 +00:00
6cfd83b985
Cleanup the SetItemPosition interface.
2002-10-07 18:48:47 +00:00
7f77992091
Remove the COUNT_OF macro.
...
Indentation fixes, and minor cleanups to notify_dispinfoT.
2002-10-07 18:44:55 +00:00
6a6310d099
Fixes bug which rendered virtual listboxes always empty.
...
Smarter focus rectangle drawing.
Fix focus handling when we add/delete a column.
Fix silly bug in GetSubItemRect.
Elimiante flicker in Report mode.
2002-10-07 18:43:49 +00:00
95f2799537
Cleanup, and clarify the handling of the various rectangles.
...
Fix handling of large items in ICON mode.
Fix calculation of LVIR_SELECTBOUNDS.
Various cleanups, and simplifications.
2002-10-07 18:42:52 +00:00
914aac36b5
Cleanup of the way we maintain/lookup the item count.
...
Rename GetItemWidth to CalculateMaxWidth.
Misc trivial changes.
2002-10-07 18:41:00 +00:00
1c7bf6229f
Fix focus handling for owner draw listviews.
2002-10-07 18:38:17 +00:00
d308a8d4fe
Fix potential bug in RemoveAllItems.
...
Fix report-mode ONWERDRAW bug (with help from Alexandre Julliard).
Fix multiple selection bug (in report and list mode).
Remove code duplication for removing selections.
2002-10-07 18:36:34 +00:00
769f6a8c0f
Reimplement GetSubItemRect, subitem setting optimizations.
2002-10-05 18:05:27 +00:00
76f397e3a1
Fix bug in OWNERDATA selection handling.
...
Fix critical performance bug in GetSelectedCount.
Fix critical performance bug in SetGroupSelection.
Fix problems for OWNERDRAW report.
Fix hidden/latent bugs in state handling.
Better debug messages.
2002-10-05 18:04:30 +00:00
f645727afe
Fix onwer-draw REPORT for broken apps.
2002-10-05 18:02:54 +00:00
d2b526ed33
Streamline the GetItem usage.
...
Fix fatal bug for ICON mode in LVS_ONWERDATA.
Documentation updates, marking places which need work.
2002-10-05 17:46:30 +00:00
86e92428fb
Fix condition so we actually store the state in virtual listviews.
...
Assorted code cleanups.
2002-10-05 17:44:51 +00:00
3547087c70
- Effective optimization in GetNextItem (speeds up Xnews).
...
- Misc cleanups.
2002-10-05 17:43:26 +00:00
a656944875
Rewrite the begin/end label edit procedures.
...
Better support of OWNERDRAW.
Cleaner, simpler code.
2002-10-05 17:42:14 +00:00
530793ff4d
Fixed large item focus handling for virtual listviews. Since at most
...
_one_ item can have the focus at any time, we can maintain one such
rectangle per list, rather than per item. This is both more efficient,
and works for LVS_OWNERDATA listviews as well.
2002-10-04 17:54:22 +00:00
c1b1a296ff
Do not blindly trust GetItem to succeed -- check the return value, and
...
fail gracefully.
2002-10-04 17:51:42 +00:00
45387e3a6c
Do not send uninitialized data in notification to application.
2002-10-04 17:49:29 +00:00
dd0c4c16ae
- Fix nasty bug in REPORT mode, when calculating the label rect.
...
- Lots of cleanups, and simplifications.
2002-10-04 00:25:55 +00:00
df6bcfbe57
- Reorganize DrawItem.
...
- Unify text attribute selection between Draw{Sub,}Item.
- Usual cleanups, and simplifications.
2002-10-02 23:53:04 +00:00
91d41c7fe3
Fancy/optimized EnsureVisible method that eliminates flicker.
...
Minor cleanups.
2002-10-02 23:45:50 +00:00
fc01fcd25a
- Fix the subitem drawing code.
...
- A lot faster drawing in report mode.
- A great deal of cleanup, and simplifications.
2002-10-02 19:59:55 +00:00
feae6c3ea4
- Fix the state icon handling.
...
- Fix handling of new image lists.
- Small cleanups.
2002-10-02 18:38:11 +00:00
25bf08267a
- Rework the {Insert,Delete}Column functions.
...
- Drawing optimizations when adding/removing columns.
- More cleanups, and simplifications.
2002-10-02 18:32:08 +00:00
e7c82c2711
- Fix LIST mode, broken by previous changes.
...
- Implement GetItemRect in terms of GetItemMeasurements.
- Improvements in debug traces.
- Many bug fixes, compelete implementation for GetItemMeasurements.
- Lots of code cleanups, simplifications.
- Documentation updates.
2002-10-01 18:06:15 +00:00
4ee2e9e989
Prevent crash when listview trace logging is on.
2002-09-30 18:52:33 +00:00
7e1e62de1c
- Eliminate extra background fills.
...
- Eliminate bogus error messages.
2002-09-29 18:34:51 +00:00
a4f580b74b
- Cache GWL_STYLE, to avoid fetching in virtually every function.
...
- Separate GetOrigin from GetAllMeasures as it is item independent,
and rename function to reflect the change.
- Small cleanups.
2002-09-29 18:02:21 +00:00
81beb955c8
Remove item from the list, if we fail to initialize it at insert
...
time.
2002-09-27 22:47:00 +00:00
e65eb61419
- Fix crashes in debug mode.
...
- Fix some focus rectangle problems.
- Better debugging output.
- More cleanups.
2002-09-27 22:02:16 +00:00
7f32a8d176
- Initialize memory to prevent crashes when -debugmsg +listview is on.
...
- Fix various array bounds related errors.
2002-09-25 03:20:01 +00:00
e2e5097648
- Localize origin, location, and rectangle computation.
...
- Support state icons in LVS_ICON style.
- Draw only items that are in the clip box.
- Draw non-selected items first then the selected ones because large
icons may overlap each other.
- Correct invalidation rectangles for items.
- Correct drawing of large icons.
- Eliminate divide by zero cases in scrolling.
- Invalidate selected items prior to setting window losing focus.
2002-09-24 18:27:21 +00:00
70c6cecef9
Remove some more superfluous ZeroMemory calls, small cleanups.
2002-09-23 20:59:42 +00:00
e3e404296e
- Fix outputting of a text pointer in debug mode (by Rein Klazes).
...
- Remove a large bunch of superfluous ZeroMemory calls.
- Fix a couple of bugs.
2002-09-23 20:55:22 +00:00
df28ddf309
- Better implementation for GetTopindex/GetOrigin/SetIconSpacing.
...
- Drawing optimizations, better scrolling.
- A few more bugs squashed without mercy.
- Many cleanups, simplifications, doc updates.
2002-09-18 18:29:28 +00:00
1edcfe1fa9
- Optimize the heck out of Report drawing.
...
- A bit of organization, for sanity's sake.
- Many simplifications, cleanups, etc.
2002-09-17 18:29:17 +00:00
6b25723cf7
Listview_ProcessLetterKeys: fixed never ending loop when end index is
...
zero.
2002-09-17 01:30:13 +00:00
31aefe4036
- Reorganization and cleanup of selection code.
...
- Complete rewrite of focus handling and drawing code.
- Many bugs fixed (including a serious memory corruption).
- Many performance fixes.
- Lots of cleanups, simplifications, etc.
- Documentation updates.
2002-09-16 22:37:40 +00:00
43baa0acd8
- Grand rewrite for {Get,Set,Insert}Item & Co.
...
- Many bugs fixed.
- Callback items are better supported.
- Improvements in rendering speed.
- Change VOID to void.
- Many code cleanups, and simplifications.
- Documentation updates.
2002-09-16 19:25:41 +00:00
b9df08216a
- Improve LVM_GETITEMRECT values for LVS_ICON style. Now mostly
...
correct (or at least matches native).
- Handle focused and selected large icon text better.
- Handle internal erase.
- Additional debugging code.
2002-09-13 17:41:32 +00:00
1da4ea287d
Fix a bunch of bugs related to scrolling.
2002-09-12 22:26:08 +00:00
ee3fdd8038
- Complete rewrite of scrolling code: smaller, faster, cleaner.
...
We now properly scroll the window, rather than invalidating it on
every scroll action.
- A bug or two got squashed.
- Many code cleanups, simplifications, etc.
- Some documentation updates.
2002-09-12 18:10:41 +00:00
70b2f44a47
Code cleanups and simplifications, documentation updates.
2002-09-11 00:47:09 +00:00
db6c9b0d8e
- Pass infoPtr around, instead of hwnd.
...
- Implement hot cursor.
- Update list of unimplemented messages.
- Simplify the code for editing labels.
- Start working towards more type-safe functions.
- Small code cleanups.
- Some docu updates.
2002-09-09 19:22:19 +00:00
025c0b716b
Prepare dlls/{comctl32,gdi,msvideo,setupapi,shell32,twain,winmm} for
...
the conversion of HWND to a void*.
2002-09-06 19:41:17 +00:00
027034e221
- Reduce the number of messages being passed to itself by using the
...
internal routines.
- Fix problem in _SetIconSpacing found by recent change.
- Add initial support for correct icon sizing.
- A few extra traces.
2002-08-29 23:58:42 +00:00
d1b24defdc
Change the icon spacing when setting the image list.
2002-08-27 19:41:56 +00:00
86198965ad
Windows expects the edit window to hang around and be valid.
2002-08-27 19:36:33 +00:00
6737a5926a
- Implement LVM_SCROLL and adjust scrolling for all formats.
...
- Implement standard Comctl32 color handling.
- Eliminate bogus ERR messages for application messages.
2002-07-23 20:54:52 +00:00
b99101230f
DeleteColumn should return success even for uOwnerData.
2002-07-16 01:10:26 +00:00
073d09a17f
- Improve traces.
...
- Changed default column width to 128 to match native and make that
the mimimum for LVS_SMALLICON and LVS_LIST styles.
- Corrected max value for LVS_LIST style scroll info.
- Issue our own ShowScrollBar like the native with proper test.
- Correct alignment when using LVS_ICON style.
- Correct FIXMEs for unimplemented styles.
- Correct rect size computation for LVS_LIST.
- Reset scroll bars when changing styles.
- Implement WM_WINDOWPOSCHANGED.
2002-07-10 03:00:22 +00:00
e35580f4c9
Fixed some various comparisons wrt signedness.
2002-06-21 22:25:17 +00:00
21fbb40cb7
Support for LVM_SUBITEMHITTEST; check for out-of-bounds subitem index
...
in LISTVIEW_GetSubItemRect.
2002-06-10 22:47:41 +00:00
9a62491660
Removed trailing whitespace.
2002-05-31 23:06:46 +00:00
fb2a70463e
Fixed snprintf warnings.
2002-05-16 18:31:27 +00:00
5679be34d9
Do not invalidate the rect while drawing.
...
Implemented GetSubItemRect and a quick change to notifications sent
for OwnerData items.
2002-05-14 03:58:46 +00:00
07a308d606
LISTVIEW_GetColumnT: care for the format of the string.
...
LISTVIEW_Create: send HDM_SETUNICODEFORMAT message.
2002-04-11 17:31:45 +00:00
b7d819953e
Add LVS_NOSORTHEADER support.
...
Sort column on HDN_ITEMCLICKA too.
Do not edit labels if icon was clicked.
Fix the incorrect icon width in my earlier patch.
2002-03-20 00:53:42 +00:00
b6c28ff62f
Add support for report mode text justification.
2002-03-11 05:02:11 +00:00
0799c1a780
Added LGPL standard comment, and copyright notices where necessary.
...
Global replacement of debugtools.h by wine/debug.h.
2002-03-09 23:29:33 +00:00
ad079d6cbb
Ask for correct number of chars in EditLblWndProcT.
2002-02-28 21:42:25 +00:00
bdd77388b9
LISTVIEW_InsertColumnT can be called with a width of
...
LVSCW_AUTOSIZE_USEHEADER.
Use the correct strings when column autosizing on columns other than
column 0.
LVSCW_AUTOSIZE_USEHEADER uses both item and header strings.
2002-02-28 20:41:39 +00:00
df0f236038
Centre text correctly for the selected item.
...
Draw complete background for the selected item.
Calculate the size of a large icon more correctly (including multiline
labels).
2002-02-27 01:24:39 +00:00
019ae8a22f
LVM_GetItemRect should not take text size in account for LVIR_LABEL in
...
report mode.
2002-02-25 19:00:03 +00:00
d10c9a47b8
Implement multiline labels in the Large Item view by using DrawText
...
Note that this now highlights weaknesses in the label measuring code
etc. which cannot correctly handle multiline labels.
2002-02-22 21:23:02 +00:00
13f1fb23fe
Fix of ListView invalidation in LISTVIEW_SetBkColor.
2002-02-19 18:32:12 +00:00
8961f1624e
Correct tests involved with processing the LVIF_DI_SETITEM flag.
2002-02-12 18:42:25 +00:00
7904acf1bd
Authors: Guy L. Albertelli <galberte@neo.lrun.com>, Aric Stewart <aric@codeweavers.com>, Dmitry Timoshkov <dmitry@codeweavers.com>
...
Misc fixes:
- cache text metrics for the font we're using
- improved item hit detection
- more debugging output
- implement LVM_SETICONSPACING
- lots of bugs squashed
2002-02-05 18:13:57 +00:00
d15ed230a8
Complete Listview Unicodification.
...
Simplify the setting of (sub)item text by using common code.
2002-02-04 18:44:16 +00:00
83ff80b295
Flip A<->W conversion in dispinfo_notifyT.
2002-02-02 17:57:00 +00:00
776cb279f2
Don't repaint header when scrolling a listview vertically.
2002-01-31 20:38:25 +00:00
815997ffe0
Fix problems with listview notification.
2002-01-29 17:51:00 +00:00
6d694d8ed6
Simplify and fix listview ellipsification of large text labels.
2002-01-29 16:50:40 +00:00
3dbbb0b297
Avoid converting nonexistent text from A->W.
2002-01-29 03:08:24 +00:00
9e99d2b763
- Make the ListView control Unicode ready.
...
- Support both ANSI & Unicode ListView notifications.
- Fixed a few bugs.
2002-01-18 19:05:35 +00:00
a02f3de89e
Rect returned by LISTVIEW_GetItemRect should be total size in report
...
mode.
2001-08-21 17:04:02 +00:00
b0327f2b40
Remember response from LVN_GETDISPINFO if user sets LVIF_DI_SETITEM.
2001-07-02 01:20:28 +00:00
e76218dd61
Add '\n' at the end of traces.
2001-05-09 17:31:31 +00:00
f3c93b805b
Eliminate unitialized garbage being returned from LISTVIEW_GetItemA.
2001-04-18 17:40:04 +00:00
dd30c5c282
GetItemSpacing(true): Return the default item spacing if the view is
...
LVS_ICON, and the current 'item size' otherwise.
2001-04-16 19:04:12 +00:00
4d7e26f9a2
Fixed scrolling of listview with a mouse wheel.
2001-04-04 18:25:46 +00:00
d6f5ed273d
Update nSelectionMark and nFocusedItem when inserting/deleting/sorting
...
items.
SortItems: If sorting less than 2 items, do nothing.
2001-03-05 22:11:17 +00:00
f45d56912a
In LISTVIEW_AddGroupSelection and LISTVIEW_SetGroupSelection, if no
...
selection mark has been set, just select the current item.
In LISTVIEW_SetGroupSelection we must also set the selection mark in
that case (and only in that case).
Removed a naughty ';' (spotted by Eric Pouech).
2001-03-04 01:04:35 +00:00
282f7270c1
Small 'typos in comments' fixes.
2001-02-28 05:31:02 +00:00
7fdceb2217
Update selection after sorting (in LISTVIEW_SortItems) by making sure
...
selection list matches states of individual items.
2001-02-16 19:39:14 +00:00
a2c2a83f8e
Send LVN_DELETEITEM notification first, to avoid crashes if the app
...
requests LVIF_PARAM with LISTVIEW_GetItem() during its LVN_DELETEITEM
message handler.
2001-02-15 21:24:43 +00:00
4684ab1c12
ListView_GetItemRect already sets rc.left.
2001-02-14 21:42:24 +00:00
1afa24aeac
Fix (rewrite), and add documentation to LISTVIEW_ProcessLetterKeys.
...
Lowered the key repetition delay (Aric).
2001-02-12 18:07:43 +00:00
d62dd82efb
Fix ListView_GetItemRect() macro.
...
Fix use of ListView_GetItemRect() macro in listview control.
Add some documentation to LISTVIEW_GetItemRect().
2001-02-12 03:46:00 +00:00
c0ca077f0b
Misc fixes in LISTVIEW_SetImageList, LISTVIEW_SetItemCount,
...
LISTVIEW_UpdateSize.
2001-01-22 19:27:43 +00:00
0255c8f0df
Only adjust item rect by horizontal scrollbar offset in report view.
2001-01-17 01:48:14 +00:00
bde6ae0c19
Test for NULL and LPSTR_TEXTCALLBACK before using lpColumn->pszText.
2001-01-09 21:50:27 +00:00
e5786e3be6
Adjust item rects by horizontal scrollbar offset.
2001-01-09 20:49:38 +00:00
147bc6d21b
Ownerdata listviews were not clearing previously selected items when a
...
new item is set as selected using SetItem and the listview has
LVIS_SINGLESEL.
2000-11-29 00:00:11 +00:00
b1eb301477
Implemented VK_PRIOR and VK_NEXT processing (merged from Corel tree).
2000-11-08 04:30:16 +00:00
d41c9a3da4
Implemented the RedrawItems message for a listview.
2000-11-07 20:28:11 +00:00
908464d448
Authors: Andreas Mohr <amohr@codeweavers.com>, Dimitrie O. Paun <dimi@cs.toronto.edu>, Patrik Stridvall <ps@leissner.se>
...
Various warning fixes.
2000-11-01 03:11:12 +00:00
7203ee6623
Use PS_ALTERNATE rather than PS_DOT.
...
Use Rectangle to draw focus rectangles.
2000-10-31 02:05:11 +00:00
4de47040fd
Fixed cancels editing of a listview label if the listview is
...
scrolled.
2000-10-31 01:35:50 +00:00
61ef06042e
Do not set the iSubItem part of the struct for LVM_HITTEST,
...
applications only need to pass memory space up to iItem.
2000-10-22 23:47:49 +00:00
af7f901c9c
Fix messages sent when right-clicking in a blank (non-item) area of a
...
listview.
2000-10-19 22:28:06 +00:00
89d4472d46
Recalculate nItemHeight when LVS_SETIMAGELIST is called. Fixes icons
...
being chopped off in the file dialog window. Align items to top and
refresh after sorting, as windows does.
2000-10-19 20:22:09 +00:00
da610897e4
Implement LVM_SETITEMPOSITION32.
2000-10-17 00:30:39 +00:00
1563abe8ec
- stupid spelling fixes
...
- some more loadorder array work
2000-10-13 20:26:52 +00:00
907a1e615b
Subitems of listviews were not painted with the right background when:
...
-LVS_EX_FULLROWSELECT style is defined
-item is selected
-Listview doesn't have the focus.
2000-10-13 17:05:17 +00:00
163830c569
- Background should not be drawn if the background color is CLR_NONE.
...
- Don't change the size to 0 for the header control of listview with
LVS_NOCOLUMNHEADER style. In fact just setting HDS_HIDDEN to the
header control is enough.
2000-10-12 23:07:41 +00:00
e127a28166
Corrected some segvs that occur with ownerdata listviews.
2000-10-12 20:39:59 +00:00
fca20f6553
Paint background before drawing item and subitems. Paint any area of
...
the control not occupied by items. Early out of LISTVIEW_RefreshXXX
if no items exist. InvalidateRect() on LBUTTONDOWN only if the control
has items to draw.
2000-09-22 22:45:30 +00:00
dc2ffbe0cd
Correct some situations with listview selections. Specifically fixed
...
situations where in an OWNERDATA listview the selection ranges become
invalid if the number of items is changed. Additional fixes a few
problems resulting in loops in RemoveAllSelections.
2000-09-22 22:00:01 +00:00
c5e86a2c19
Notification NM_CLICK, NM_RCLICK and NM_DBLCLK sent by the listview
...
should set lParam to a NMLISTVIEW instead of a NMHDR. According to
MSDN doc, it is like that since version 4.71, Wine is returning 5.0 as
the DLL version.
2000-09-19 02:38:45 +00:00
3872d0a218
Sorting items in a listview using LVW_SORTITEMS is only sorting the items
...
and not the subitems. This patch fix this issue. I've remove the temporary
Sortlist, it was not necessary to create another list, and it was buggy.
2000-09-18 01:39:27 +00:00
88968b89cb
Allow having a transparent background text color for the listview.
2000-09-16 20:45:09 +00:00
2a6c1e498c
Hide the vertical scrollbar when listview style is LVS_LIST.
2000-09-12 23:37:19 +00:00
eef99e0c93
Implemented both customdraw message sending and handling (based off
...
the treeview method) as well as LVS_OWNERDRAWFIXED.
2000-09-06 19:44:49 +00:00
2b5d9c6e50
Always call LISTVIEW_SetSelection() for an item, even if that item
...
has been selected before, in order to let other items get erased.
2000-08-29 03:52:16 +00:00
53d40899b1
Large caption icons should end in '...' when they are abbreviated.
2000-08-23 19:12:36 +00:00
59dae22a43
Beginning of some simple optimization of the listview
...
drawing. Specifically it reduces flicker when selection changes.
2000-08-21 20:16:53 +00:00
0f9d56fde8
LPSTR_TEXTCALLBACK wouldn't work if the application supplied the item
...
text in its own buffer.
2000-08-14 17:17:57 +00:00
7db0384706
Fixed sending of LVN_ITEMCHANGING and LVN_ITEMCHANGED messages,
...
cleaned up some of the drawing, implemented the iIndent for LVS_REPORT
and fixed a problem where sub items where not being properly
associated with their item for virtual list views.
2000-08-11 21:14:23 +00:00
70c9e095ef
Removed all non-standard common control headers from the include
...
directory.
2000-08-09 00:41:17 +00:00
773efce76b
Reworked how selections are kept track of in the list view. Selections
...
are now listed as a sorted range of paired integers.
2000-08-08 20:46:07 +00:00
b4c7499883
Fixed some warnings.
2000-08-04 21:08:01 +00:00
559692a5e5
- Fixed bug where InitSubItem was doing a ZeroMemory on the item.
...
- Cleaned up a sit of extra blue at the end of a FULLROWSELECT list view
if there is only one column.
- Corrected a bug I introduced with an earlier patch which caused
problems with multiple selections.
2000-08-03 00:24:09 +00:00
efd796743d
Fixed a segfault problem using the standard file open dialog box.
2000-08-01 23:30:25 +00:00
176cee7e1d
Fixed a few bugs including one with setting extended styles and
...
editing labels.
Implemented the LVS_EX_FULLROWSELECT extended style.
Begin an implementation of virtual list views (LVS_OWNERDATA style
set).
2000-08-01 20:58:33 +00:00
d778da2fbe
Prevent the attempt to draw invalid image indexes.
...
Provide the two pixel buffer between the image and the label.
2000-07-25 12:26:59 +00:00
9024c107bf
Handle the case where the function SetItem is called to select an item
...
or set its focus.
2000-07-23 14:19:42 +00:00
1fb3298e7b
Only use the column headers to calculate the width of a
...
LDS_REPORT-type listbox if it actually has column headers.
(ie. LVS_NOCOLUMNHEADER bit is not set.)
2000-07-08 12:45:21 +00:00
66331a73c0
Finished the implementation of LISTVIEW_SetColumnWidth. Tested
...
against windows thoroughly. Fixed bug resulting in unsigned values
being passed into LISTVIEW_SetColumnWidth from the listview window
procedure. Fixed LISTVIEW_GetItemHeight to disregard the height of
icons if no icons exist.
2000-06-04 01:35:16 +00:00
Dimitrie O. Paun