Commit Graph

55 Commits

Author SHA1 Message Date
Michael Stefaniuc 25c41c4eea dmusic: Use dump_DMUS_OBJECTDESC() instead of open coding it.
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-03-25 10:12:22 +01:00
Michael Stefaniuc 8e0f94986e dmusic: Reimplement ParseDescriptor() for DirectMusicCollection.
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-16 09:16:21 +02:00
Frédéric Delanoy 2ab8729020 Assorted spelling/grammar fixes. 2014-06-20 12:19:31 +02:00
Michael Stefaniuc d33989f675 dmusic: Remove the redundant "IDirectMusicCollection" from method names. 2014-06-13 15:59:48 +02:00
Michael Stefaniuc 147f100f3e dmusic: Get rid of the extra pointer to a DMUS_OBJECTDESC. 2014-06-13 15:59:42 +02:00
Michael Stefaniuc 4e81a977c7 dmusic: Use generic "unimplemented" methods for IPersistStream. 2014-06-13 15:59:39 +02:00
Michael Stefaniuc 02ed47fa3c dmusic: Move the common parts of DMObject to a generic implementation. 2014-06-13 15:59:36 +02:00
Michael Stefaniuc 1a7c0a6a70 dmusic: Lock/unlock the module only on creation/destruction of the object. 2014-06-11 16:13:02 +02:00
Michael Stefaniuc 5d7e93dc54 dmusic: Return S_FALSE for the unimplemented IPersistStream_IsDirty(). 2014-06-11 12:59:05 +02:00
Michael Stefaniuc 176b7aa842 dmusic: Move a struct to the .c file it is used. 2014-05-16 10:52:27 +02:00
Michael Stefaniuc 2973dbb856 dmusic: Use the defines for the FOURCC codes. 2014-01-27 17:39:47 +01:00
Michael Stefaniuc 84df351b1e dmusic: Don't hardcode the guidClass in IDirectMusicObject::ParseDescriptor. 2014-01-06 17:10:04 +01:00
Michael Stefaniuc fe0d2a2ba7 dmusic: Don't crash on NULL in IDirectMusicObject::GetDescriptor. 2014-01-06 17:10:02 +01:00
Michael Stefaniuc fda99c0fcc dmusic: The object class is immutable in a DirectMusicObject. 2014-01-06 17:10:01 +01:00
Michael Stefaniuc 5771ff8912 dmusic: Don't leak mem if DirectMusicCollection creation fails. 2014-01-06 17:08:52 +01:00
Michael Stefaniuc d3c550d0ba dmusic: Always AddRef the returned iface in QueryInterface. 2014-01-06 17:06:52 +01:00
Michael Stefaniuc 5f5c21e55d dmusic: These COM classes don't support COM aggregation. 2013-12-30 19:01:42 +01:00
Christian Costa 898c2954e0 dmusic: Use static variables for instrument header and id instead of using pointer. 2012-12-21 13:54:29 +01:00
Christian Costa f30c18f3d2 dmusic: Set instrument stream position where the instrument begins, not at the beginning of the instruments list. Simplify CustomLoad accordingly. 2012-12-20 18:30:16 +01:00
Christian Costa f7a9df5ecb dmusic: Remove unused variables. 2012-11-05 11:30:34 +01:00
Christian Costa 31a582989f dmusic: Display new ref in AddRef and Release. 2012-11-02 19:48:21 +01:00
Christian Costa 4c7fb67fc1 dmusic: Simplify IPersistStream_Load by checking DLS header first and exit if it is wrong. 2012-05-21 20:21:19 +02:00
Christian Costa c0dff8ac44 dmusic: Cleanup IDirectMusicCollection_EnumInstrument. 2012-05-18 18:12:31 +02:00
Christian Costa 495e3288db dmusic: Cleanup IDirectMusicCollection_GetInstrument. 2012-05-18 18:12:18 +02:00
Christian Costa 82f3b86c5c dmusic: Display new ref in trace for AddRef and Release for collection object. 2012-05-18 18:12:06 +02:00
Christian Costa f0324c9665 dmusic: COM cleanup of DirectMusicCollection and get rid of separated IUnknown interface. 2012-05-14 12:19:45 +02:00
Christian Costa 447c97cfbd dmusic: Simplify ParseDescriptor by checking DLS header first and exit if it is wrong. 2012-05-09 11:51:47 +02:00
Christian Costa 03c75b9cf6 dmusic: COM cleanup of IDirectMusicInstrument and get rid of separated IUnknown interface. 2012-05-08 09:45:43 +02:00
Christian Costa 7a772ed83a dmusic: Replace debugstr_DMUS_OBJECTDESC by a specific dump function to avoid debug buffer overflow. 2012-04-11 19:09:29 +02:00
Marcus Meissner 2a55b09bed directshow: Removed bad sizeof in copy/pasted code (Coverity). 2011-10-18 15:17:42 +02:00
Frédéric Delanoy b5a33dab88 dlls: Assorted spelling fixes. 2011-08-02 20:47:51 +02:00
Michael Stefaniuc 68eb63a4fa dmusic: Remove superfluous pointer casts. 2009-01-13 15:26:19 +01:00
Austin English b4f52938e4 Spelling fixes. 2008-04-02 23:18:21 +02:00
Andrew Talbot 6b39f35cf5 dmusic: Assign to structs instead of using memcpy. 2008-02-26 11:18:20 +01:00
Andrew Talbot 8a4db52f2a dmusic: Remove unneeded casts. 2007-12-08 19:54:05 +01:00
Alexandre Julliard 7718d2bd7c dmusic: Fix license headers that mistakenly use GPL instead of LGPL.
Confirmed by the original author and the major contributors.
2007-05-30 12:54:07 +02:00
Michael Stefaniuc 22684cc767 janitorial: Remove stray '\' at end of lines. 2007-01-09 12:04:26 +01:00
Marcus Meissner af30447348 dmusic: Replaced && 0xfff... by & 0xff. 2006-11-09 17:53:36 +01:00
Michael Stefaniuc a4253ba08b dmusic: Win64 printf format warning fixes. 2006-10-12 21:43:15 +02:00
Alexandre Julliard d37c555a48 dmusic: Make the virtual table functions static where possible. 2006-06-10 11:57:22 +02:00
Jonathan Ernst 360a3f9142 Update the address of the Free Software Foundation. 2006-05-23 14:11:13 +02:00
Dmitry Timoshkov b67da5b946 Make more of the OLE interface vtables const. 2005-06-01 19:57:42 +00:00
Peter Berg Larsen 6aefbc0934 Strncpy elimination. 2005-04-18 15:36:20 +00:00
James Hawkins e8cafa5799 Properly implement DllCanUnloadNow ref counting. 2005-01-26 19:41:43 +00:00
James Hawkins ba92d2924a - Use Interlocked* instead of ++/-- in AddRef/Release.
- Use only stored result of Interlocked* in AddRef/Release.
- Expand TRACEs to display the ref count.
2005-01-14 16:02:20 +00:00
Eric Pouech cf1d00bb08 Removed excessive statement (break after return or goto, not useful
break, not needed vars...)
2005-01-09 16:42:53 +00:00
Francois Gouget ee0344a4a2 Remove unneeded NULL casts. 2004-12-22 15:13:20 +00:00
Hans Leidekker fe442b21f7 Fix signed/unsigned comparison warnings. 2004-09-08 01:23:57 +00:00
Alexandre Julliard f714b39762 Get rid of the no longer used ICOM_MSVTABLE_COMPAT_DummyRTTIVALUE
macro.
2004-08-23 19:39:48 +00:00
Alexandre Julliard 48c4bb3c31 Get rid of the non-standard ICOM_VTABLE macro. 2004-08-12 23:00:51 +00:00