Commit Graph

64 Commits

Author SHA1 Message Date
Zhiyi Zhang afdf14084e user32/tests: Remove an extraneous check.
Remove a check for SetFocus() return value. It's useless and SetFocus()
returns NULL because there is no previous focus window, skipping
following tests unintentionally. And cleanup some code.

Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-09-03 20:42:56 +02:00
Nikolay Sivov 47a44e6d9c user32/dialog: Fix setting negative dialog item ids.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=46494
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-01-24 19:39:46 +01:00
Alistair Leslie-Hughes d8a27a78dd user32: Don't reset focus if current dialog is a child.
The standard File Open Dialog creates an empty WS_EX_CONTROLPARENT
child dialog which shouldn't receive focus.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=46215
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-12-17 22:35:14 +01:00
Dmitry Timoshkov 5277aa8f64 user32: Fix the pointer to custom dialog control data.
Suggested by vendor2013@herdsoft.com.

Signed-off-by: Dmitry Timoshkov <dmitry@baikal.ru>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-10-01 19:12:23 -07:00
Dmitry Timoshkov 606b027277 user32/tests: Add a test for custom dialog control data.
Signed-off-by: Dmitry Timoshkov <dmitry@baikal.ru>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-10-01 19:12:22 -07:00
Zhiyi Zhang 608aa7f3d7 user32: Send notification for the focused button in IsDialogMessage().
When handling WM_KEYDOWN,VK_RETURN messages from a dialog hwnd in
IsDialogMessage(), if the focused button is in the dialog, send a BN_CLICKED
notification to the dialog proc. This also make it possible for the
default button with an id larger than 0xFFFF in the dialog to receive
the correct BN_CLICKED notification, which has a null lParam before this.

Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-16 21:28:45 +02:00
Zhiyi Zhang 8318b11d7f user32/tests: Fix a memory leak.
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-16 21:28:45 +02:00
Michael Stefaniuc 1694ab087a user32/tests: Use the available ARRAY_SIZE() macro.
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-06-28 18:27:20 +02:00
Nikolay Sivov 9640990e43 user32: Don't convert message arguments when calling dialog procedure.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-02-19 16:57:53 +01:00
Nikolay Sivov eebdb457bf user32/tests: Extend message conversion tests.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-02-12 15:33:09 +01:00
Alexandre Julliard 2d0704f73a user32/tests: Fix pointer conversion warnings.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-02-05 12:57:01 +01:00
Nikolay Sivov 6ca3ec5be8 user32/tests: Add more A/W message data conversion tests.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-01-30 09:06:49 +01:00
Nikolay Sivov df88f96da1 user32/tests: Add some more tests for message data conversion in dialog procedures.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-01-08 22:47:24 +01:00
Nikolay Sivov 7fad896f29 user32/tests: Add missing return value test (Coverity).
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-01-02 13:25:20 +01:00
Nikolay Sivov 41a76447dd user32/tests: Add some tests for A/W auto conversion in case of mismatching window vs dialog procedure types.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-12-28 21:36:55 +01:00
Dmitry Timoshkov 3d66e753e7 user32: DialogBoxParam should return -1 when dialog control creation fails.
Signed-off-by: Dmitry Timoshkov <dmitry@baikal.ru>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-08-24 14:03:38 +09:00
Dmitry Timoshkov a62a8601db user32/tests: Test DialogBoxParam using a dialog template with invalid control class.
Signed-off-by: Dmitry Timoshkov <dmitry@baikal.ru>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-08-24 14:00:17 +09:00
Nikolay Sivov 9ee82b9465 user32/msgbox: Fix static control id.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-07 16:19:18 -05:00
Nikolay Sivov 17987c589f user32: Handle invalid dialog handles in IsDialogMessage().
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-08-17 11:53:41 +09:00
Piotr Caban 73ee2a8b4f user32: Select text control content while setting dialog focus.
Signed-off-by: Piotr Caban <piotr@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-02-19 00:49:11 +09:00
Nikolay Sivov 8a7e7ec6a1 user32/tests: Simplify some tests using todo_wine_if().
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-02-11 12:17:31 +09:00
Piotr Caban 6c5d4cb07e user32: Only use DIALOGINFO->hwndFocus to store last focus of inactive windows. 2015-02-06 00:28:34 +09:00
Piotr Caban 91eced0ce5 user32: Only store dialog focus when window is hidden or inactive. 2015-01-07 23:48:28 +01:00
Frédéric Delanoy bb2be17327 user32/tests: Use BOOL type where appropriate. 2013-11-05 11:16:00 +01:00
Dmitry Timoshkov f237d5eef2 user32/tests: Fix dialog tests compilation with __WINESRC__ defined. 2013-10-23 17:01:47 +02:00
Alexandre Julliard 3369c53202 user32/tests: Define the required Windows version before including anything. 2013-02-18 14:51:05 +01:00
Alex Henrie 4b67e6c778 user32: Correct dialog focus behavior. 2012-08-16 11:59:23 +02:00
Dmitry Timoshkov 38387dcffe user32: IsDialogMessage should allow control ids other than IDOK when processing WM_KEYDOWN. 2012-03-29 20:49:19 +02:00
Alex Henrie 59c398b8ed user32: If a dialog has no tab-accessible controls, set focus to first control (with tests). 2011-12-05 20:12:14 +01:00
Michael Stefaniuc 8cd1d5839f user32/tests: Drop superfluous function pointer casts. 2011-11-21 11:51:12 +01:00
Dmitry Timoshkov 2429ef905c user32: Dialog creation code should force WS_CHILD style for dialog controls. 2011-11-15 19:37:33 +01:00
Dmitry Timoshkov 70caadbf34 user32: Add support for iPaddedBorderWidth in NONCLIENTMETRICS. 2011-10-08 19:47:35 +02:00
André Hentschel a355121414 user32: Fix for finding nested default buttons. 2011-07-28 19:54:46 +02:00
André Hentschel 54ca4034cf user32/tests: Fix two typos. 2011-07-22 12:57:20 +02:00
André Hentschel b3fbdfa908 user32/tests: Add test for nested default button in dialogs. 2011-07-18 16:23:30 +02:00
Marcus Meissner cfe4c7fde9 user32: Use left shift instead of right shift (Coverity). 2011-05-05 17:28:42 +02:00
Vladimir Panteleev 592d994f00 user32: Fix VK_RETURN handling in IsDialogMessage for dialogs without an IDOK. 2010-09-15 17:05:54 -05:00
André Hentschel 9c1149045f user32/tests: The dialog for that proc has no IDCANCEL. 2010-07-07 11:30:27 +02:00
André Hentschel f0e21b0e62 user32/tests: Test that GetDlgItem does not recurse. 2010-07-02 13:19:21 +02:00
Andrew Eikum 17789c1636 Revert "user32: Don't use DLGTEMPLATE's ExStyle when creating dialogs.".
This reverts commit 897f11d331.
2010-05-19 11:17:55 +02:00
Andrew Eikum 897f11d331 user32: Don't use DLGTEMPLATE's ExStyle when creating dialogs. 2010-05-08 13:12:49 +02:00
Nikolay Sivov 0af447ce9f user32/tests: Add some GetDlgItem() tests regarding children windows Z-order. 2010-04-25 19:22:11 -05:00
Henri Verbeet 6ee4a87ad6 user32: Also show dialogs right after a WM_TIMER message. 2010-03-02 14:29:21 +01:00
Andrew Nguyen 416589a7c2 user32/tests: Fix a failure message trace. 2010-02-23 12:09:55 +01:00
Andrew Nguyen 0b23012867 user32: Ensure that WM_INITDIALOG passes the first tabstop control handle to the dialog procedure. 2010-02-23 12:09:50 +01:00
Nikolay Sivov ba51a6c9bc user32/tests: Forward test proc to default dialog procedure instead of window's one. 2010-01-08 17:04:00 +01:00
Sergey Khodych f1f1c50531 user32: Use IDOK as default identifier in a template. 2009-08-26 16:38:39 +02:00
Andrew Nguyen 918c9d5994 user32/tests: Fix a test failure on Win9x. 2009-08-24 15:17:32 +02:00
Andrew Eikum c1c22e25c2 user32/tests: Add tests for saving and restoring control focus. 2009-08-14 13:58:49 +02:00
Dmitry Timoshkov 96e44ddb78 user32: Return 0 from DefDlgProc and dialog loop for invalid dialog handles. 2009-08-12 12:53:25 +02:00