Commit Graph

145 Commits

Author SHA1 Message Date
Jonathan Ernst 360a3f9142 Update the address of the Free Software Foundation. 2006-05-23 14:11:13 +02:00
Eric Pouech 1be2e1edef shell32: Fixes for bugs found by valgrind on shell32 tests harness.
- read strings from left to right (PathGetDriveNumberW)
- don't access buffers before they are filled (SHGetPathFromIDListW)
- fill buffers & variables on all paths (SHELL_FindExecutable)
- handle error condition (unix_fs)
- don't shoot in the blind for AW APIs (tests/shelllink.c)
2006-02-22 12:04:02 +01:00
Michael Jung d7326ca7e5 shell32: Return a GUID pidl for CSIDL_PERSONAL in SHGetFolderLocation.
The tests (shellpath.c/testPersonal) already show that it can be either 
PT_FOLDER or PT_GUID. It's PT_GUID on WinXP.
2006-02-14 11:35:12 +01:00
Huw Davies 51fd750707 shell: Fix incorrect usage of the return value of StrRetToStrNW. 2006-01-20 20:17:07 +01:00
Michael Jung 5136f57f12 shell32: Helper function for unicode support in folder and file pidls. 2006-01-03 13:23:44 +01:00
Francois Gouget 0edbaf7e80 Remove spaces before '\n' in traces. 2005-11-10 12:14:56 +00:00
Markus Amsler 671738d5c1 Improve c2man Documented-Total count. Changes:
- add missing description
- add missing returns section
- complete missing A/W pairs
- reformate comments, to match c2man requirements
2005-11-10 11:15:22 +00:00
Michael Jung 937441b3ac Don't clone pidlLast in SHBindToParent. 2005-09-07 09:22:49 +00:00
Jason Edmeades c1cd0d22e0 Add the time to the file display dialog modified column. 2005-08-19 10:01:25 +00:00
Ge van Geldorp 75139a3e01 Fix resource leak on error paths. 2005-08-15 14:50:18 +00:00
Michael Jung 433197172d Fail in SHGetDataFromIDList when called on special folder. 2005-07-08 14:18:32 +00:00
Mike McCormack e28c014a84 -Wpointer-sign fixes. 2005-07-03 12:03:35 +00:00
Michael Jung ebb1aaee86 Implement SHGetPathFromIDList based on GetDisplayNameOf. 2005-06-15 10:20:00 +00:00
Mike Hearn 25abe7c537 Fix SHELL_GetPathFromIDList[AW] to return the desktop path given an
empty PIDL.
2005-05-10 08:27:23 +00:00
Huw Davies 0e5b772cdc Add a unicode pidl type.
Improve support for PT_YAGUID.
Improve IShellLink debugging.
2005-04-13 14:39:27 +00:00
Francois Gouget 93416cdaf7 Assorted spelling fixes. 2005-03-23 13:15:18 +00:00
Mike McCormack 3d9ba61478 Cleanup, create unicode versions of _ILCreateFromPath,
_ILCreateGuidFromStr, and _ILCreateFromFindData.
2005-02-22 14:50:35 +00:00
Mike McCormack 59ce35aba8 Remove tabs and make formatting consistent. 2005-02-21 18:36:47 +00:00
Francois Gouget 4d801b66e6 Assorted spelling fixes. 2005-02-10 19:19:35 +00:00
Michael Stefaniuc 5ad7d858e0 Do not check for non NULL pointer before HeapFree'ing it. It's
redundant.
2004-12-23 17:06:43 +00:00
Alexandre Julliard 758b2887e9 Remove some no longer needed AW functions. 2004-12-17 19:20:07 +00:00
Jon Griffiths f82272c92f Remove unneeded headers to reduce unneeded rebuilds. 2004-12-16 14:35:55 +00:00
Eric Pouech 0a258964c2 Const correctness fixes. 2004-11-30 21:38:57 +00:00
Juan Lang 535679aec7 Fix CSIDL_CONTROLS and CSIDL_PRINTERS PIDL types, and update tests now
that they pass.
2004-10-26 00:17:31 +00:00
Francois Gouget 486d020c1b Don't define COBJMACROS in objbase.h.
Update the Wine sources accordingly.
2004-10-07 03:06:48 +00:00
Marcus Meissner 2e6e18bfbb Marked some functions in debughlp as static.
Do not use REFIID as return, but IID*.
2004-08-09 18:49:42 +00:00
Ge van Geldorp c390bb2aea Match prototypes to Platform SDK. 2004-06-28 20:32:53 +00:00
Juan Lang 6d169747d6 Correct return value in a couple of error cases. 2004-04-15 05:04:10 +00:00
Martin Fuchs a9a04e8d4f - make drive letters in PIDLs always uppercase to enable PIDL
comparison
- Unicodify _ILCreateDrive()
2004-04-15 04:57:46 +00:00
Martin Fuchs 618cf6fc0f Return "file not found" error values instead of E_INVALIDARG if
_ILCreateFromPathA() failed to find files.
2004-04-14 23:57:46 +00:00
Juan Lang bbdd20d536 Correct some PIDL types and eliminate some magic numbers in PIDL
allocation; correct a copy-pasto from a previous patch.
2004-04-14 19:33:07 +00:00
Juan Lang c00fbafbbf Move control panel applet enumeration to cpanelfolder.c. 2004-04-08 04:37:43 +00:00
Martin Fuchs 31cd6b8cf3 - SHBindToParent(): request correct COM interface from desktop.
- _ILCreateFromFindDataA(): type cast to eliminate MSVC compiler
  warning.
2004-04-07 21:58:50 +00:00
Juan Lang f3301c6ba9 - comment fixes
- improved error checking and conformance with Windows
- remove some spurious error messages
2004-04-07 19:45:48 +00:00
Juan Lang 42f28a72e9 - rename PT_SPECIAL to PT_SHELLEXT
- remove unnecessarily complex _ILCreate
- combine _ILCreateValue and _ILCreateFolder, since their outputs
  differed by only one byte.
2004-04-06 23:12:11 +00:00
Juan Lang fe7c9e5f95 Rename PT_MYCOMP to PT_GUID, and the corresponding union member from
mycomp to guid.
2004-04-06 03:22:29 +00:00
Martin Fuchs dd46d6df9e Implementation of the control panel folder in shell namespace. 2004-03-27 01:42:22 +00:00
Francois Gouget b948778660 Assorted spelling fixes. 2004-03-23 23:20:16 +00:00
Robert Shearman f6e1be6afe Allow passing NULL to ILFindLastID. 2004-03-22 22:58:19 +00:00
Alexandre Julliard 22508e576f FindFirstFile can return an empty short name if the long name is a
valid DOS name, fixed callers to handle that properly.
2004-03-17 01:50:27 +00:00
Martin Fuchs fa828cd057 - move some PIDL function declarations from undocshell.h into public
header, as they are no longer undocumented
- implement context menu support for Winefile
2004-02-11 04:18:12 +00:00
Mike McCormack cb9a22b787 Fix the bounds checking in SHGetPathFromIDListA/W. 2004-02-09 20:56:41 +00:00
Francois Gouget 6b6ed724ae Add missing '\n's to debug traces. 2004-01-27 00:01:43 +00:00
Martin Fuchs 516b50f34c - don't link directly to NTDLL; use MultiByteToWideChar() instead of
RtlCreateUnicodeStringFromAsciiz()
- directly call InitCommonControlsEx()
2004-01-26 20:13:03 +00:00
Alexandre Julliard aa43d01627 Authors: Martin Fuchs <martin-fuchs@gmx.net>, Ge van Geldorp <ge@gse.nl>
Reimplementation of SHGetPathFromIDListA/W() using the new helper
functions SHELL_GetPathFromIDListA/W(). The new implementation avoids
using IShellFolder::GetDisplayNameOf(), so that it
- returns the absolute file system path, not relative to the dekstop
- returns FALSE as error code if the path can not converted in a valid
  file system path
- doesn't return virtual CLSID paths
2004-01-21 23:50:26 +00:00
Martin Fuchs 74bcd4e43f Implemented SHGetRealIDL(). 2004-01-21 22:12:55 +00:00
Martin Fuchs 423cb99ac5 - SHGetDataFromIDListA/W(): handle drives when retrieving file
attributes
- fixed error handling to avoid GPFs
2004-01-20 23:38:04 +00:00
Martin Fuchs 6e775f898a - declare PT_RAS_FOLDER for the "RAS Connections" folder
- handle PT_RAS_FOLDER and PT_NETPROVIDER in debugging functions and
  _ILGetTextPointer() / _ILGetSTextPointer()
2004-01-18 22:08:46 +00:00
Martin Fuchs 963dd34ec0 - correct return value of SHGetPathFromIDList[AW]() for virtual
folders like "My Computer"
- correct path parsing in ISF_Desktop_fnParseDisplayName()
- handle CLSID paths in ISF_MyComputer_fnParseDisplayName()
- return CLSID path in ISF_MyComputer_fnGetDisplayNameOf()
2003-12-30 19:24:22 +00:00
Dmitry Timoshkov 3baa9b99fd Protect ILIsParent from NULL pidls. 2003-11-04 04:21:01 +00:00