Dimitrie O. Paun
c093196c05
Transform the invalidation macros to proper functions.
2002-10-23 22:30:39 +00:00
Dimitrie O. Paun
bf46fab650
Delay some size computations until after first paint.
2002-10-23 22:29:47 +00:00
Rein Klazes
7d9b04dbe2
Reorganize the item size calculation (a bit simpler, and faster).
2002-10-23 22:28:44 +00:00
Rein Klazes
1fd077939f
Search through all items when LISTVIEW_FindItemW is called with
...
LVFI_PARAM flag.
2002-10-23 22:28:03 +00:00
Dimitrie O. Paun
bf761a331c
Delete the items if we actually own them.
2002-10-23 22:25:42 +00:00
Dimitrie O. Paun
8f15b6e6b3
Do not callback to the parent for lParam when in LVS_OWNERDATA.
...
Docs update.
2002-10-23 22:25:10 +00:00
Michael Stefaniuc
353529b2c8
- fix the "int format, HANDLE arg" type of warnings for comctl32
...
- compile the comctl32 dll with -DSTRICT
2002-10-23 22:19:10 +00:00
Michael Stefaniuc
85e40cf37a
Add casts to compile with -DSTRICT.
2002-10-23 20:58:33 +00:00
Dimitrie O. Paun
5acd96bb4e
Do not crash if callback text is not filled (behave like native).
...
Render report mode from top to bottom (easier on the eye).
Docs updates, type fixes, more traces.
2002-10-23 20:57:13 +00:00
Dimitrie O. Paun
6608328f76
Collect all bugs, missing features, etc in the header doc.
...
Minor cleanups.
2002-10-23 20:56:30 +00:00
Dimitrie O. Paun
9ff0da09ff
Do not autoarrange if we insert/delete from the end of the list.
2002-10-23 20:55:05 +00:00
Dimitrie O. Paun
c5da549d10
Rework SetItemPosition, bunch of bugs squashed in the process.
...
Complete icon alignment rewrite: cleaner, incremental, etc.
Completely avoid aligning all icons on every insert
- icon placement is incrementally computed now: it's fast.
Small cleanups, docs update, etc.
2002-10-23 20:54:23 +00:00
Dimitrie O. Paun
c5e2731939
Rename LISTVIEW_ITEM to ITEM_INFO for consistency.
...
Rename LISTVIEW_SUBITEM to SUBITEM_INFO for same reason.
Fix type in comment spotted by Bobby Bingham.
2002-10-23 20:53:42 +00:00
Patrik Stridvall
cf07e10017
Don't use wine/unicode.h in the header files, include it directly
...
where needed instead.
2002-10-23 20:20:59 +00:00
Michael Stefaniuc
f3d1893f80
Add needed casts for a "no warnings" compile of comctl32.
2002-10-23 20:19:22 +00:00
Christian Neumair
513eb2a24a
Collect all bugs, missing features, etc in the header doc.
2002-10-23 18:43:32 +00:00
Dimitrie O. Paun
d664540782
Bring header's height more inline with native's.
2002-10-22 00:41:45 +00:00
Dimitrie O. Paun
254e7484fa
DPAs can't have more than 0x8000 elements (fixed with lots of help
...
from Carlos <clozano@andago.com).
2002-10-21 19:54:06 +00:00
Dimitrie O. Paun
c7fbc1b2c9
No need to increment item size, it's already adjusted by DPA_SetPtr
...
(found, and fixed by Carlos <clozano@andago.com>).
2002-10-21 19:49:44 +00:00
Dimitrie O. Paun
6168b98176
Do not rely on HeapReAlloc to allocate a NULL pointer.
2002-10-21 19:49:12 +00:00
Dimitrie O. Paun
7888385d76
Rewrite DPA_InsertPtr in terms on DPA_SetPtr, so that it's simpler,
...
cleaner, and more correct.
It now expands the array to accomodate larger than current size
indexes.
2002-10-21 19:48:37 +00:00
Dimitrie O. Paun
a87b685350
Do not send uninitialized lParams on notification msgs (found by Rein
...
Klazes <rklazes@xs4all.nl>).
2002-10-21 19:46:46 +00:00
Dimitrie O. Paun
6deae0b86d
Complete rewrite of the rcView implementation.
...
Lots of bugs fixed in rcView computation.
Assorted cleanups, and simplifications.
2002-10-21 19:46:08 +00:00
Dimitrie O. Paun
c9e0133357
Split ranges_destroy in ranges_clear, and ranges_destroy.
...
Rewrite DeleteAllItems, for cleaner, faster, more correct code.
2002-10-21 19:45:29 +00:00
Dimitrie O. Paun
62f4c61d22
Updated header documentation to the latest, and greatest.
2002-10-21 19:44:51 +00:00
Dimitrie O. Paun
06701fb09e
Optimize invalidation on insert.
...
Share the invalidation code between {Delete,Insert}Item.
2002-10-21 19:44:18 +00:00
Dimitrie O. Paun
f18e271bff
Rewrite DeleteItemT: cleaner, a lot faster.
...
Number of bug were fixed.
The minimum possible is redrawn.
2002-10-21 19:43:37 +00:00
Dimitrie O. Paun
c859242ac8
Implement most of LVM_ARRANGE.
...
Make use of it, where it was appropriate.
Use infoPtr->dwStyle directly, in most places.
Assorted cleanups.
2002-10-21 19:43:03 +00:00
Dimitrie O. Paun
56c17651a0
Proper (type wise) return types.
2002-10-21 19:42:30 +00:00
Dimitrie O. Paun
214c721160
Reorganize header notifications.
...
Support notifications that don't have embedded size info.
Invalidate columns on format change (if needed).
Assorted cleanups.
2002-10-21 19:41:56 +00:00
Dimitrie O. Paun
713d0a061f
Crash on internal NULL pointers, don't test all over the place.
2002-10-21 19:41:00 +00:00
Dimitrie O. Paun
e37692bd33
When removing focus, no need to go through all elements.
2002-10-21 19:40:26 +00:00
Dimitrie O. Paun
feb326118f
Fix colors for selected items in full row select mode.
...
Fix bug caused by use of uninitialized state.
2002-10-21 19:39:45 +00:00
Dimitrie O. Paun
7c26e53ac0
Fix computation of subitem box, when invalidating it.
2002-10-21 19:34:38 +00:00
Dimitrie O. Paun
2223014df3
Assert on inconsistent range list states.
...
Various code cleanups, few potential bugs fixed.
2002-10-21 19:33:59 +00:00
Dimitrie O. Paun
074e2b4caa
Do not grow the item list to arbritary index: if requested index is
...
larger than current count, just append.
Miscellaneous cleanups.
2002-10-21 19:33:14 +00:00
Dimitrie O. Paun
be0641face
SetColumnWidth rewrite: simpler, cleaner code. Bugs squashed.
2002-10-21 19:32:38 +00:00
Dimitrie O. Paun
bf965278b5
Handle generic column width changes.
...
Fix bug in SetColumnT which rendered it unusable.
Column code cleanup.
2002-10-21 19:32:07 +00:00
Dimitrie O. Paun
0acaf0e961
Assert on internal invariants, rather than fail gracefully.
2002-10-21 19:31:34 +00:00
Dimitrie O. Paun
88c26b9c01
More docs compliant alignment handling for subitems.
2002-10-21 19:31:01 +00:00
Dimitrie O. Paun
f8514f5b3c
Fix notification from header, on item changed.
...
Small indentation fixes.
2002-10-21 18:22:51 +00:00
Duane Clark
d126f4768c
Correct the behavior for disabled toolbar buttons.
2002-10-21 18:19:02 +00:00
Dimitrie O. Paun
0def1dd4e4
Do not create a range list for an empty range.
2002-10-19 19:26:17 +00:00
Dimitrie O. Paun
0613b7212a
Store the entire format bitmap in the column info.
...
Rewrite GetColumnT to take advantage of that.
Related cleanups, and simplifications.
2002-10-19 19:25:41 +00:00
Dimitrie O. Paun
569de03864
Column zero has the image enabled always, irrespective of format.
2002-10-19 19:25:01 +00:00
Dimitrie O. Paun
231e9ef25b
Unify {Insert,Set}ColumnT as much as possible.
...
Fix a bunch of problems in SetColumnT.
2002-10-19 19:24:24 +00:00
Dimitrie O. Paun
3893cb7fb2
Fix function header documentation.
2002-10-19 19:23:31 +00:00
Dimitrie O. Paun
e877b77a9d
Better report mode.
...
Use the new column information to simplify, and speed up the code.
Enable support for images in subitems (in LVS_REPORT mode).
2002-10-19 19:20:35 +00:00
Dimitrie O. Paun
0dbab63fa6
When deleting an item, remove selection, don't add it!
2002-10-19 00:59:34 +00:00
Dimitrie O. Paun
0ba3dc7589
More traces to help us make sense of the output.
...
Faster, cleaner ranges_{add,del}.
2002-10-19 00:21:02 +00:00
Dimitrie O. Paun
c79eb2de5f
Fix ranges insertion bug (specify DPAS_SORTED when searching).
...
Add a lot of assert-ed consistency checks.
Add bunch of trace messages.
2002-10-19 00:20:21 +00:00
Dimitrie O. Paun
a2dd8ecc33
Inspect style bits independently on style change.
2002-10-19 00:19:28 +00:00
Dimitrie O. Paun
b50692ee82
Rewrite StyleChanged procedure
...
o some bugs have been fixed
o cleaner, simpler code
Fix some corner case, icon size computation bugs.
Assorted docs updates.
2002-10-19 00:18:48 +00:00
Dimitrie O. Paun
323f9c23f0
Keep track of per-column information inside the listview.
...
Cache header rectangles.
Used the cached info instead of calling to the header each time.
Update the listview as we track column width changes.
Unify column handling between {Insert,Delete}Column, and width
changes.
Simplify RefreshReport, by using the new column info.
2002-10-19 00:18:11 +00:00
Dimitrie O. Paun
a72e9f617e
Do not query items that are just being inserted.
2002-10-19 00:17:24 +00:00
Dimitrie O. Paun
f8f559fa3c
Reorganize things a bit so that we no longer need the 'valid' flag on
...
each item.
Small comments update.
2002-10-19 00:16:37 +00:00
Alexandre Julliard
23bb3715f7
Added support for building certain dlls with -DSTRICT.
...
Added -DWINE_NO_STRICT flag to dlls that don't support STRICT yet.
2002-10-18 23:46:28 +00:00
Martin Fuchs
fe7d46a221
pszText is stored as Unicode, so call DrawTextW() instead of
...
DrawTextA().
2002-10-18 00:20:04 +00:00
Dimitrie O. Paun
c18c7332b8
Instrument SetItemT to change only _one_ item at a time. That is, if
...
we have to change focus, we call it recursively to first remove the
focus from the item that has it. This allows simpler, and more correct
invalidation handling.
2002-10-17 21:55:41 +00:00
Dimitrie O. Paun
8f38417376
Unify set_{owner,main}_item functions.
...
Fix {old,new}state and lParam reporting in LVN_ITEMCHANG{ING,ED}.
Fix sanity check conditions for LVS_OWNERDATA.
2002-10-17 21:54:57 +00:00
Dimitrie O. Paun
96dca36cc8
More, better tracing to help nail down some crashes.
...
Fix typo in GetItemT (found, and fixed by Huw Davies).
Exit right away from GetItemT if nothing is asked (mask == 0).
Assorted code cleanups.
2002-10-17 21:53:56 +00:00
Dimitrie O. Paun
305fb4c3dd
Deal with sparsely populated listviews.
...
Crash on internal corruption.
2002-10-17 21:38:21 +00:00
Dimitrie O. Paun
ef4a6fc7e5
Add ability to create an iterator over a range list.
...
Fix memory leak when destroying ranges.
Add function that will to a 'deep' clone of a range list.
Add function that will subtract a range list from another.
Do not crash on NULL ranges (similar in spirit to HDPAs).
Fancy deselection routines uses the above infrastructure to deselect
the minimum possible.
Modify SetGroupSelection to take advantage of all this new
infrastructure, to avoid flicker on selection extension.
2002-10-17 21:37:24 +00:00
Dimitrie O. Paun
fa81ec674b
Change the definition of ranges to exclude the upper bound.
2002-10-17 21:36:29 +00:00
Dimitrie O. Paun
bac35001fe
Handle range tracing in a consistent fashion.
2002-10-17 21:35:47 +00:00
Dimitrie O. Paun
58b2ad925b
Remove dated comments.
2002-10-17 21:35:08 +00:00
Dimitrie O. Paun
66dd824dbc
Better encapsulation of the ranges concept.
2002-10-17 21:34:15 +00:00
Dimitrie O. Paun
be8189bd9c
Notification code cleanup, more traces, etc.
2002-10-17 01:20:18 +00:00
Jerry Jenkins
7d789599d5
Added missing RemoveProp calls.
2002-10-17 01:18:52 +00:00
Dimitrie O. Paun
89eb8fdba3
We need to provide focus info always in ICON mode (spotted by Huw
...
Davies).
2002-10-16 19:57:31 +00:00
Mike McCormack
bcfffe7b08
Duplicate selected items list in LISTVIEW_RemoveAllSelections to
...
prevent infinite loops.
2002-10-16 19:56:06 +00:00
Dimitrie O. Paun
3dd4dabffb
Remember the global colors in custom draw mode.
2002-10-16 19:05:43 +00:00
Dimitrie O. Paun
ef9adbb6f5
Compute only the old state that we're gonna look at.
2002-10-16 19:05:02 +00:00
Dimitrie O. Paun
8d2f7224f1
Instrument SetItemT to avoid repainting if nothing changed.
...
Teach RemoveAllSelections to skip an item, so we can eliminate the
flicker when we click on a selected item.
2002-10-16 19:04:07 +00:00
Dimitrie O. Paun
3c9591b413
Fix bug in edit label when sending the text to the app.
...
Cleanup the handling of nEditLabelItem.
2002-10-16 19:03:25 +00:00
Dimitrie O. Paun
07a6a3975a
Edit label cleanup.
2002-10-16 19:02:32 +00:00
Dimitrie O. Paun
6b4a11af0a
Fix bug in ranges_shift which was corrupting selections.
...
Fix click notification (found and fixed by Alexandre Julliard).
Fix bug in setting item's state (some selection changes were lost).
Simplify selection code substantially.
Add a lot of debug tracing.
2002-10-16 19:01:38 +00:00
Dimitrie O. Paun
da9bac4d9e
Add comment on what is known about the current state of the controls
...
relative to comctl32.dll version 6.0.
2002-10-16 18:57:14 +00:00
Dimitrie O. Paun
db14dbf12b
Fix iterator creation for LVS_LIST mode.
...
Do not update the infoPtr->nItemWidth in set_main_item.
Better handling of text bk colour in custom draw.
Rename GetItemListOrigin to GetItemOrigin.
A bunch of code cleanups, simplifications, etc.
2002-10-15 21:08:09 +00:00
Dimitrie O. Paun
17dce17a58
No longer compute the ill-defined bounds in GetItemMetrics.
...
Fix a bunch of bug in subitem metrics computation.
Properly implement GetSubItemRect in terms of GetItemMetrics.
Documentation updates, and code cleanups.
2002-10-15 21:07:01 +00:00
Dimitrie O. Paun
3a5105c957
Teach GetItemMetrics to deal with subitems in report mode as well.
...
Unify Draw{,Sub}Item, simplify RefreshReport.
2002-10-15 21:06:14 +00:00
Dimitrie O. Paun
f378bbd5a5
Fix iterator creation for LVS_LIST mode.
...
Use assert() instead of hand-made hack.
2002-10-15 21:05:29 +00:00
Dimitrie O. Paun
3baa344a43
Fix iterators to properly deal with LVS_{,SMALL}ICON modes.
...
Unify the Refresh{List,Icon} functions.
Simplify HitTest to make full use of the iterators.
Fix selection bounds in HitTest.
Avoid empty default to silence warning in gcc 3.2.
2002-10-15 21:03:10 +00:00
Dimitrie O. Paun
50b4688c7e
Iterator updates:
...
Add the notion of a special item which sits at the start of the
list.
Add the ability to iterate in both directions through the list.
Document the iterator interface.
Remove iterator_visibleitems.
Rename iterator_clippeditems to iterator_visibleitems for
consistency.
Use the new bidirectionality to paint the items in decreasing order.
2002-10-15 21:01:57 +00:00
Dimitrie O. Paun
0bc4b56595
Do not merge image with garbage background. Based on a patch by Carlos
...
<clozano@andago.com>.
2002-10-15 02:15:09 +00:00
Michael Günnewig
2cf92565df
Fixed division by zero, when range is 0.
2002-10-15 01:20:51 +00:00
Uwe Bonnes
e14cfc497a
Add function to get size of in-memory resource and used this function
...
to copy resource to writable memory.
2002-10-13 17:54:48 +00:00
Dimitrie O. Paun
00ea0868ba
Rename GetItemHeight to CalculateMaxHeight, for consistency
...
Fix usage of nItemWidth vs. iconSpacing.cx
Misc cleanups.
2002-10-11 23:34:32 +00:00
Dimitrie O. Paun
a1ca0122b9
Use the item box rather than the bounds when invalidating.
...
Implement 'bPartial' in EnsureVisible.
2002-10-11 23:33:25 +00:00
Dimitrie O. Paun
ed29ffdea4
Unify DrawLargeItem with DrawItem.
2002-10-11 18:47:03 +00:00
Dimitrie O. Paun
0b93d5c4c5
Use GetItemMetrics instead of GetItemMeasures.
...
Remove GetItemMeasures.
Add GetItemBox which only returns the boundary of the item.
2002-10-11 18:46:21 +00:00
Dimitrie O. Paun
ac756afcc2
Be real tough on internal programming errors.
2002-10-11 18:00:28 +00:00
Dimitrie O. Paun
dda1e31ce7
Remove support for owner drawn listviews in non-REPORT mode. We need
...
to do this since Windows supports owner draw *only* in report mode,
and hence apps are not prepared to handle drawing in other modes.
2002-10-11 17:59:39 +00:00
Dimitrie O. Paun
4150f31f58
Use GetItemMetrics instead of GetItemMeasures when drawing.
2002-10-11 17:58:56 +00:00
Dimitrie O. Paun
01b5226508
Make use of the new GetItemMetrics in HitTest, to avoid code
...
duplication.
2002-10-11 17:58:11 +00:00
Dimitrie O. Paun
f1f447931e
Separate item metrics computation from positioning
...
Add support for computing state icon metrics.
2002-10-11 17:57:27 +00:00
Alexandre Julliard
5feaff534b
LVS_OWNERDRAWFIXED should only take effect in REPORT mode.
2002-10-11 04:19:20 +00:00
Dimitrie O. Paun
1c6c29e313
Fix drawing bug introduced with the custom notification
...
reorganization.
2002-10-10 22:57:45 +00:00
Dimitrie O. Paun
01dbe3999e
Simplify the report mode, and item drawing considerably.
...
Fix full row select in report mode.
2002-10-10 22:55:21 +00:00
Dimitrie O. Paun
ffd4bd37d0
Handle custom draw notifications properly.
...
Various cleanups, and simplifications.
2002-10-10 22:54:06 +00:00