ReceiveTempSMS
/
Sweden-Number
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
148,959 Commits 3 Branches 0 Tags 575 MiB
Commit Graph

4012 Commits

Author SHA1 Message Date
Piotr Caban 5fc68884ad msi: Introduce msi_record_stream_name helper. 
Signed-off-by: Piotr Caban <piotr@codeweavers.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2020-06-26 20:57:45 +02:00
Hans Leidekker 15c8e5dee6 msi: Fix installing from administrative image with compressed source files. 
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=49352
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2020-06-10 22:38:49 +02:00
Hans Leidekker 1726b7f46c msi: Return void from init_automation_object. 
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2020-05-06 19:01:53 +02:00
Hans Leidekker 9cc0449577 msi: Add support for bitmap buttons. 
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=48974
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2020-04-21 21:31:34 +02:00
Zebediah Figura 658183a803 msi: Report the real NT version number up to 6.3. 
MSI always reports 6.3 even without a manifest, but does not report anything
higher.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=48959
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2020-04-20 12:35:41 +02:00
Dmitry Timoshkov 76606eaea0 msi: Add support for ListView dialog control. 
Signed-off-by: Dmitry Timoshkov <dmitry@baikal.ru>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2020-03-03 11:43:02 +01:00
Rémi Bernon f961817710 msi/tests: Fix some format-overflow warnings. 
Signed-off-by: Rémi Bernon <rbernon@codeweavers.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2020-02-16 20:48:02 +01:00
Nikolay Sivov 5aeb9ed82e msi: Change unknown platform enum entry name. 
Public shlwapi.h defines same name, it seems safer to rename internal type.

Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2020-02-02 16:22:21 +01:00
Gerald Pfeifer ea032bb7f8 msi: Properly declare variables in msi/tests/utils.h as extern. 
Omitting the extern storage qualifier when declaring a global variable in
a header file is mistake. If that header is included by several files it
results in multiple definitions of the same variable (unless -fcommon is
specified or assumed, the latter being the case for GCC 9.x and earlier).

This fixes building with GCC 10.

Signed-off-by: Gerald Pfeifer <gerald@pfeifer.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2020-01-29 20:32:03 +01:00
Michael Cronenworth cc7f698b82 msi: Global variable compatibility update for gcc 10. 
Signed-off-by: Michael Cronenworth <mike@cchtml.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2020-01-27 16:32:31 +01:00
Hans Leidekker 54ef6e5e39 msi: Add support for custom action type 7. 
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=44618
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2020-01-27 14:44:33 +01:00
Zebediah Figura 4661c8d45b msi/tests: Fix a crash on Windows 10. 
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2020-01-17 12:14:37 +01:00
Zebediah Figura 932ed6bf84 msi/tests: Fix test_feature_override() to properly clean up its features on removal. 
This was leaving behind registry entries (as well as the already accounted-for
program files), which apparently caused subsequent test failures when running
msi:action.

While Wine is not behaving exactly correctly here (i.e. and removing the feature
anyway), I suspect it is not sufficiently interesting to test whether we behave
correctly with what is essentially a buggy package.

Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2020-01-17 12:14:29 +01:00
Hans Leidekker 90422f9bb5 msi/tests: Avoid test failure when running as an unprivileged user. 
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2020-01-03 21:40:59 +01:00
Alexandre Julliard d977c55bb4 msi: Use %define api.pure instead of %pure-parser. 
The latter is deprecated and causes warnings.

Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-11-25 20:47:43 +01:00
Vincent Povirk cce9a5f124 msi: Use integers internally for MSIDBOPEN constants. 
This fixes a bug where some verions of mingw and probably gcc
assume that the result of pointer subtraction will be non-NULL,
causing MSI_OpenDatabaseW to break when given the mode
MSIDBOPEN_READONLY + MSIDBOPEN_PATCHFILE.

Signed-off-by: Vincent Povirk <vincent@codeweavers.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-11-05 16:14:41 +01:00
Hans Leidekker 71f7558206 msi/tests: Remove workarounds for Windows 2000. 
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-10-29 23:30:47 +01:00
Hans Leidekker 8503ad1722 msi/tests: Run the package tests from a temporary directory. 
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-10-29 23:30:47 +01:00
Hans Leidekker 1b4b37cc7e msi/tests: Fix test failures. 
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-10-29 23:30:47 +01:00
Hans Leidekker 4f7bd33a83 msi/tests: Add missing UnpublishFeatures actions. 
Reported by Sven Baars.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=47992
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-10-28 19:19:33 +01:00
Francois Gouget a0c6c8c2ec msi: Fix the spelling of a comment. 
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-10-21 17:11:43 +02:00
Francois Gouget 3f2cae1378 msi/tests: Fix the case of an ok() message. 
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-10-21 17:11:43 +02:00
Sven Baars eec7f10512 msi/tests: Fix a test failure on Windows XP. 
Signed-off-by: Sven Baars <sven.wine@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-09-30 11:47:16 +02:00
Sven Baars fe91ae51f1 msi: Fix a leak on error path (Coverity). 
Signed-off-by: Sven Baars <sven.wine@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-09-26 21:04:52 +02:00
Francois Gouget 208ff02005 msi/tests: Declare the custom subtest. 
It may print test failures and as such should be declared by its parent.

Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-09-03 20:42:56 +02:00
Alistair Leslie-Hughes e4f1f9b7bd msi: Don't error when an ODBC Data Source fails to register. 
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-08-28 10:29:38 +02:00
Piotr Caban d95bffdadb msi: Fix component Action for shared components in CostFinalize. 
Fixes regression in wow .NET4.6.2 installation.

Signed-off-by: Piotr Caban <piotr@codeweavers.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-08-27 11:32:33 +02:00
Michael Stefaniuc 8738075da4 msi/tests: Actually test two return values. 
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-08-27 11:32:25 +02:00
Zebediah Figura e4e7e956bd msi: Close all handles opened by a custom action thread. 
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=47418
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-07-01 14:41:22 +02:00
Hans Leidekker 48f93bc329 msi/tests: Accept case variations for path properties. 
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-06-19 21:43:09 +02:00
Alexandre Julliard 7cd3c9f073 msi: Build with msvcrt. 
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-06-13 14:34:51 +02:00
Alexandre Julliard 3b621e6d6d msi/tests: Don't skip a 64-bit test on Wine. 
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-05-30 20:20:09 +02:00
Alexandre Julliard d5a372abbb include: Move inline assembly definitions to a new wine/asm.h header. 
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-05-14 13:45:07 +02:00
Alexandre Julliard 280d10b277 msi: Use strncmpiW instead of memicmpW for strings without embedded nulls. 
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-05-07 11:31:38 -05:00
Zebediah Figura f73fefd24c msi: Remove registration for no longer used WineMsiRemoteCustomAction coclass. 
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-05-06 07:13:53 -05:00
Alexandre Julliard d4ef782db7 makefiles: Build all tests with msvcrt. 
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-04-24 12:10:51 +02:00
Alexandre Julliard 72f7f57a21 msi/tests: Avoid using snprintf(). 
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-04-23 23:50:44 +02:00
Hans Leidekker 0d17f36c13 msi: Always use the 64-bit registry view to retrieve registered owner and organization. 
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-04-19 12:03:42 +02:00
Hans Leidekker dec192ce22 msi/tests: Check the NT key first when retrieving registered owner and organization. 
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-04-19 12:03:31 +02:00
Hans Leidekker be02ecda3c msi: Get rid of redundant KEY_WOW64_64KEY flags. 
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-04-19 12:03:20 +02:00
Zebediah Figura 3d9363446f msi: Fix handling of architecture in MSIREG_{Open, Delete}UninstallKey(). 
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=47009
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-04-18 23:10:00 +02:00
Hans Leidekker eb508e5a01 msi: Fix architecture handling in the AppSearch action. 
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-04-18 18:47:10 +02:00
Hans Leidekker 7f95ed7cd2 msi: Remove system environment variables on uninstall. 
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-04-18 18:46:08 +02:00
Hans Leidekker 5b6bf621cd msi: Take architecture into account when accessing the shared dll reference count. 
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-04-18 18:44:19 +02:00
Hans Leidekker 5caebb2650 msi: Get rid of a redundant get_registry_view call. 
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-04-18 18:44:14 +02:00
Hans Leidekker 70732e273e msi: Use KEY_WOW64_* flags in ACTION_Register/UnregisterClassInfo. 
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-04-18 18:44:10 +02:00
Piotr Caban 8c4b75f252 msi: Use case sensitive compare in handle_msi_break. 
Signed-off-by: Piotr Caban <piotr@codeweavers.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-04-05 09:13:38 +02:00
Louis Lenders 2e95d2247d msi: Add MsiSourceListForceResolution{A,W} stub. 
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=46881
Signed-off-by: Louis Lenders <xerox.xerox2000x@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-03-28 18:43:18 +01:00
Zebediah Figura 942964fdfb msi: Handle the remote case in MsiViewGetError(). 
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=46830
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-03-27 11:28:02 +01:00
Zebediah Figura 6a3dbf1192 msi: Perform partial copies in MsiViewGetError(). 
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-03-27 11:28:02 +01:00
Zebediah Figura fac04043d9 msi/tests: Separate and expand tests for MsiViewGetError(). 
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-03-27 11:28:02 +01:00
Zebediah Figura b2d3567c1b msi: Return ERROR_INVALID_HANDLE when MsiOpenPackage() is called from a custom action. 
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-03-26 13:46:18 +01:00
Zebediah Figura 4bb40d1a95 msi: Return ERROR_INVALID_HANDLE when MsiEnableUIPreview() is called from a custom action. 
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-03-26 13:46:16 +01:00
Zebediah Figura 19420f5f7c msi: Return ERROR_INVALID_HANDLE when MsiDatabaseImport() is called from a custom action. 
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-03-26 13:46:14 +01:00
Zebediah Figura 3ff7d30520 msi: Return ERROR_INVALID_HANDLE when MsiDatabaseExport() is called from a custom action. 
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-03-26 13:46:12 +01:00
Zebediah Figura ed5f4bd14f msi: Return ERROR_INVALID_HANDLE when MsiDatabaseApplyTransform() is called from a custom action. 
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-03-26 13:46:09 +01:00
Zebediah Figura 60b1fd7e87 msi: Return MSIDBSTATE_ERROR when MsiGetDatabaseState() is called from a custom action. 
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=46812
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-03-26 13:46:07 +01:00
Zebediah Figura ae0298d46e msi/tests: Test calling more functions from custom actions. 
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-03-26 13:46:04 +01:00
Hans Leidekker c7f323107b msi: Avoid a crash in RemoveFiles if the component directory is invalid. 
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=46907
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-03-25 22:13:10 +01:00
Zebediah Figura 27a7952a84 msi: Append the custom action client PID to the endpoint name. 
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=46833
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-03-25 10:21:39 +01:00
Zebediah Figura a3dfd2f251 msi: Don't fail the BindImage action if the BindImage table is absent. 
This fixes a regression introduced with
15f852015a and observable with several
installers, including dotnet472.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=46885
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-03-25 10:21:39 +01:00
Hans Leidekker 15f852015a msi: Disable filesystem redirection only when really needed. 
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=46846
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-03-21 08:23:18 +01:00
Erich E. Hoover f1d8218169 msi: Add support for exporting binary streams (Binary/Icon tables). 
The Binary and Icon tables store their data in a different format from
other tables, one column of the data is stored as a "stream" instead
of a normal text field.  With this patch those tables can now be
exported properly by the MSI export functionality.

Signed-off-by: Erich E. Hoover <erich.e.hoover@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-03-15 20:01:57 +01:00
Erich E. Hoover b08d999863 msi: Break out field exporting into a separate routine. 
msi_export_record is a lot more complicated than necessary, this patch
splits out the field export part of that functionality as
msi_export_field.  This also needs to be separate for exporting binary
stream data (next patch).

Signed-off-by: Erich E. Hoover <erich.e.hoover@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-03-15 20:01:48 +01:00
Erich E. Hoover 79fd42fc1a msi: Add support for exporting the _SummaryInformation table. 
The _SummaryInformation table stores a lot of important information
about an MSI database.  This patch adds the ability to export that
table since, like _ForceCodepage, it is stored in a different format
than the other tables.

Signed-off-by: Erich E. Hoover <erich.e.hoover@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-03-15 20:01:42 +01:00
Erich E. Hoover 51d5242a5f msi: Add support for deleting streams from an MSI database. 
msidb allows developers to remove "streams" (cabinet files) from a
database with the "-k" mode flag.  To support that feature we need
MSIMODIFY_DELETE support in the underlying MSI implementation.

Signed-off-by: Erich E. Hoover <erich.e.hoover@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-03-15 20:01:27 +01:00
Hans Leidekker 02a25a9d4f msi: Skip the special SummaryInformation stream in msi_commit_streams. 
Avoids adding a useless table stream when called on an existing database.

Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-03-11 17:55:23 +01:00
Hans Leidekker c64d73c829 msi: Don't use globals to manage assembly cache state. 
Based on a patch by Zebediah Figura.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=46719
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-02-26 15:01:01 +01:00
Hans Leidekker bfd02931ac msi: Don't use delay imports. 
This avoids problems with disabling Wow64 filesystem redirection.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=46654
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-02-19 13:10:22 +01:00
Mark Jansen 145b410920 msi: Prevent uninitialized variable usage. 
Observed with Lync 2010 setup in ReactOS. The embedded Silverlight
setup hits this case (no LASTUSEDSOURCE in the registry).

Signed-off-by: Mark Jansen <mark.jansen@reactos.org>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-02-18 16:00:53 +01:00
Mark Jansen c91f254a77 msi: Do not leak rootkey. 
Signed-off-by: Mark Jansen <mark.jansen@reactos.org>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-02-18 16:00:45 +01:00
Hans Leidekker aaead3e433 msi: Link directly to sxs. 
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-02-15 15:07:26 +01:00
Hans Leidekker a70ece68b7 msi: Initialize assembly caches before disabling redirection. 
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=46638
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-02-15 15:07:15 +01:00
Andrey Gusev 57dd594865 msi: Remove duplicate condition in msi_dialog_destroy(). 
Signed-off-by: Andrey Gusev <andrey.goosev@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-02-11 18:31:46 +01:00
Zebediah Figura 4179189ec6 msi/tests: Add more tests for MSIMODIFY_INSERT. 
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-01-30 18:29:54 +01:00
Zebediah Figura 535983743c msi/tests: Add more tests for MSIMODIFY_MERGE. 
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-01-30 18:29:51 +01:00
Zebediah Figura d2e51963a6 msi/tests: Add more tests for MSIMODIFY_REFRESH. 
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-01-30 18:29:49 +01:00
Zebediah Figura 0628a7c8bf msi/tests: Add more tests for MSIMODIFY_ASSIGN. 
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-01-30 18:29:46 +01:00
Zebediah Figura e742319627 msi: Translate records as appropriate in SELECT_modify(). 
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-01-30 18:29:44 +01:00
Zebediah Figura b9faa8d170 msi/tests: Add some more tests for MsiViewModify() applied to joins. 
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-01-30 18:29:41 +01:00
Zebediah Figura 96b6d6b587 msi: Don't check the primary keys when handling MSIMODIFY_DELETE. 
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-01-29 17:12:13 +01:00
Zebediah Figura 0597646455 msi: Implement MSIMODIFY_REFRESH using msi_view_refresh_row(). 
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-01-29 17:12:13 +01:00
Zebediah Figura 31628cee6e msi: Factor out msi_view_refresh_row(). 
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-01-29 17:12:13 +01:00
Zebediah Figura 40a08f8362 msi: Implement UPDATE queries using msi_select_update(). 
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-01-29 17:12:13 +01:00
Zebediah Figura 044c1dd23b msi: Support setting streams in msi_select_update(). 
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-01-29 17:12:13 +01:00
Zebediah Figura 33045101ca msi: Store the IStorage list as an array of STORAGE structures. 
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-01-28 10:25:03 +01:00
Zebediah Figura 7728acd1b6 msi: Remove an unnecessary call to SELECT_get_dimensions(). 
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-01-28 10:25:01 +01:00
Zebediah Figura 7c28a1dbdd msi: Get rid of the get_row() view operation. 
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-01-28 10:24:59 +01:00
Zebediah Figura f45a7b04a6 msi: Set table values directly in msi_select_update(). 
In order to avoid the need to create a temporary record and copy values back
and forth.

Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-01-28 10:24:56 +01:00
Zebediah Figura 99425f272f msi: Factor out int_to_table_storage(). 
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-01-28 10:24:54 +01:00
Zebediah Figura 8aefa871ad msi: Use 0-indexed row numbers in the modify() view operation. 
For consistency with other operations.

Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-01-25 10:28:53 +01:00
Zebediah Figura a7f455b97f msi: Use a BOOL to track string persistence. 
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-01-25 10:28:47 +01:00
Zebediah Figura c2810f40a0 msi: Get rid of the remove_column() view operation. 
It was added to the structure, rather unnecessarily, by ccef56f2c.

Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-01-25 10:28:38 +01:00
Zebediah Figura ced768f2ec msi: Get rid of the find_matching_rows() view operation. 
It was introduced in 9f487ba1d as part of an optimization, but ceased to be used in a52c2bf94.

Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-01-25 10:28:20 +01:00
Zebediah Figura fe23e01527 msi/tests: Use check_record() in more places. 
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-01-25 10:28:09 +01:00
Zebediah Figura 5eab4a59de msi/tests: Use check_record() in test_join(). 
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-01-23 16:32:59 +01:00
Zebediah Figura d7879eaa99 msi/tests: Use check_record() in test_select_column_names(). 
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-01-23 16:32:56 +01:00
Zebediah Figura 2ea8d809e9 msi/tests: Use check_record() in test_dbmerge(). 
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-01-23 16:32:54 +01:00
Zebediah Figura d2edcc9e24 msi/tests: Use check_record() in test_columnorder(). 
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-01-23 16:32:52 +01:00
Zebediah Figura 7e083034d6 msi/tests: Introduce a variadic check_record() helper. 
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2019-01-23 16:32:50 +01:00