Commit Graph

1315 Commits

Author SHA1 Message Date
Huw Davies a63270f183 Unswap Page Up & Down and fix TBS_DOWNISLEFT.
NM_* notifications go via WM_NOTIFY not WN_?SCROLL.
Pull the notification window from the CreateStruct.
Send a TB_THUMBPOSITION at the end of a drag.
2003-11-18 19:39:40 +00:00
Rein Klazes b76e883344 The LVN_GETDISPINFO notify message should point to the same iSubItem
as in the call to LISTVIEW_GetItemT, valid or not. Fix a badly placed
brace.
2003-11-18 19:38:30 +00:00
Aric Stewart 89ba8760f3 We need to make sure that customdraw_fill is called even if
CDRF_NOTIFYITEMDRAW is not being used because we used the text and
background colors from that struct later.
2003-11-18 00:04:27 +00:00
Rein Klazes 7b6b9d6e93 Ignore invalid iSubItem in LISTVIEW_GetItemT(). 2003-11-17 20:01:49 +00:00
Huw Davies 83e9fd8513 Implemented LVS_EX_CHECKBOXES. 2003-11-13 20:50:25 +00:00
Dmitry Timoshkov d6872aff18 Avoid setting infoPtr->firstVisible to NULL in TREEVIEW_Sort. 2003-11-13 20:49:00 +00:00
Huw Davies 50c9ff030f Fix some weird logic in ImageList_Write. 2003-11-12 22:41:44 +00:00
Huw Davies ac24a0a692 A multicolumn listview should get a customdraw notification for the
item as well as one for subitem 0.
2003-11-12 22:41:27 +00:00
Huw Davies 818c5861c4 Add support for LVS_EX_SUBITEMIMAGES. 2003-11-11 00:26:15 +00:00
Robert Shearman fc58ef8119 Added chevron support. 2003-11-09 00:28:24 +00:00
Huw Davies a7c4fa8119 ReleaseCapture on lbuttondown if the cursor is outside an item, just
like the native one does.
2003-11-09 00:27:20 +00:00
Huw Davies 4de17c3724 LISTVIEW_GetSubItemRect should succeed if subitem == 0 whatever mode
the listview is in.
2003-11-05 00:35:57 +00:00
Rein Klazes 56121b7161 Correctly place a toolbar with CCS_BOTTOM style at the bottom, not the
top.
2003-11-05 00:35:28 +00:00
Huw Davies e63e39f2c5 PropSheetPageProc callback should always have hwnd = 0. 2003-11-04 04:23:00 +00:00
Alexandre Julliard 55cb8177b5 Authors: Ulrich Czekalla <ulrich@codeweavers.com>, Huw Davies <huw@codeweavers.com>
Added drag and drop support to listview.
2003-11-04 04:22:37 +00:00
Huw Davies 3ce815e7f3 Fix a fixme. 2003-11-04 04:22:07 +00:00
Huw Davies f94159cdb2 Don't get confused if PSN_SETACTIVE returns a positive number that
isn't a resource id.
2003-11-03 22:15:39 +00:00
Huw Davies b37adfb4b5 Make the listview send its notifications to the parent window passed
to it in CREATESTRUCT.  Based on a treeview patch by Igor Grahek.
2003-11-03 22:15:22 +00:00
Robert Shearman 90f3057b41 - Use the style returned in custom draw structure to draw the button,
as apps may modify the style this way.
- Disabled buttons can become hot.
- Retrieve image list for drawing after getting image list ID (in
  I_IMAGECALLBACK case).
2003-10-31 00:08:39 +00:00
Vitaliy Margolen 785bae8aae - Fix tab size for TCS_OWNERDRAWFIXED style.
- Correct size recalculation after setting tab width.
- Fix button sizes to match native.
- Center both vertically and horizontally tab text & icon.
- Use correct left/center alignment flags.
2003-10-31 00:06:42 +00:00
Francois Gouget f405629e8e Weekly spelling fixes. 2003-10-28 21:45:30 +00:00
Hans Leidekker a2977cf5b8 Added Dutch translations. 2003-10-27 22:04:36 +00:00
Robert Shearman fad1e1108e Don't store band text if "" is passed into SetBandInfo. 2003-10-24 04:18:42 +00:00
Maxime Bellengé ed3847247e Fix TAB_DeleteItem and TAB_DeleteAllItems regressions introduced by
the last TAB_InvalidateTabArea changes.
Correct the indentation for these functions.
2003-10-21 23:44:03 +00:00
Mike McCormack 8a6ca5ad3f Don't use free'd pointer in status control - found by Valgrind. 2003-10-21 23:43:14 +00:00
Adam Gundy c2d90611f6 Only send TVN_ITEMEXPANDING for items marked as having children. 2003-10-15 21:01:54 +00:00
Maxime Bellengé 5b99b3df29 - Implemented HEADER_SetBitmapMargin and HEADER_GetBitmapMargin.
- Get rid of some magic numbers in HEADER_DrawItem.
- Fixed the drawing of images from imagelist when the
  HDF_BITMAP_ON_RIGHT flag is set.
2003-10-14 20:13:42 +00:00
Maxime Bellengé 8147ee1095 Only redraw the necessary area of the tab component and not the whole
component like windows does.
2003-10-14 20:12:05 +00:00
Vitaliy Margolen bd7bdbce3f Fix setting size of tab control. 2003-10-14 01:16:16 +00:00
Dimitrie O. Paun fbdfd910c1 Remove SYMBOLFILE and LDDLLFLAGS from Makefiles. 2003-10-11 01:09:15 +00:00
Daniel Marmier ee1eb63b31 Fixed warnings with gcc option "-Wwrite-strings". 2003-10-07 03:30:47 +00:00
Dimitrie O. Paun 54e6b0d938 Extract binary resources to files, to fit the standard. 2003-10-03 05:01:33 +00:00
Pavel Roskin 5b7f03cf9f Ignore window caption from PROPSHEETHEADER in wizards. Update window
caption when changing pages.
2003-10-02 04:26:53 +00:00
Dimitrie O. Paun 7de279a73a Rename COMCTL32_{Alloc,ReAlloc,Free} to {Alloc,ReAlloc,Free}. 2003-09-22 21:32:33 +00:00
Vincent Béron bf5f07a5b4 Yet another batch of French resources updates. 2003-09-22 21:16:56 +00:00
Maxime Bellengé e5cd5a778a When an item is activated, we should send a NMITEMACTIVATE struct and
not a NMHDR one.
2003-09-22 19:27:33 +00:00
Alexandre Julliard 10aacbf3ef Renamed the COMCTL32_* functions to use the exported name. 2003-09-17 22:42:04 +00:00
Alexandre Julliard f5cb3dde17 Moved undocumented functions out of the exported commctrl.h. 2003-09-17 20:15:21 +00:00
Alexandre Julliard 1084a8ba93 Moved out of windef.h a few definitions that don't belong there
(reported by Filip Navara).
2003-09-17 04:31:27 +00:00
Alexandre Julliard 9d61596624 SLOWORD and SHIWORD do not exist on Win32 (reported by Filip Navara). 2003-09-17 04:28:28 +00:00
Filip Navara 2773106058 Fixed definitions of TTTOOLINFOA/W_V1_SIZE and
REBARBANDINFOA/W_V3_SIZE.
2003-09-16 01:17:25 +00:00
Robert Shearman d973bfb1c1 - Make sure dropdown arrow is always centered.
- Add support for the TBNRF_HIDEHELP customization flag, but emit a
  FIXME when it isn't present.
2003-09-12 00:21:57 +00:00
Robert Shearman 5dbf835b43 Add proper names to ordinal-only functions. 2003-09-11 01:04:24 +00:00
György 'Nog' Jeney 80428c4c9d Fix invalid C constructs (spotted by Marcus Meissner). 2003-09-11 01:03:27 +00:00
Alexandre Julliard cf52644a1c Removed the A/W constants for builtin cursors, icons and resource
types since they don't exist on Windows, and added typecasts
everywhere instead.
2003-09-10 03:56:47 +00:00
Francois Gouget ae50013017 Fix the case of product and company names. 2003-09-08 19:38:45 +00:00
Alexandre Julliard e37c6e18d0 Fixed header dependencies to be fully compatible with the Windows
headers (with help from Dimitrie O. Paun).
2003-09-05 23:08:26 +00:00
Dimitrie O. Paun 6d0019fb0e Adjust selection ranges before we insert the item so we don't mix the
new selection with the existing ones (reported by Eric Pouech).
2003-09-04 19:38:44 +00:00
Stefan Leichter c7a539d8e1 Updated minor version number. 2003-09-04 00:04:16 +00:00
Kevin Groeneveld 3219ae74fb Change default range of up-down control to match range used in
window.
2003-09-02 23:05:21 +00:00
Maxime Bellengé bcd1222650 Implemented TAB_SetMinTabWidth and TAB_HighlightItem. 2003-09-02 00:56:43 +00:00
Dimitrie O. Paun dad477ce3f If we don't send custom draw messages for subitems, inherit the color
& text attributes of the main item.
2003-09-01 23:55:33 +00:00
Rok Mandeljc d4c1ebabdb Minor updates of Slovenian translations. 2003-08-29 22:21:43 +00:00
Mike Hearn b79fc16577 Avoid division by zero when the imagelist is created with a width of
zero (ie no images).
2003-08-29 22:10:25 +00:00
Duane Clark 78cd28793a Button width should be the larger of text width/bitmap width. 2003-08-27 23:11:35 +00:00
Dimitrie O. Paun 31d4a7c47f Always setup the selection colour, not just in custom draw. 2003-08-25 23:44:51 +00:00
Dimitrie O. Paun 2fb93f1b85 Fix the hit test for full row select in REPORT mode (found, debugged,
and tested by Eric Pouech).
2003-08-25 00:53:11 +00:00
Maxime Bellengé cb1c112dd6 Fix the creation of treeview with checkboxes. 2003-08-23 23:18:48 +00:00
José Manuel Ferrer Ortiz 5069edc2de More Spanish translations. 2003-08-23 23:04:49 +00:00
Filip Navara 1ccaaa1a82 Fixed prototypes of CreateStatusWindowA/W, ImageList_Copy,
ImageList_EndDrag, ImageList_SetImageCount.
2003-08-22 23:51:15 +00:00
Maxime Bellengé 3db30e376c Fix unreachable TVHT_ONITEMSTATEICON in TREEVIEW_LButtonDown. 2003-08-19 00:57:08 +00:00
Maxime Bellengé fb39442d7f Fix things broken by the last TREEVIEW_UpdateDispInfo patch. 2003-08-18 19:46:31 +00:00
Maxime Bellengé 305fda2ef8 Fix for TREEVIEW_UpdateDispInfo to test with the correct callbackMask. 2003-08-13 19:37:12 +00:00
Dmitry Timoshkov 4d1d5fd353 Accept SIZE_MAXIMIZED as one of statuses of MDI windows. 2003-08-11 18:42:47 +00:00
Duane Clark 0d5aae1a0d Oops, back to hard coding initial thumb size until we figure out how
it really should work.
Fix the channel size/selection range for the TBS_ENABLESELRANGE
style.
One pixel tweaks in several spots.
2003-08-06 22:05:11 +00:00
Stephan BEUZE 767070203d - Avoid division by zero in TRACKBAR_GetTicPos
- Manage negative range TRACKBAR_DrawOneTic
2003-08-05 18:25:26 +00:00
Duane Clark 9ebf12c36d The initial size of the thumb depends on SM_CYCAPTION.
Correctly draw the thumb as in Windows.
The channel/thumb position also depends on TBS_NOTICKS.
The first and last tic marks should be inset from the channel length
by half the thumb width.
When TBS_BOTH style set, make sure to draw both sets of tics.
2003-08-02 00:44:00 +00:00
Stefan Haller 43858e4d0d Ignoring LISTVIEW_ScrollColumns() request if no columns in list. 2003-07-24 00:03:13 +00:00
Martin Fuchs bb40b30640 Send TVN_ITEMEXPANDING when the user tries to expand a tree item
_before_ checking for child items.
2003-07-21 22:04:42 +00:00
Mike McCormack ec0d425278 Set defaults for the Next/Prev button. 2003-07-21 20:01:59 +00:00
Francois Gouget 56aaea2f43 Spelling fixes. 2003-07-09 02:52:57 +00:00
Mike McCormack fc86392af8 Preserve A/W when creating propsheet dialogs. 2003-07-09 02:49:52 +00:00
Dmitry Timoshkov 4e1ef0c114 For all DLLs with defined DllMain and which do not require
DLL_THREAD_ATTACH/DLL_THREAD_DETACH notifications, call
DisableThreadLibraryCalls() in order to slightly improve performance
on thread creation/exiting.
2003-06-30 20:53:48 +00:00
Marcelo Duarte de08661413 - Localization to Portuguese of Brazil
- Revision and addition of missing resources
- Minor typo fix and codepage fix in programs/winefile resource.
2003-06-30 20:22:35 +00:00
Francois Gouget 9591836ffb 'sizeof type' is best avoided as it won't always compile (e.g. 'int
main() {return sizeof int;}'). Use 'sizeof(type)' instead.
2003-06-18 19:45:22 +00:00
Francois Gouget c5f775a9c7 Typos/spelling fixes. 2003-06-18 03:30:39 +00:00
Mike Hearn d2b8e39b5c - Unbreak vertical trackbars
- Make it more closely resemble the native control
- Add focus rectangle
- Misc fixes and cleanups
2003-06-16 19:39:27 +00:00
Robert Shearman 7614f27f3b - Make button text centre correctly when dropdown arrow is present
- Centre dropdown arrow
2003-06-13 16:30:24 +00:00
Dimitrie O. Paun 36d0e2ba63 Align the text vertically in single line labels (spotted by BiGgUn). 2003-06-06 18:13:47 +00:00
Dimitrie O. Paun bc9de0500e Remove bFirstPain funky optimization, it is causing too much grief. 2003-06-04 20:19:11 +00:00
Maxime Bellengé 66855d4a22 Fix listview custom draw notification for CDDS_ITEMPREPAINT and
CDDS_SUBITEMPREPAINT messages.
2003-05-22 03:37:10 +00:00
Robert Shearman f644c787ee Update ordering on insertion of an item. 2003-05-22 03:34:54 +00:00
Dimitrie O. Paun bb993e0127 Inserting column zero should not modify the main item (spotted by
Robert Shearman).
2003-05-21 18:25:10 +00:00
Uwe Bonnes 2c4fd4289c New comctl32 test directory and test case for DPA_Search. 2003-05-15 23:58:48 +00:00
Uwe Bonnes 29ef801b40 DPA_Search: Handle DPAS_INSERTBEFORE on empty list. 2003-05-15 23:55:12 +00:00
Vitaliy Margolen d8d12a0bca Revert change for resizing buttons. 2003-05-13 23:38:01 +00:00
Ulrich Czekalla 535e0f6238 Fixed bad non-client calculation. 2003-05-13 22:05:50 +00:00
Huw Davies 89e2766fc7 Fix DTM_SETSYSTEMTIME.
Make the show/hide button actually do something.
Add support for the 'yyyy' format.
2003-05-13 22:04:40 +00:00
Vitaliy Margolen 32eb1c7354 Get rid of direct ImageList access hacks. 2003-05-13 03:36:54 +00:00
Vitaliy Margolen e43edbd557 Rearrange members of HIMAGELIST to match Windows.
Reuse image and mask DCs.
2003-05-13 03:36:27 +00:00
Robert Shearman c00aa9985a Fix use of freed memory. 2003-05-13 00:30:10 +00:00
Huw Davies 130e21795c Fixed a possible memory corruption.
Fixed a memory leak.
2003-05-12 03:19:35 +00:00
Stephan Beuze 442dd75420 Implemented Get/SetToolTips functions. 2003-05-11 03:44:13 +00:00
Alexandre Julliard dd74d9d889 Ordinals 410-413 are the window subclassing functions. 2003-05-11 03:40:59 +00:00
Dimitrie O. Paun c6e988eaa0 Fix custom draw for item 0. 2003-05-11 03:29:25 +00:00
Huw Davies 5594fcea74 Invalidate the window when the range is changed. 2003-05-11 02:38:05 +00:00
Igor Stepin 97b7bc1984 Added a lot of Russian translations. 2003-05-04 02:33:08 +00:00
Adam Gundy a982259e3e When items are inserted in a partially populated treeview, the first
visible item was not correctly updated.
The first visible item was sometimes used to calculate the location of
other items when it had been freed.
2003-05-02 20:15:36 +00:00
Adam Gundy 06d610ec9b Check the mask flags in the item structure to determine how much
memory to read/write.
2003-05-02 20:14:33 +00:00
Mike Hearn 266a2f297e Change return code comparison in AVI control (from patch by
stanleyg76@yahoo.com).
2003-04-30 23:59:46 +00:00
Maxime Bellengé 0485fc19b6 Fix bounding rectangle computation for an ownerdraw tab. 2003-04-30 00:50:26 +00:00
Dimitrie O. Paun dfdeaaf922 Generate custom draw notifications for ownerdraw listviews (based on a
patch by Maxime Bellengé).
Reorganize the custom draw code for better reuse.
2003-04-30 00:49:44 +00:00
Stephan BEUZE 8410e71fb5 Implemented message TCM_SETPADDING with the Dimitri's advice. 2003-04-27 20:34:30 +00:00
Maxime Bellengé dcaf137736 Fix the computation of the trackbar's size. 2003-04-27 00:31:06 +00:00
Maxime Bellengé 5b44c77fb4 Remove the sending of NM_TOOLTIPSCREATED which is non existent under
Windows during the creation of the trackbar.
2003-04-26 02:07:43 +00:00
Vitaliy Margolen 4bddbe8b19 Fix buffer overflow in datetime. 2003-04-02 23:25:01 +00:00
Adam Gundy 9e3772f699 Zero initialize the reserved bytes in the toolbar details returned by
TOOLBAR_GetButton().
2003-04-02 23:19:45 +00:00
Vitaliy Margolen 1420acef09 Fix ImageList_Read - the root cause of ugly toolbar icons. 2003-04-02 23:18:17 +00:00
Mike Hearn d0300d92e3 TreeView should not send two click notifications when bTrack is true. 2003-03-27 00:00:42 +00:00
Mike Hearn b27587dd0a TREEVIEW_GetItemA should ignore stateMask. 2003-03-26 23:35:50 +00:00
Mike Hearn 044a353161 Correct the check for changed treeview items, so item sets repaint
properly.
2003-03-26 01:22:10 +00:00
Dimitrie O. Paun a50bd8117f Send LVN_ODCACHEHINT notification for LVS_OWNERDATA style in all modes
(based on a patch by Vitaliy Margolen).
2003-03-24 19:28:50 +00:00
Alexandre Julliard 114a31a2a8 Take advantage of new winebuild syntax to remove redundant function
names in spec files.
2003-03-20 03:53:12 +00:00
Jon Griffiths cd4234aa49 Documentation updates. 2003-03-18 18:35:48 +00:00
Mike Hearn c7b1874b54 Fix the tab height so the labels don't clip, and restore the offset
constant to what it was before.
2003-03-17 04:43:26 +00:00
Mike Hearn 22813d4634 Fix a typo. 2003-03-17 04:43:05 +00:00
Vitaliy Margolen eded087e4e Changes for Icon and SmallIcon modes:
- fix typo causing wrong scroll boundaries
 - reverse mouse wheel scroll directions
 - fix navigation with keyboard when auto arranged
2003-03-15 00:05:46 +00:00
Dimitrie O. Paun d39af613a3 Spacing information is signed (debugged and fixed by Vitaliy
Margolen).
Decode spacing information in the window procedure.
Some spelling fixes.
2003-03-14 22:58:22 +00:00
Tony Lambregts 7ce3a5ad63 Replace DPRINTF with TRACE. 2003-03-14 04:11:17 +00:00
Mike Hearn c6914b202a - Reduced tab offset constant slightly to avoid clipping the label.
- Prevent label overdraw of updown control by reducing the width of
  the invalidated region.
2003-03-12 20:14:12 +00:00
Mike Hearn 6b2d22a0f6 It's not just height that can be set to the default by passing zero to
TCM_SETITEMSIZE, but also width.
2003-03-10 19:04:13 +00:00
Adam Gundy a4944ff123 TOOLBAR_AddBitmap() and TOOLBAR_ReplaceBitmap() are not supposed to
modify the bitmap - we call ImageList_AddMasked() which turns all
masked pixels black. Fixed by making a copy of the bitmap to give to
ImageList_AddMasked().
2003-03-07 23:02:46 +00:00
Adam Gundy 64eff97f51 When shifting the list's indices, we must not send notify messages if
we have to refocus. Item modification handlers are not supposed to be
called here.
2003-03-07 20:35:30 +00:00
Adam Gundy 1af319d9e2 PROPSHEET_CreateDialog() is documented to return -1 on failure, and
the dialog handle on success.
2003-03-07 20:29:58 +00:00
Tony Lambregts e295d3996e Janitorial. Get rid of W->A call. 2003-03-06 22:43:43 +00:00
Adam Gundy 292d8429ab TREEVIEW_UpdateScrollBars() now copes with an empty tree. 2003-03-06 22:41:59 +00:00
Vitaliy Margolen e6af4ec6bd Fix invisible tabs in TabControls with fixed tab width. 2003-03-04 04:34:03 +00:00
Tim Segall efa2b0c159 Accept either TVI_ROOT or NULL for the parent to imply sort the entire
tree.
2003-02-25 03:59:12 +00:00
Michael Stefaniuc 745a78f490 Remove some unreachable code. 2003-02-24 20:48:45 +00:00
Eric Pouech a89063e3dc Added handling for PSNRET_INVALID in PSN_APPLY notification. 2003-02-24 20:40:45 +00:00
Duane Clark 65a9f4daac Support the undocumented behavior of deleting column zero. 2003-02-14 23:31:45 +00:00
Dimitrie O. Paun 00ccf38987 Correctly remember the first paint event, but delay item metrics
calculation until we actually have some items.
2003-02-14 19:24:11 +00:00
Gerald Pfeifer 820157b836 Avoid warnings caused by assert(...). 2003-02-12 21:28:04 +00:00
Dimitrie O. Paun 15e0657f6b Compute matrix of first paint when we actually have some items
(problem first spotted & debugged by Duane Clark).
2003-02-11 22:17:31 +00:00
Alexandre Julliard 43690e9e47 Removed no longer needed inclusion of heap.h. 2003-01-24 00:54:58 +00:00
Francois Gouget 9b0b1e078a Remove (POINTER)NULL casts. 2003-01-14 23:43:41 +00:00
Dan Kegel 0fd521fee3 Change RECT to use LONG to match win32 standard headers and fix format
strings to use %ld for RECT elements.
2003-01-08 21:09:25 +00:00
Dimitrie O. Paun 297f3d898d Define NONAMELESS{STRUCT,UNION} explicitly in the files that need them. 2003-01-07 20:36:20 +00:00
Alexandre Julliard b4a4c05aed Removed a few more #ifdef __WINE__. 2003-01-04 00:19:17 +00:00
Dimitrie O. Paun cef5961d2b Eliminate lots of __WINE__ conditionals from the headers. 2003-01-03 19:12:55 +00:00
Lionel Ulmer 5e36ae56b2 Check the value of the pfnCallback in addition to the callback bit. 2003-01-03 03:06:42 +00:00
Chris Morgan fa93b446d0 Listview should scroll by at least one column, fixes bug where item
being wider than listview prevents any scrolling from occuring.  Added
printing of the scroll code text during tracing of scroll functions.
2003-01-03 03:04:22 +00:00
Rein Klazes 0e162e4643 Let ANIMATE_OpenA return FALSE (= failure) upon a request to close a
previously opened AVI clip when there isn't one.
2003-01-02 17:54:23 +00:00
Duane Clark 521aa7412d Validate imagelists with christmas magic. 2003-01-02 17:51:13 +00:00
Duane Clark 3d2e380244 Report mode padding tweaks.
Fix to LISTVIEW_GetSubItemRect.
2002-12-23 02:02:06 +00:00
Rolf Kalbermatter 6c79930413 Add config.h/port.h to allow compilation/linking in MSVC.
Fix some unsigned/signed warnings.
2002-12-16 22:43:58 +00:00
Robert Shearman 096becedd8 Implemented StrStrIW. 2002-12-13 23:25:59 +00:00
Rolf Kalbermatter 4f7ec6335c Typo found by compiling with standard MSVC warning level. 2002-12-13 00:35:44 +00:00
Dimitrie O. Paun 9c50730354 Get rid of generic notification support in comctrl32. The MS docs were
misleading in that all controls send these notifications. They don't.
2002-12-10 19:07:59 +00:00
Dimitrie O. Paun 5720007370 - Plug a bunch of memory leaks.
- Make ranges_destroy behave more like free().
- Fix messed up indentation from tabs set to 4 chars.
- Updated the documentation.
2002-12-10 19:07:27 +00:00