Commit Graph

423 Commits

Author SHA1 Message Date
Nikolay Sivov 2e8dfbb1ad comctl32/toolbar: Fix a crash when tracing special button string identifier.
Based on patch by Mark Jansen <mark.jansen@reactos.org>.

Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-02-05 23:19:25 +01:00
Thomas Faber 4c57232962 comctl32: Unset the toolbar's hot item when deleting a button.
Signed-off-by: Thomas Faber <thomas.faber@reactos.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-01-19 16:40:55 +01:00
Nikolay Sivov d93ae6ff34 comctl32/toolbar: Support undocumented IDs for standard bitmap lists.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-31 10:53:54 +02:00
Nikolay Sivov ece34a1319 comctl32/toolbar: Don't add NULL imagelist entries.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-31 10:53:52 +02:00
Nikolay Sivov e558858d0f comctl32: Change some overly exciting tracing messages.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-30 11:14:55 +02:00
Eric Kohl b7cc44099a comctl32: Update the tooltip rectangle when a tool button is hidden.
Signed-off-by: Eric Kohl <eric.kohl@t-online.de>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-21 13:57:36 +01:00
Nikolay Sivov 970029bb9b comctl32/toolbar: Fix TB_SETDRAWTEXTFLAGS handler.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-01-26 10:36:17 +01:00
Nikolay Sivov 26067cc0b9 comctl32/toolbar: Protect from NULL pointer access in TB_GETBUTTONINFOW handler.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-01-11 16:04:23 +01:00
Michael Stefaniuc 8258d900ca comctl32: Use InflateRect() too when expanding in just one axis.
Signed-off-by: Michael Stefaniuc <mstefani@redhat.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-09 15:42:47 +09:00
Michael Stefaniuc 65a2e59a78 comctl32: Avoid using CopyRect() on RECT structs.
Signed-off-by: Michael Stefaniuc <mstefani@redhat.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-06-24 21:10:32 +09:00
Michael Stefaniuc 903ea19122 comctl32: Use SetRect() instead of open coding it.
Signed-off-by: Michael Stefaniuc <mstefani@redhat.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-04-29 23:23:36 +09:00
Christopher Thielen ff063d9e25 comctl32: Ensure that toolbar respond only to changes in WM_CAPTURECHANGED handler.
Signed-off-by: Christopher Thielen <cthielen@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-02-02 22:21:31 +09:00
Jacek Caban 67819d6ee9 comctl32: Don't use comparisons to FALSE.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-11-10 11:53:20 +09:00
Nikolay Sivov 83a652a9d4 include: Add a couple of documented Toolbar messages definitions.
Thanks to Alan Feldman for pointing this out.

Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-10-19 12:20:56 +09:00
Alex Henrie c565145b0e comctl32: Remove redundant if (button) statements.
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Piotr Caban <piotr@codeweavers.com>
2015-10-07 21:28:50 +09:00
Huw Davies 2a71d13b6b comctl32: Implement the legacy notifications during restore. 2015-07-02 16:54:01 +09:00
Huw Davies 6c95445559 comctl32: Set the default separator width when notifying a -ve cmd id. 2015-07-02 16:53:58 +09:00
Huw Davies eddfefa54f comctl32: Reset the string and lparam fields between notifications. 2015-07-01 19:18:27 +09:00
Huw Davies 96a6184c30 comctl32: All negative entries in the toolbar save state are special cases. 2015-07-01 19:18:27 +09:00
Huw Davies 77ed3733af comctl32: The number of buttons is set by the first TBN_RESTORE notification. 2015-07-01 19:18:27 +09:00
Huw Davies 063c7866f5 comctl32: Implement toolbar saving. 2015-07-01 19:18:26 +09:00
Huw Davies 199f51ff78 comctl32: Don't leak button text. 2015-07-01 19:18:26 +09:00
Huw Davies 01cd45cce1 comctl32: Add a helper to free button text. 2015-07-01 19:18:25 +09:00
Huw Davies a29b6958e1 comctl32: Add helpers to set the button text. 2015-07-01 19:18:25 +09:00
Nikolay Sivov b7969dfd94 comctl32/toolbar: Remove always true condition (Coverity). 2015-06-03 19:29:49 +09:00
Huw Davies 5c4dc9fc56 comctl32: Fix a typo in the TB_SAVERESTOREA handler. 2015-05-20 22:10:07 +09:00
Huw Davies 0634f3b409 comctl32: If necessary add the width of a dropdown arrow while wrapping.
This also fixes the layout code for the BTNS_WHOLEDROPDOWN case.
2015-05-19 22:57:36 +09:00
Huw Davies 797f42699e comctl32: Wrap the buttons inside the toolbar's client rect.
The toolbar need not be the same width as the parent.
2015-05-19 22:57:27 +09:00
Huw Davies 0bcadfa88f comctl32: Layout the toolbar after a potential resize. 2015-05-19 22:57:22 +09:00
Huw Davies 9d218048a6 comctl32: Don't store the width in the toolbar info structure.
It's only set and used by a single function.
2015-05-19 22:57:16 +09:00
Huw Davies eb8df37a69 comctl32: Remove button wrap states when TBSTYLE_WRAPABLE is cleared. 2015-04-30 16:17:59 +09:00
Huw Davies abd673bde9 comctl32: A change in TBSTYLE_WRAPABLE should produce a recalc. 2015-04-28 20:23:59 +09:00
Huw Davies e82b9dc32e comctl32: Move the style change code to the TB_SETSTYLE handler. 2015-04-28 20:23:59 +09:00
Huw Davies 60e305d983 comctl32: Invalidate the toolbar if the button size is changed. 2015-04-20 14:37:00 +09:00
Huw Davies 5b7b911f06 comctl32: TBSTYLE_EX_MIXEDBUTTONS doesn't mean buttons should be auto-sized. 2015-04-20 14:36:55 +09:00
Michael Stefaniuc 47fa711bbc comctl32: Remove a stray unused GetFocus() statement (PVS-Studio). 2014-12-09 22:16:44 +01:00
Huw Davies 6af0d44166 comctl32: The RECT in the custom draw structure should be the entire item's size. This includes any separated dropdown arrow. 2014-07-08 17:02:04 +02:00
Huw Davies d130ba09fa comctl32: Don't use the RECT from the custom draw structure when referring to the button alone. 2014-07-08 17:02:02 +02:00
David Quintana 5b0c288977 comctl32: Fix horizontal separators in vertical toolbars. 2014-03-14 19:06:12 +01:00
Christoph von Wittich 37e0a1a5d4 comctl32: Rename TBSTYLE_EX_UNDOC1 to TBSTYLE_EX_VERTICAL. 2014-02-24 15:00:40 -06:00
Frédéric Delanoy 0f2bed51bd Assorted spelling fixes. 2014-02-10 15:47:29 +01:00
Frédéric Delanoy 5ba7f79bad Assorted spelling fixes. 2013-12-03 19:41:53 +01:00
Frédéric Delanoy 5dfe1b0cfe comctl32: Use BOOL type where appropriate. 2013-11-11 13:27:28 +01:00
Alexandre Julliard 7624da76a8 comctl32: Remove comments about native behavior, that's not a valid source of information. 2013-05-29 15:43:27 +02:00
Andrew Talbot 85ebbadcb0 comctl32: Indentation fix. 2012-12-17 11:47:39 +01:00
Michael Stefaniuc 175eaf1074 comctl32: Avoid TRUE:FALSE conditional expressions. 2012-08-13 17:29:01 +02:00
Michael Stefaniuc 11d35ef8e7 comctl32: Get rid of two macros. 2012-08-13 17:28:53 +02:00
Dmitry Timoshkov 92a81c215f comctl32: Use WARN instead of ERR if a toolbar index is out of range. 2012-05-24 19:54:20 +02:00
Piotr Caban 99ff5683f3 comctl32: Don't make separator on first position hot. 2012-05-17 17:44:23 +02:00
Piotr Caban 2d75a2425e comctl32: Return if point is over a button in TOOLBAR_InternalHitTest. 2012-05-17 17:44:15 +02:00