Commit Graph

163 Commits

Author SHA1 Message Date
Aric Stewart acb308af67 If we have no dropdown height give ourselves a minimum height of 5
items or max items (whichever is less).
2002-08-28 00:53:23 +00:00
Alexandre Julliard 0393d43c8e Fixed WM_GETTEXT handling to avoid strncpy and return correct lengths. 2002-08-28 00:40:17 +00:00
Carl Sopchak e833248d58 Return empty string on error in WM_GETTEXT. 2002-07-19 03:13:10 +00:00
Uwe Bonnes 72d827010c CBUpdateEdit: LB_GETTEXTLEN returns LB_ERR on error, not 0. 2002-07-10 23:11:28 +00:00
Alexandre Julliard 741325b86a Make sure edit and listbox controls are of same ASCII/Unicode style as
the combo box. Fixed a few MBCS issues with WM_GETTEXTLENGTH handling.
2002-06-13 19:20:43 +00:00
Vincent Béron 9a62491660 Removed trailing whitespace. 2002-05-31 23:06:46 +00:00
Alexandre Julliard 4344c368cb Got rid of GetSysColorPen. 2002-05-20 18:15:28 +00:00
Alexandre Julliard 0799c1a780 Added LGPL standard comment, and copyright notices where necessary.
Global replacement of debugtools.h by wine/debug.h.
2002-03-09 23:29:33 +00:00
Rein Klazes 93ece68077 In CBPaintText use the text size as returned by LB_GETTEXT. The size
returned by LB_GETTEXTLEN may be too large.
2002-01-15 20:27:12 +00:00
Francois Gouget 070e749cfb Don't prefix %p with 0x.
Various English fixes.
2001-11-06 21:01:32 +00:00
Alexandre Julliard d23a82bc86 Made all 16<->32 HWND conversions use explicit functions instead of
implicit type casts.
Moved a lot of 16-bit functions to the new wnd16.c file.
Changed DIALOGINFO structure handling to support 32-bit handles.
2001-09-19 20:37:04 +00:00
Alexandre Julliard f44bbb8d10 Make sure that HWND comparisons are always done with full 32-bit
handles.
2001-09-14 00:24:39 +00:00
Guy L. Albertelli db9b54925d Enhance SPY_GetMsgName to translate common control messages. 2001-09-07 18:38:57 +00:00
Alexandre Julliard de42428f23 Removed a number of direct accesses to the WND structure, replacing
them by API calls.
2001-08-10 22:51:42 +00:00
Alexandre Julliard 1922c72b8a Removed unnecessary inclusion of heap.h. 2001-07-25 00:43:29 +00:00
Jukka Heinonen 186a79cb92 WNDPROC handlers now check whether HWND argument is valid. 2001-07-24 01:16:16 +00:00
Susan Farley b6866d7f20 Disable the edit box when created with WS_DISABLED. 2001-05-31 21:39:21 +00:00
Mike McCormack 75194d2853 Only draw the padding area of the combo box, don't erase the combo
selection text.
2001-05-09 17:13:41 +00:00
Marcus Meissner f05618bd00 Do not HeapFree() memory not allocated by us in COMBO_GetText.
Convert return value from LB_GETTEXT into COMBO_GetText.
2001-05-02 01:08:59 +00:00
Mike McCormack ed90b185f2 Draw the padding area of a combo box. 2001-04-30 18:17:46 +00:00
Dmitry Timoshkov d62c3f16ac Remove redundant sending of WM_DRAWITEM message to ownerdrawn
combobox.
2001-04-17 17:29:31 +00:00
Dmitry Timoshkov 6df245dd68 Really do not roll up if selection is being tracked by arrow keys in
the dropdown listbox.
2001-04-09 18:30:25 +00:00
Guy L. Albertelli 627aa4d772 Native version seems to always re-draw the selected text at the end of
a rollup.
2001-03-20 01:51:58 +00:00
Francois Gouget 3d0589ae7d Fixed spelling/typos in comments. 2001-03-10 19:15:49 +00:00
Guy L. Albertelli 79413eda91 - Restructure PaintText code to remove FillRect from owner-drawn path.
- Change SetFocus to indicate focus set only after Notify is sent to owner.
- Get more info in a trace.
2001-02-20 01:53:12 +00:00
James Abbatiello 8ac1acbb1a Ownerdrawn combo boxes should use ODS_COMBOBOXEDIT in the itemState. 2001-02-12 01:17:16 +00:00
Guy L. Albertelli 4782b0e57f - When painting the text, if the control is OWNERDRAWN the issue the
WM_DRAWITEM message.
- Set the focused status at the end of the end of the Setfocus routine.
- Flip the order of updating the list box and issuing the WM_NOTIFY
  for CBN_EDITUPDATE to match native.
2001-01-26 20:59:51 +00:00
Francois Gouget 05fc3cdf9a Typo fixes in comments. 2001-01-22 02:22:26 +00:00
Alexandre Julliard a41b2cfdd0 Moved tweak support to USER dll. Removed tweak.h and cache.h. 2001-01-15 20:12:55 +00:00
Dmitry Timoshkov 376beadaaa Various combobox fixes. 2001-01-11 20:17:07 +00:00
Dmitry Timoshkov 7462099847 Added unicode window proc for the listbox control.
Replaced all ansi calls by their unicode equivalents.
Removed use of the custom local heap.
2001-01-09 21:51:04 +00:00
Ulrich Czekalla b3da1ac0cd Ensure there is an edit control when we reset contents. 2001-01-09 20:49:53 +00:00
Dmitry Timoshkov 4866ac0859 Combobox should clear its current selection on response to
CB_SETCURSEL(-1) message.
2001-01-07 21:43:49 +00:00
Dmitry Timoshkov f5f9f2cc51 Added unicode window proc for combobox control.
Replaced ansi calls by their unicode equivalents.
2001-01-05 22:21:18 +00:00
Alexandre Julliard 982a223f36 Replaced PTR_SEG_TO_LIN macro by exported MapSL function.
Fixed a few ptr/segptr mismatches.
Moved CONV_RECT/POINT macros to wingdi16.h.
2000-12-13 20:20:09 +00:00
Alexandre Julliard bf67259a41 Use the DRIVE_* API constants instead of the DRIVETYPE enum.
Changed DRIVE_CANNOTDETERMINE and DRIVE_DOESNOTEXIST to use the
correct names.
Cleaned up a few dependencies on internal drive.c functions.
2000-12-12 00:44:42 +00:00
Alexandre Julliard 91222da881 Moved most builtin controls structures into their respective C file.
Created new controls.h file private to user32.dll and moved remaining
builtin controls definitions there.
2000-12-10 23:01:33 +00:00
Louis Philippe Gagnon cef7c7af61 Update internal controls on WM_WINDOWPOSCHANGED. 2000-12-06 03:21:57 +00:00
Aric Stewart 6213ab3a89 Fixed a problem where the string in a combo box flickers if you
rapidly reset the content and then replace the content.
2000-12-05 21:12:05 +00:00
Andreas Mohr 94a6832b04 WM_SETTEXT should return TRUE on success. 2000-11-29 00:02:46 +00:00
Dimitrie O. Paun 529da54394 Require {DECLARE,DEFAULT}_DEBUG_CHANNEL statements to end in a ; 2000-11-27 23:54:25 +00:00
Andreas Mohr 45c9fd892f - set the item height not only for the listbox, but also for the text field
- center text vertically
- beautify comments
2000-10-28 00:29:58 +00:00
Susan Farley a4251bbe4c Do not block CBN_EDITCHANGE for WM_PASTE or WM_CUT with the
NOEDITNOTIFY flag, as these msgs can come directly from the app to the
combo wndproc.
2000-10-24 01:38:49 +00:00
Susan Farley 597cb552ce Update the edit box before rolling up the listbox, so the
selection isn't lost.
2000-08-14 17:18:49 +00:00
Alexandre Julliard b0efe28f6c Removed a few dependencies on GDI internals from USER dll. 2000-08-04 04:18:04 +00:00
Susan Farley 7251640113 Don't clear selection when initial entry is not in the list. 2000-07-15 21:27:32 +00:00
Gerard Patel d292234835 Set the minimum dropped height to the combo list height if any in
CBDropDown.
2000-06-25 12:47:59 +00:00
Gerard Patel c9e6031dca CB_SETCURSEL should not generate another listbox event after updating
the edit box.
2000-06-18 17:20:37 +00:00
Serge Ivanov 9926d33450 - ComboLBox is always created as child of ComboBox. If ComboBox has style
other than CBS_SIMPLE, parent of listbox is set to desktop.
- In CBDropDown. ComboBox uses only first item to calculate height of
  dropped listbox. Also if listbox is empty its height is unmodified
  (previously it was set to 0).
- Added correct handling of WM_GETDLGCODE and WM_(SYS)KEYDOWN messages.
- General clean-up. Message order is now more precise (at least
  notifications to client); listbox - combobox interaction has slight
  differences comparing to Windows.
2000-06-07 03:48:02 +00:00
David Grant 8a92213111 - Creating combobox with CBS_SIMPLE style shall set internal flag CBF_EDIT.
- Edit text must be selected only if CB is in focus.
- If CB has edit control we have to call CBUpdateEdit to update its
  contents. Invalidating textRect will not force updating of child
  edit control, obviously.
- We have to protect ourselves from changing selection in listbox when
  we receive listbox notification. So LBN_SELCHANGE -> CBUpdateEdit ->
  EN_CHANGE will not reselect item in the lisbox.
2000-05-30 17:48:33 +00:00