Commit Graph

234 Commits

Author SHA1 Message Date
Alistair Leslie-Hughes 839f468dce shell32: Correct if condition.
Spotted by Rafał Mikrut.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=49203
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-05-20 10:48:23 +02:00
Nikolay Sivov 539644ad63 shell32: Remove "stub" from traces.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-11-05 16:16:15 +01:00
Sven Baars 6796cd8ac4 shell32: Fix a memory leak (Valgrind).
Signed-off-by: Sven Baars <sven.wine@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-11-04 22:43:01 +01:00
Nikolay Sivov 612a194133 shell32: Use ARRAY_SIZE macro.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-19 12:35:12 +01:00
Nikolay Sivov e3b200bd8a shell32: Use global memory allocation helpers.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-02-22 14:16:33 +01:00
Andrew Eikum db1a3c617e shell32: Size ShellView column widths by font width.
Signed-off-by: Andrew Eikum <aeikum@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-11-10 16:41:28 +01:00
Nikolay Sivov 627630c262 shell32/shellview: Respond to special interface id CDefView.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-01 10:06:26 +02:00
Nikolay Sivov a528ddd745 shell32/shellview: Handle NULL folder pointer in SHCreateShellFolderViewEx().
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-01 10:06:21 +02:00
Nikolay Sivov 7a49da5070 shell32/shellview: Set provided callback in SHCreateShellFolderView().
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-01 10:06:18 +02:00
Nikolay Sivov 4478e61d16 shell32: Move SHCreateShellFolderView/SHCreateShellFolderViewEx and tests to corresponding files.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-01 10:05:54 +02:00
Nikolay Sivov 2cce196210 shell32/shellview: Set subitem callbacks for every column.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-01-26 10:36:56 +01:00
Nikolay Sivov a26d6e375e shell32/shellview: Get rid of intermediate pointer array when filling ListView.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-01-26 10:36:51 +01:00
Nikolay Sivov e49878289b shell32: Remove a couple more casts of object pointers.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-11-28 13:56:09 +01:00
Nikolay Sivov 5ad123f851 shell32: Use interface pointers instead of a pointer to implementation structure.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-11-23 22:36:41 +01:00
Andrey Gusev 954560f847 shell32: Use debugstr_guid() and debugstr_w() in TRACE() messages.
Signed-off-by: Andrey Gusev <andrey.goosev@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-22 21:34:50 +09:00
Thomas Faber e582495927 shell32: Use QueryInterface in FolderView_GetFolder.
test_IFolderView has a test that shows that the shell folder's reference
count before and after the call to IFolderView_GetFolder is the same.
However this is misleading because it is not a property of the
IFolderView_GetFolder method, but of the desktop shell folder object
that's used in the folder view. Windows <=2003 uses a cached object and
its AddRef/Release methods return constants.
2015-06-30 14:41:43 +09:00
Nikolay Sivov 7ce1813fed shell32: Added IDispatch support for IShellFolderViewDual3. 2015-05-08 18:33:41 +09:00
Nikolay Sivov ce87d64ab4 shell32: Implement Application property of IShellFolderViewDual. 2015-05-06 18:13:59 +09:00
Nikolay Sivov a6163247cd shell32: Implement GetSelectedCount() using IFolderView2::GetSelection(). 2015-05-05 10:16:37 +09:00
Nikolay Sivov be6e022f2d shell32: Forward SetRedraw to IFolderView2. 2015-05-05 10:16:33 +09:00
Nikolay Sivov 7e0e82bc9c shell32: Forward AutoArrange() to IFolderView2. 2015-05-05 10:16:29 +09:00
Nikolay Sivov a897adb67b shell32: Fix multiline trace message and some magic numbers. 2015-05-05 10:16:25 +09:00
Nikolay Sivov 23d546157a shell32: Better handle creation/destruction of shellview window. 2015-05-04 15:08:43 +09:00
Nikolay Sivov 06b60cc4d0 shell32: Forward to CreateViewWindow3(). 2015-05-01 15:16:19 +09:00
Nikolay Sivov e91dac5153 shell32: Update to IFolderView2. 2015-05-01 15:15:56 +09:00
Nikolay Sivov 5d288771c9 shell32: Update to IShellView3. 2015-04-30 16:20:58 +09:00
Nikolay Sivov dd9813b5f7 shell32: Added a stub implementation of IShellFolderViewDual3. 2015-04-30 16:20:35 +09:00
Francois Gouget 351d907bbd shell32: Remove unneeded NONAMELESSXXX directives. 2015-03-20 17:50:06 +09:00
André Hentschel 81711c7558 shell32: Don't call Drop without valid target. 2015-02-24 23:01:42 +09:00
Alexandre Julliard e330a128d5 shell32: Use Shell_GetImageLists to retrieve image lists instead of using a global variable. 2014-01-02 11:56:11 +01:00
Alexandre Julliard d80ca173af shell32: Delay common controls initialization until needed. 2013-10-17 20:29:24 +02:00
Nikolay Sivov 725b069e68 shell32: Fix remaining cases of implementation pointer being returned. 2013-09-04 11:36:42 +02:00
Alexandre Julliard ba486ca1b4 shell32: Forward font messages to the listview window. 2013-05-29 18:09:00 +02:00
Andrew Talbot 1d7a407f6d shell32: Indentation fix. 2012-12-21 11:37:22 +01:00
Michael Stefaniuc 563d229b5f shell32: Avoid TRUE:FALSE conditional expressions. 2012-08-14 11:59:18 +02:00
Nikolay Sivov 3efda60ef6 shell32: Avoid pointer casts when background menu is created. 2012-01-11 17:47:30 +01:00
Nikolay Sivov e9fa059976 shell32: Merge ShellView menu implementations into a single file. 2012-01-10 18:29:04 +01:00
Nikolay Sivov a4dd8fb6a8 shell32: Use S_OK as successful return code name. 2012-01-09 15:34:15 +01:00
Michael Stefaniuc 44b2f66ac7 shell32: Remove casts to the type of the casted expression. 2011-09-21 14:41:33 +02:00
Francois Gouget 6454ec7f5d shell32: Use wine_dbgstr_rect() to trace a potentially NULL rect struct. 2011-09-19 17:56:06 +02:00
Nikolay Sivov ff090f749d shell32: Fix pidl leak (Valgrind). 2011-09-12 10:08:09 +02:00
Frédéric Delanoy 7e309601f3 dlls: Assorted spelling fixes. 2011-08-03 14:15:50 +02:00
Jay Yang cde4993d62 shell32: Have the default shell view call SHChangeNotifyRegister with unixfs pidls. 2011-07-12 11:39:05 +02:00
Francois Gouget dddac58a98 shell32: Update a comment. 2011-06-27 13:09:47 -05:00
Michael Stefaniuc 3d172c6978 shell32: Finish the COM cleanup in shlview.c. 2011-05-23 11:18:07 +02:00
Michael Stefaniuc 7d4dfae2b8 shell32: COM cleanup for the IShellView2 iface. 2011-05-23 11:18:00 +02:00
David Hedberg 18d31c2799 shell32: Don't crash on NULL cmdgroup in DefView OleCommandTarget. 2010-11-08 13:30:21 +01:00
David Hedberg 0e7a5bf76c shell32: Implement Set/GetCurrentViewMode in the default shellview. 2010-07-23 11:43:05 +02:00
Nikolay Sivov fc59d0b2f8 shell32/shlview: Remove redundant message sent on every iteration, fix a helper interface leak. 2010-04-27 14:39:20 -05:00
Nikolay Sivov 7ea711964b shell32/shlview: Try to use IShellDetails to respond on notifications if IShellFolder2 isn't available. 2010-04-27 14:39:08 -05:00