Commit Graph

149 Commits

Author SHA1 Message Date
Sven Baars 2dac805244 shell32: Fix a leak on error path (Coverity).
Signed-off-by: Sven Baars <sbaars@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-10-05 20:54:16 +02:00
Alexandre Julliard 06c7d3a945 shell32: Fix compiler warnings for the Windows build.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-04-15 21:33:07 +02:00
Nikolay Sivov 612a194133 shell32: Use ARRAY_SIZE macro.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-19 12:35:12 +01:00
Nikolay Sivov e3b200bd8a shell32: Use global memory allocation helpers.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-02-22 14:16:33 +01:00
Nikolay Sivov 2406d6cd84 shell32: System shellfolders don't support GetDefaultSearchGUID() in recent versions.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-27 10:20:11 +02:00
Nikolay Sivov babd22b443 shell32: System shellfolders don't implement GetDefaultColumn().
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-27 10:20:09 +02:00
Vincent Povirk a796bcaa7f shell32: Support SFGAO_LINK in unix shell namespace.
Signed-off-by: Vincent Povirk <vincent@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-26 08:42:24 +02:00
Nikolay Sivov f23edde42c shell32: Partially implement MapColumnToSCID().
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-25 22:21:42 +02:00
Nikolay Sivov 8f21b352c2 shell32: Fix return value of GetDetailsOf() for unixfs folder.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-01-26 10:37:00 +01:00
Andrey Gusev 954560f847 shell32: Use debugstr_guid() and debugstr_w() in TRACE() messages.
Signed-off-by: Andrey Gusev <andrey.goosev@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-22 21:34:50 +09:00
Michael Müller b05aa34f63 shell32: Correctly compare result of SHFileOperation in UNIXFS copy/delete functions.
Signed-off-by: Michael Müller <michael@fds-team.de>
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-04 17:31:01 +09:00
Francois Gouget 7657845b1b shell32: Fix a spelling error in an ERR() message.
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-04-25 18:48:18 +09:00
Huw Davies 77c313b8d6 shell32: Set the stream and storage attributes where needed.
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-29 21:25:21 +09:00
Huw Davies a77c0ebc80 shell32: The attributes is not an array, so don't label it as such.
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-29 21:25:21 +09:00
Francois Gouget 413c6f60cf Assorted spelling fixes.
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-12-02 12:59:52 +09:00
Francois Gouget 351d907bbd shell32: Remove unneeded NONAMELESSXXX directives. 2015-03-20 17:50:06 +09:00
Francois Gouget f505e6fb4a Assorted spelling fixes. 2015-03-19 21:54:14 +09:00
Michael Stefaniuc c13e106e73 shell32: COM cleanup for IEnumIDList. 2014-03-26 19:28:00 +01:00
Michael Stefaniuc 0aff99771d shell32: Simplify the creation of an IEnumIDList. 2014-03-26 19:27:57 +01:00
Frédéric Delanoy 0f2bed51bd Assorted spelling fixes. 2014-02-10 15:47:29 +01:00
Frédéric Delanoy 4473ce4db9 Assorted spelling fixes. 2013-10-30 09:46:27 +01:00
Frédéric Delanoy ba2f448db9 shell32: Use BOOL type where appropriate. 2013-10-01 10:51:02 +02:00
Nikolay Sivov bf0c67c322 shell32: Use proper macros when calling COM methods. 2012-07-30 17:13:33 +02:00
Francois Gouget 1f6d078e1b Assorted spelling fixes. 2012-06-04 12:17:54 +02:00
Francois Gouget fac36c55e9 Assorted typo, spelling, wording and case fixes. 2012-05-15 16:26:43 +02:00
Nikolay Sivov e8a6ca7d37 shell32: Unix folder COM cleanup. 2012-01-12 12:26:40 +01:00
Nikolay Sivov 72a7c34109 shell32: Avoid casts when creating item menu. 2012-01-11 17:47:30 +01:00
Nikolay Sivov e9fa059976 shell32: Merge ShellView menu implementations into a single file. 2012-01-10 18:29:04 +01:00
Frédéric Delanoy 40179bedee shell32: Avoid hardcoding array lengths. 2011-11-23 09:11:36 +01:00
André Hentschel 3a9cfa544a shell32: Use MAX_PATH for a DOS path. 2011-10-24 20:08:56 +02:00
Michael Mc Donnell 26f3c14d6b shell32: Set pointer to NULL after free to avoid double free. 2011-10-20 20:48:25 +02:00
Octavian Voicu 907f94e144 shell32: Disable WOW64 redirection when converting pidls to UNIX paths. 2011-07-29 18:15:54 +02:00
Nikolay Sivov 4b317fde2a shell32: Fix a cloned PIDL leak (Valgrind). 2011-01-17 12:51:06 +01:00
Piotr Caban 856da7e11d shell32: Don't check if files are of the same type if name is equal in IShellFolder2_CompareIDs. 2011-01-13 17:33:43 +01:00
Piotr Caban ad2201054c shell32: Try to get file status from FileSystemBindData in UNIXFS_path_to_pidl. 2011-01-13 17:33:43 +01:00
Andrew Eikum 2f05b5a6d9 shell32: Fix an off-by-one error that causes an infinite loop. 2010-11-18 12:31:22 +01:00
Andrew Eikum f324f3c31e shell32: Don't fail if the path doesn't exist in Unix in IShellFolder::ParseDisplayName. 2010-11-12 11:41:08 +01:00
Piotr Caban e062d4a6ff shell32: Improved IShellFolder_GetUIObjectOf implementation. 2010-11-10 16:16:45 +01:00
David Hedberg 10c0c4a8c1 shell32: Don't allow binding to files in any ShellFolder implementation. 2010-11-08 13:30:21 +01:00
David Hedberg a6a946b2b1 shell32: Remove reliance on the ability to bind to files in UnixFolder GetDisplayNameOf. 2010-11-08 13:30:21 +01:00
David Hedberg 193a80a779 shell32: Remove reliance on the ability to bind to files in UnixFolder CompareIDs. 2010-11-08 13:30:21 +01:00
David Hedberg a690db9f1e shell32: Replace some checks with calls to _ILIsEmpty(). 2010-08-02 15:56:48 +02:00
David Hedberg a6db972c77 shell32: Change a fixme to a trace in shfldr_unixfs.c.
This downgrades a FIXME that can be triggered in normal operation
through the use of, for example, SHGetIDListFromObject.
2010-07-22 16:24:33 +02:00
Andrew Eikum f99c81621c shell32: IShellFolder::ParseDisplayName should work for missing files if given valid IBindCtx.
Additionally, SHSimpleIDListFromPath now returns PIDLs for non-existent
paths, as it should.
2010-07-22 10:24:56 +02:00
Andrew Eikum 2b3fea0249 shell32: Pass the file extension to ParseDisplayName in unixfs's SetNameOf. 2010-06-29 15:20:48 +02:00
David Hedberg c1682eb8eb shell32: Fix possible memory leak in CreateUnixFolder. 2010-06-01 11:05:01 +02:00
Nikolay Sivov e51fe8e070 shell32: Use shared code to return column details from IShellFolder2::GetDetailsOf(). 2010-04-19 15:37:52 +02:00
Huw Davies c6b6082d16 shell32: Improve a TRACE and issue a FIXME if the interface is not implemented. 2010-03-05 15:21:22 +01:00
Marcus Meissner bc85487496 shell32: Remove useless NULL check (Coverity). 2009-11-19 11:47:55 +01:00
Vincent Povirk 7236452df8 shell32: Implement UnixFolder_IShellFolder2_GetDefaultColumn. 2009-02-24 16:57:30 +01:00