5be085dec5
rpcrt4: Fix a leak of msg in RPCRT4_io_thread on the error paths.
2008-01-09 12:25:56 +01:00
e0c67a189b
rpcrt4: Implement NdrMapCommAndFaultStatus.
...
Add tests for this function.
2008-01-09 12:25:50 +01:00
c370980dfa
rpcrt4: Use send on a socket instead of write as it's more portable.
2008-01-09 12:25:46 +01:00
af4639f74a
rpcrt4: Improve error handling in RPCRT4_io_thread and remove commented-out code.
2008-01-08 14:02:56 +01:00
d0f914befc
rpcrt4: Bind to the server interface in I_RpcGetBuffer, not I_RpcSendReceive.
...
The actual sending of the request is still done in I_RpcSendReceive though.
Disallow the server from calling I_RpcSend and I_RpcReceive to allow
simplification of the code. The releasing of the connection is now done
in I_RpcFreeBuffer.
Implement I_RpcNegotiateTransferSyntax.
2008-01-08 14:00:50 +01:00
bb78c3f86d
rpcrt4: Remove some unused includes.
2008-01-08 14:00:46 +01:00
9ff15252d0
rpcrt4: Set the fBufferValid flag in NdrProxyGetBuffer.
...
Only call IRpcChannelBuffer_FreeBuffer in NdrProxyFreeBuffer if
fBufferValid is set.
2008-01-08 14:00:44 +01:00
e2e7916739
rpcrt4: Set ReservedForRuntime to NULL in NdrClientInitializeNew.
2008-01-07 22:55:48 +01:00
ea44471088
rpcrt4: Implement RpcAsyncInitializeHandle.
2008-01-07 22:55:46 +01:00
1da9d47f1b
rpcrt4: Add tests for some async RPC functions.
2008-01-07 22:55:44 +01:00
fef28ec6cb
rpcrt4: Add stubs for asynchronous functions.
2008-01-07 22:55:41 +01:00
b0cbf664f6
rpcrt4: Add stubs for I_RpcAsyncSetHandle and I_RpcAsyncAbortCall.
2008-01-07 22:55:39 +01:00
807a203f77
rpcrt4: Call NdrCorrelationInitialize and NdrCorrelationFree from NdrClientCall2 if new correlation descriptors have been specified.
2008-01-07 22:55:37 +01:00
23c9b6c161
rpcrt4: Add stubs for NdrCorrelationInitialize, NdrCorrelationPass and NdrCorrelationFree.
2008-01-07 22:55:34 +01:00
f9a54a58d5
rpcrt4: ndr_stubless.h should include ndrtypes.h as it depends on types it defines.
2008-01-07 22:55:32 +01:00
31676530c2
rpcrt4: Set the ProcNum of RPC_MESSAGE in NdrClientInitializeNew to include RPC_VALID_FLAGS_BIT.
...
Mask out RPC_VALID_FLAGS_BIT from ProcNum when it is used to build a
packet to send to the server.
2008-01-07 22:55:28 +01:00
4d6aa7ca95
rpcrt4: Add tests for the RPC_MESSAGE members set by NdrClientInitializeNew.
2008-01-07 22:55:22 +01:00
f296a8ca6c
rpcrt4: Implement I_RpcMapWin32Status.
...
Add a test for this function.
2008-01-07 12:41:17 +01:00
a0410bef34
rpcrt4: Print fixme's if the serialize or no-serialize flags are set on a context handle being marshalled or unmarshalled.
2008-01-07 12:32:31 +01:00
f9fc52f602
rpcrt4: Pass the interface identifier to the lower-level context handle routines for context handles with the strict flag set.
2008-01-07 12:32:07 +01:00
0e6d5202c8
rpcrt4: Don't set Buffer to NULL in I_RpcFreeBuffer.
2008-01-07 12:04:31 +01:00
1bb6c1b4d1
rpcrt4: Add some tests for NdrGetBuffer and NdrFreeBuffer.
2008-01-07 12:04:28 +01:00
c8b3dc40a4
rpcrt4: Update todos.
2008-01-07 12:02:52 +01:00
56da854c21
rpcrt4: Fix NdrGetBuffer to set the correct fields in the MIDL_STUB_MESSAGE structure.
...
Fix NdrFreeBuffer to use the fBufferValid flag to determine whether or
not I_RpcFreeBuffer needs to be called.
2007-12-31 17:14:34 +01:00
4aff0cdac4
rpcrt4: Make some variables in the tests static.
2007-12-31 17:14:29 +01:00
07622b0f05
rpcrt4: Add tests for NdrServerInitializeNew.
2007-12-31 17:14:22 +01:00
e745f93c79
rpcrt4: Fix the MIDL_STUB_MESSAGE fields set by NdrServerInitializeNew.
2007-12-31 17:14:16 +01:00
f6a29a1e73
rpcrt4: Fix a case of destroying a context handle without first releasing the lock.
...
Reverse the order of the release statements in NDRSContextMarshall2 for
the case where the context handle doesn't have valid data so that the
release that releases the lock comes first and then the optional second
release doesn't need to release the lock.
2007-12-31 17:14:04 +01:00
51c051c0c4
rpcrt4: Keep a track of server context handles allocated during processing of a request.
...
Release them after processing of a request has finished to avoid a slow
memory leak if the association isn't released for ages.
2007-12-31 17:13:55 +01:00
86a0b1d24e
rpcrt4: Implement NdrConformantStringMemorySize.
2007-12-31 16:47:55 +01:00
274dc73ba1
rpcrt4: Add some tests for non-conformant strings.
2007-12-31 16:46:16 +01:00
eeeed91d92
rpcrt4: Implement non-conformant string functions.
2007-12-31 16:46:10 +01:00
3e8a032e8b
rpcrt4: Re-use existing memory for embedded pointers in NdrVaryingArrayUnmarshall.
2007-12-26 14:02:58 +01:00
273766ee6f
rpcrt4: Re-use existing memory for embedded pointers in NdrConformantVaryingArrayUnmarshall.
2007-12-26 14:02:55 +01:00
a05923e1d3
rpcrt4: Add tests for varying and conformant varying arrays.
2007-12-26 14:02:53 +01:00
e24f664b26
rpcrt4: Add tests for low-level context handle functions.
2007-12-26 13:26:52 +01:00
3d8af5630b
rpcrt4: Implement low-level context handle support.
...
Server context handles are tracked from associations as their lifetime
is determined by the lifetime of the association.
2007-12-26 13:26:49 +01:00
698ba6b4d4
rpcrt4: Implement higher-level NDR server context handle functions.
...
Implement NdrServerContextMarshall and NdrServerContextNewMarshall on
top of NDRSContextMarshall2. Implement NdrContextHandleInitialize,
NdrServerContextUnmarshall and NdrServerContextNewUnmarshall on top of
NDSContextUnmarshall2.
2007-12-26 13:26:38 +01:00
cf6d95c1b8
rpcrt4: Move low-level NDR context handle functions to a separate file.
2007-12-26 13:26:30 +01:00
64d1e2d8e3
rpcrt4: Set pStubMsg->BufferMark in NdrConformantVaryingArrayUnmarshall and NdrVaryingArrayUnmarshall.
...
pStubMsg->BufferMark should always be set before
EmbeddedPointerUnmarshall is called and these functions didn't
previously do so.
2007-12-23 13:55:27 +01:00
366fd6e3af
rpcrt4: Fix a memory leak from the get_filename call in the server tests.
2007-12-21 12:41:21 +01:00
17eb6f44ad
rpcrt4: Print an error if stub buffer pointer is passed into safe_copy_from_buffer.
...
Also print an error message if there was an overflow.
2007-12-21 12:41:18 +01:00
9a888e6465
rpcrt4: Fix NdrConformantStringUnmarshall to always increment the buffer during unmarshalling.
...
safe_copy_from_buffer has the side-effect of incrementing the buffer and
this still needs to be done when we point the memory into the buffer.
(Thanks to Maarten Lankhorst for finding the mistake and suggesting a fix.)
2007-12-20 12:10:30 +01:00
6382c8af3f
rpcrt4: Don't use BufferEnd in RpcStream_Write.
...
It is usually used during marshalling, where pStubMsg->BufferStart and
pStubMsg->BufferEnd won't be valid. Replace it with a check using
RpcMsg->Buffer and pStubMsg->BufferLength.
2007-12-19 19:35:42 +01:00
c49a73b853
rpcrt4: Initialise memory passed into RPCs in the server test.
...
aligns contains padding, but the memory is marshalled in one block so
call memset to avoid Valgrind warnings. padded and padded2 are
marshalled as complex types so this is not required here.
Initialise the dummy member of test_list_t to zero for the TL_NULL case.
Change the type to the smallest available to not waste buffer space.
2007-12-19 19:35:28 +01:00
22b20879f7
rpcrt4: Memory should only be cleared in ComplexUnmarshall, not in ComplexMarshall.
...
Also clear memory when FC_STRUCTPAD* is encountered.
2007-12-19 19:35:02 +01:00
50cab7736a
rpcrt4: Fix the ALIGN_POINTER_CLEAR macro.
2007-12-19 19:34:56 +01:00
1cb7df8a98
rpcrt4: Implement I_RpcGetCurrentCallHandle.
2007-12-18 19:48:19 +01:00
6210c097a4
rpcrt4: Add missing LeaveCriticalSection. Found by Smatch.
2007-12-18 12:32:55 +01:00
bdc5a34196
rpcrt4: Add a stub for I_RpcGetCurrentCallHandle.
2007-12-18 12:32:55 +01:00
b9c92e9564
rpcrt4: Don't copy memory from the buffer in NdrConformantStringUnmarshall if we just pointed the memory pointer into the buffer.
...
(Reported by Dan Kegel.)
2007-12-18 12:32:55 +01:00
76d266cbb0
rpcrt4: Add an rpcasync.h header stub and fix the RpcErrorStartEnumeration() prototype.
2007-12-18 12:32:42 +01:00
737510eeb6
rpcrt4: Move association code into a separate file.
2007-12-17 11:59:18 +01:00
22f530c835
rpcrt4: Make a server association when a bind packet is received in the server.
...
Support handing out association group IDs.
2007-12-17 11:59:13 +01:00
2bda19c6b0
rpcrt4: Return an error from rpcrt4_conn_tcp_read if recv returns 0.
2007-12-17 11:58:57 +01:00
259879d1f5
rpcrt4: Fix NdrConformantStringUnmarshall to use buffer memory if possible.
2007-12-17 11:58:06 +01:00
b300189c43
rpcrt4: Add a FIXME for RPC_FC_P_ALLOCALLNODES in PointerUnmarshall.
2007-12-17 11:58:00 +01:00
68432dd339
rpcrt4: Clear padding inserted into the buffer during marshalling because of alignment.
2007-12-17 11:57:54 +01:00
c8a802eea8
include: Make RpcRaiseException DECLSPEC_NORETURN, like it is in the PSDK.
2007-12-14 12:28:03 +01:00
ba280fb1b0
rpcrt4: Fix a typo in rpcrt4_conn_tcp_read.
2007-12-14 12:27:09 +01:00
25bf0a409a
rpcrt4: Update TODO list.
...
Out-of-memory check is performed by NdrAllocate and so isn't required to
be done in the unmarshalling functions.
2007-12-14 12:24:34 +01:00
4a028589eb
rpcrt4: Document NdrAllocate.
2007-12-14 12:24:24 +01:00
c7261b732b
rpcrt4: Partially revert commit 18faf3184b2ea263d77c2a7ad92eef27bc4ba08f.
...
Tests show that NdrPointerFree (and hence NdrFree) don't check whether
the memory was allocated with NdrAllocate before freeing it. This makes
sense as servers don't need to use NdrAllocate to allocate memory being
returned and so this commit caused that memory to be leaked.
NdrAllocate hasn't been changed as the tests show it is correct and it
appears that the memory list is used to implement the RpcSs memory model.
2007-12-14 12:24:21 +01:00
ce220e2b5f
rpcrt4: Free the base pointer in PointerFree when freeing a pointer with RPC_FC_P_DEREF.
2007-12-14 12:24:03 +01:00
d5ff3467bc
rpcrt4: Fix the check in NdrPointerFree.
...
Add comments to justify why this is the only check that is needed.
2007-12-14 12:23:55 +01:00
9d8ebc1a24
rpcrt4: NdrStubGetBuffer shouldn't set BufferStart and BufferEnd.
...
These are supposed to point to the original buffer when the types were
unmarshalled.
2007-12-14 12:23:46 +01:00
ded4b86625
Revert "rpcrt4: Try to free every non-stack pointer in PointerFree now that NdrFree does the sanity checking for us.".
...
This reverts commit 6db648302ce43f625a073426a35a6f40b7869d8b.
Tests show the assumptions in a commit that this commit depends on are
not valid.
2007-12-14 12:23:38 +01:00
9642714d06
rpcrt4: Add tests for freeing non-NdrAllocate allocated memory blocks.
2007-12-13 14:30:40 +01:00
e12b487e26
rpcrt4: Try to free every non-stack pointer in PointerFree now that NdrFree does the sanity checking for us.
2007-12-12 16:02:53 +01:00
9c8c74f388
rpcrt4: Store allocated memory in a singly-linked list to keep track of what we should and shouldn't free in NdrFree.
2007-12-12 16:02:43 +01:00
33c4c25dad
rpcrt4: Make the NdrAllocate tests pass on XP SP2 and greater.
2007-12-12 16:01:33 +01:00
d458a599eb
widl: Add support for non-basetype return types.
2007-12-11 18:07:05 +01:00
766d8a17af
rpcrt4: Pass the USER_MARSHAL_CB structure into user marshal routines.
2007-12-10 12:04:28 +01:00
80b8743aa2
rpcrt4: NdrRangeUnmarshall is implemented so add it to the spec file.
2007-12-10 12:04:19 +01:00
a07afe7e06
rpcrt4: Implement NdrConformantArrayMemorySize.
2007-12-10 12:04:15 +01:00
41937c5756
rpcrt4: Add a missing break in DllMain.
2007-12-08 19:58:24 +01:00
417b9d80f2
rpcrt4: Save the buffer in EmbeddedPointerMemorySize, like EmbeddedPointerUnmarshall does.
2007-12-08 19:58:11 +01:00
d7a0de303e
rpcrt4: Fix the return value from NdrSimpleStructMemorySize.
2007-12-08 19:58:07 +01:00
3a13de3115
rpcrt4: Add a trace to NdrBaseTypeMemorySize.
2007-12-08 19:58:03 +01:00
7ae1d44816
rpcrt4: Implement PointerMemorySize.
2007-12-08 19:57:55 +01:00
8348f0413d
rpcrt4: Fix NdrConformantStructUnmarshall to use buffer memory if applicable and to reuse memory for embedded pointers.
2007-12-08 19:57:46 +01:00
a5f9ed81e3
rpcrt4: Fix NdrFixedArrayUnmarshall to use buffer memory if applicable and to reuse memory for embedded pointers.
2007-12-08 19:57:39 +01:00
abbceb137a
rpcrt4: Fix NdrConformantArrayUnmarshall to use buffer memory if applicable and to reuse memory for embedded pointers.
2007-12-08 19:57:32 +01:00
c0b12351e0
Avoid size_t types in traces.
2007-12-07 18:49:18 +01:00
7092590c90
rpcrt4: Use an alertable wait in rpcrt4_protseq_np_wait_for_new_connection to fix a small memory leak flagged by Valgrind.
...
This is called only by the RPCRT4_server_thread so we don't have to
worry about application user APCs being run at improper times.
2007-12-07 17:06:33 +01:00
ba6aec70ca
rpcrt4: Implement NdrConformantStructFree.
2007-12-07 17:06:05 +01:00
2ebee18198
rpcrt4: Improve PointerFree to not free buffer memory.
2007-12-07 16:34:17 +01:00
1b79da8be0
rpcrt4: Fix a memory leak caused by NdrFullPointerXlatFree not freeing the entries in the full pointer translation table.
2007-12-06 12:08:10 +01:00
867cc3c05f
rpcrt4: Fix a memory leak when freeing an association by deleting the critical section.
2007-12-06 12:08:05 +01:00
5fb5fccac0
rpcrt4: Fix a memory leak in RpcAssoc_BindConnection.
2007-12-06 12:08:00 +01:00
13e47d762a
rpcrt4: Set the memory pointer in NdrBaseTypeUnmarshall to the buffer if we're unmarshalling on a server without memory being passed in.
2007-12-05 13:49:08 +01:00
17132f7e1f
rpcrt4: Set fMustAlloc to TRUE when unmarshalling an object pointer.
2007-12-05 13:48:59 +01:00
c866b06806
rpcrt4: Add tests for a pointer to a conformant strings.
2007-12-04 18:18:03 +01:00
2a9fae7565
rpcrt4: Set the destination pointer in PointerUnmarshall before calling the referenced type's unmarshalling routine.
...
When a pointer that is dereferenced is encountered then this can result
in a stale pointer (i.e. the one that is marshalled into the buffer for
the embedded pointer unmarshalling case) being used instead of the one
that was intended.
2007-12-04 18:18:01 +01:00
a016d7b335
rpcrt4: Handle all non-continuable exceptions in CStdStubBuffer_Invoke.
2007-12-04 13:33:10 +01:00
6dcc3fe62e
rpcrt4: Put the delegating stub thunks in an executable memory page, rather than on the heap.
2007-12-04 13:32:41 +01:00
341208bf1b
rpcrt4: Call IRpcChannelBuffer_GetDestCtx in NdrStubInitialize, just like we do in NdrProxyInitialize.
2007-12-04 13:32:29 +01:00
f191f59ee4
rpcrt4: Flesh out more of the IRpcChannelBuffer vtable to make the test_delegating_Invoke test succeed on Windows.
2007-12-04 13:31:59 +01:00
620fca405d
rpcrt4: Test that the string retrieved from get_name was actually unmarshalled correctly.
2007-12-03 13:10:21 +01:00
d8e467b0fd
rpcrt4: Reverse the conditions for which *pPointer is assigned base_ptr_val in PointerUnmarshall.
...
In one condition (fMustAlloc == TRUE), base_ptr_val may be uninitialised
and so cause a valgrind warning. Reversing the check is harmless and
doesn't result in a performance decrease.
2007-12-03 13:10:21 +01:00
Rob Shearman