Commit Graph

3193 Commits

Author SHA1 Message Date
Nikolay Sivov 2fff77a0ee shell32/tests: Fix prototype to match implementation (PVS-Studio).
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-10-21 21:09:13 +09:00
Nikolay Sivov 186bed3d16 shell32: Properly handle SHGetPathFromIDListW failure (PVS-Studio).
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-10-21 01:04:29 +09:00
Nikolay Sivov 4ee4c06410 shell32: Cleanup ReadCabinetState exports.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-10-21 00:25:35 +09:00
Nikolay Sivov 95ecc29a50 shell32: Remove another recurring return code check (PVS-Studio).
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-10-21 00:25:34 +09:00
Nikolay Sivov e2275b0a2a shell32: Remove recurring return value check (PVS-Studio).
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-10-19 12:22:39 +09:00
Nikolay Sivov 5853e7769c shell32: Simplify conditional expression (PVS-Studio).
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-10-15 19:18:26 +09:00
Nikolay Sivov 972a74ddfe shell32: Added dll manifest file.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
2015-10-01 16:33:28 +09:00
Nikolay Sivov e585d17ff3 shell32/tests: Test icon ids that are invalid on all systems. 2015-09-16 22:11:09 +09:00
Vincent Povirk 69d57ee72f shell32: Do nothing if we can't convert PIDL to path in SHAddToRecentDocs. 2015-09-15 17:55:19 +09:00
Zhenbo Li 637bcd5de9 shell32: Fix return type for helper functions of SHFileOption. 2015-09-01 21:11:16 +09:00
Vincent Povirk 8657547d9e shell32: Fix getting parent shell folder when it's the desktop folder.
BindToObject fails in this case.
2015-08-17 14:47:37 +09:00
Vincent Povirk 642b2fe789 shell32: Use return value from IShellFolder_GetAttributesOf. 2015-08-17 14:47:30 +09:00
Hans Leidekker 7ec5f555b0 shell32: Add a stub implementation of SHQueryUserNotificationState. 2015-08-06 21:42:30 +09:00
Mark Harmstone 77b75ca14b shell32: Don't hardcode icon sizes in SIC_LoadIcon. 2015-08-03 11:00:54 +02:00
Nikolay Sivov e46c32ab46 shell32/ebrowser: Implement EBO_NOBORDER option. 2015-08-03 10:57:46 +02:00
Nikolay Sivov 118c469598 shell32/ebrowser: Use proper color for pane separator. 2015-08-03 10:57:37 +02:00
Nikolay Sivov e7acfee978 shell32: Added GetCurrentProcessExplicitAppUserModelID() stub. 2015-07-22 16:42:42 +02:00
Sebastian Lackner 7d3f13a129 shell32: Ensure that commandline is null-terminated when no parameters are given. 2015-07-17 14:28:17 +09:00
Piotr Caban 943ead5022 shell32: Fix SHELL_execute code that removes quote arround file name. 2015-07-16 16:29:12 +09:00
Piotr Caban 663f9f4b21 shell32: Handle executable with space in path in SHELL_execute. 2015-07-16 16:29:09 +09:00
Piotr Caban 8e853a3e90 shell32: Remove code for separating arguments from file path. 2015-07-16 16:29:06 +09:00
Huw Davies 0b9737b1ea shell32: Fix threading model for the Known Folder Manager and Shell Link objects. 2015-07-08 16:02:23 +09:00
Thomas Faber 360cf273ae shell32/tests: Test that shell view windows reference their shell view. 2015-07-07 16:52:21 +09:00
Nikolay Sivov 28caa68d41 shell32/tests: Try harder to close Open With window. 2015-07-07 16:52:20 +09:00
Huw Davies f5e16e0638 shell32/tests: Win 2k doesn't cope with spaces in the path. 2015-07-07 16:52:20 +09:00
Huw Davies c5053f5712 shell32/tests: Win XP splits the args if there are spaces in the path.
This isn't seen on winetest runs, but is when jobs are submitted to
the testbot.  Presumably the path of the executable is different in
the two cases.
2015-07-07 16:52:19 +09:00
Thomas Faber eff884f19b shell32/tests: Destroy shell view windows. 2015-07-06 17:09:50 +09:00
Thomas Faber 71f1c90628 shell32/tests: Fix an ok() print. 2015-07-06 17:09:50 +09:00
Nikolay Sivov 69733d65e8 shell32: Handle string-to-guid conversion errors (Coverity). 2015-07-06 15:13:24 +09:00
Thomas Faber 9551179c0b shell32/tests: Remove a misleading test. 2015-06-30 14:41:43 +09:00
Thomas Faber e582495927 shell32: Use QueryInterface in FolderView_GetFolder.
test_IFolderView has a test that shows that the shell folder's reference
count before and after the call to IFolderView_GetFolder is the same.
However this is misleading because it is not a property of the
IFolderView_GetFolder method, but of the desktop shell folder object
that's used in the folder view. Windows <=2003 uses a cached object and
its AddRef/Release methods return constants.
2015-06-30 14:41:43 +09:00
Thomas Faber c0cd954f98 shell32: Add missing parameter check in ISF_Desktop_fnQueryInterface. 2015-06-30 14:40:43 +09:00
Thomas Faber 9353a36d8f shell32/tests: Do not leak shell folder references. 2015-06-29 21:15:10 +09:00
Nikolay Sivov 7ca31b8119 shell32: Fix memory leak on NULL return length (Coverity). 2015-06-29 18:51:02 +09:00
Huw Davies da5151fd54 shell32/tests: Don't leave behind open explorer windows. 2015-06-23 21:59:40 +09:00
Huw Davies 905e7aad0e shell32/tests: Fix failing test on Win 2k. 2015-06-11 21:05:34 +09:00
Nikolay Sivov 1de3aec336 shell32/tests: Fix error code on win2k. 2015-06-08 15:26:53 +09:00
Nikolay Sivov d5d49464d3 shell32/tests: Fix tests failures on win2k. 2015-06-05 14:11:02 +09:00
Nikolay Sivov 8c11e6b2f0 shell32/tests: Fix one of test failures on win2k. 2015-06-04 15:55:57 +09:00
Nikolay Sivov 98da69a83f shell32/tests: Fix Verbs instance leak (Valgrind). 2015-06-04 15:55:45 +09:00
Akihiro Sagawa d2e9856a56 shell32: Skip buffer allocation when querying drop file numbers. 2015-06-02 20:53:43 +09:00
Akihiro Sagawa 37d7d6f81c shell32/tests: Add tests for DragQueryFile. 2015-06-02 20:53:43 +09:00
Akihiro Sagawa 4c31892ea5 shell32/tests: Make tests run on win2k again. 2015-06-02 14:09:12 +09:00
Nikolay Sivov bf41160c65 shell32: Implement FolderItemVerbs::Item(). 2015-05-11 15:39:26 +09:00
Nikolay Sivov 8f72117f19 shell32: Added FolderItemVerb stub. 2015-05-11 15:39:25 +09:00
Nikolay Sivov 77c2892d87 shell32: Implement FolderItemVerbs_get_Count(). 2015-05-11 15:39:25 +09:00
Nikolay Sivov 540171bc91 shell32: Added FolderItemVerbs stub. 2015-05-11 15:39:25 +09:00
Nikolay Sivov e013a7e584 shell32: Implement ParseName(). 2015-05-11 15:39:25 +09:00
Alexandre Julliard ed700d16f7 shell32/tests: Avoid duplicate const. 2015-05-11 15:39:25 +09:00
Nikolay Sivov 80d28abdc8 shell32: Partially implement SHGetKnownFolderIDList(). 2015-05-11 15:39:25 +09:00