2b53df89cb
riched20: Fixed some lParams with keycodes (Coverity).
2011-05-06 14:23:46 +02:00
0cd53a589d
riched20: Use correct flag name (Coverity).
2011-05-06 14:23:46 +02:00
2ae0d40c8f
riched20: Adjusted shift by 8 bits to 16 bits (Coverity).
2011-05-06 14:23:45 +02:00
c52c15ef99
riched20: COM cleanup for the ITextServices iface.
2011-04-11 12:10:30 +02:00
e18ae2139b
riched20: COM cleanup for the ITextHost iface.
2011-04-11 12:10:20 +02:00
cc2cd5a525
riched20/tests: Add a '\n' to an ok() call.
2011-03-07 11:09:27 +01:00
c17df92e5d
riched20/tests: Remove win9x hacks.
2011-02-28 13:13:33 +01:00
4b7795a943
riched20: Add a missing break.
2011-02-23 19:23:38 +01:00
f8da57ca89
riched20: Fix a c89 conformance issue in ITextImpl->editor->rcFormat initialization.
2011-02-16 14:02:59 +01:00
1e758c5e8c
riched20: Do not call callback when no data needs to be flushed.
2011-02-09 13:49:03 -06:00
75e4e607c6
riched20/tests: Make sure return value is used (LLVM/Clang).
2011-02-09 09:25:58 -06:00
997a681300
riched20/tests: Fix editor tests.
2011-01-24 14:43:27 +01:00
bee48efdce
riched20/tests: Skip some tests on non-English platforms.
2011-01-19 16:54:02 +01:00
d43cddcc83
richedit: Clear non-default style when changing to plain text mode.
...
Although the text must be empty for the mode to change to plain text
mode, there still may be a non-default style for the temporary insert
style and style for the end of text run.
2011-01-12 11:32:19 +01:00
cea221caa0
riched20/tests: Don't test function directly when reporting GetLastError().
2010-12-30 15:00:58 +01:00
9a6f5ad239
riched20: Standardize the COM usage in clipboard.c.
2010-12-09 12:28:52 +01:00
0acf4a297b
riched20/tests: Use an iface instead of a vtbl pointer in ITextHostTestImpl.
2010-12-09 12:28:41 +01:00
954558806e
riched20: Use the correct resource id for the reverse arrow cursor.
2010-10-18 19:08:37 +02:00
b20e75f5e9
riched20/tests: Cleaned up ITextServices::TxGetNaturalSize test and fixed test failures.
2010-10-13 17:45:23 +02:00
d08fc66732
riched20/tests: Plug a few memory leaks and make failure messages more meaningful.
2010-10-06 20:46:49 +02:00
95c1bd4da9
riched20/tests: Make some variables static.
2010-10-01 13:40:29 +02:00
81b8ee863e
makefiles: Add a standard header for all makefiles to replace the common variable initializations.
2010-09-19 12:36:48 +02:00
c0ee555e8f
richedit: Avoid redundant calls to ME_CalcRunExtent.
...
ME_SplitRun is only called by wrapping code. In all but one call the
returned second half of the split run will be returned, get passed back
to ME_WrapHandleRun, then ME_CalcRunExtent will be called at the start of
ME_WrapHandleRun through ME_WrapSizeRun.
2010-07-30 11:36:02 +02:00
8b8e4f89b2
richedit: Use ME_Cursor as parameter to ME_SplitRunSimple.
...
The paragraph needed to be included in the parameters to avoid needing
traverse the linked list of display items to find the paragraph.
2010-07-30 11:36:02 +02:00
68b44f740c
richedit: Remove checks for converting internal CHARFORMAT structs.
...
Prevents extra copying from having to be done for converting between
unicode/ascii or between the normal or extended version of the structure.
2010-07-30 11:36:02 +02:00
ad056fe7d7
richedit: Check for bits instead of equality in EM_SETCHARFORMAT.
...
There are unsupported flags documented on MSDN which would cause problems
for the equality checks used in EM_SETCHARFORMAT. Also, to handle a
combined set of flags they must be checked for in the right order.
2010-07-30 11:36:01 +02:00
16d7890426
richedit: Don't change text mode with undo or redo stack.
2010-07-30 11:36:01 +02:00
75eef41881
richedit: Return correct values when EM_SETTEXTMODE fails.
...
The checks for the text length and invalid parameters needed to be swapped,
and the code could be easily simplified.
2010-07-30 11:36:01 +02:00
4c174fc845
richedit: Removed unused run flags values.
...
The only place MERF_SKIPPED was in debug code, and MERF_CALCBYWRAP was only
used to clear this unused flag value, so I got rid of both of them.
2010-07-29 10:28:29 +02:00
15251ad84b
richedit: Removed redundant variable ptLastSplittableRun.
2010-07-29 10:28:06 +02:00
dfa80b35b0
richedit: Invalidate without calling UpdateWindow in many cases.
2010-07-29 10:28:00 +02:00
1964e603fd
richedit: Remove redundant commit and repaint in ME_StreamInText.
...
ME_StreamInText is only used in one function, ME_StreamIn, which always
calls ME_CommitUndo and ME_UpdateRepaint after calling this function.
2010-07-29 10:27:38 +02:00
328a3f1d8c
richedit: EN_UPDATE notification is sent on WM_PAINT.
2010-07-29 10:27:30 +02:00
b86d515ed6
dlls: Remove explicit imports of kernel32 and ntdll.
2010-07-21 17:38:36 +02:00
be3073fce1
richedit: Fix streaming rtf with table at the start of the text.
...
The first paragraph was being handled just by ME_StreamOutParaProps,
but subsequent paragraphs would check if the paragraph was starting or
ending a table. So I moved the code to check for tables into
ME_StreamOutParaProps.
2010-07-19 14:38:16 +02:00
e2f6b1d83d
richedit: Don't break when streaming out a table, just continue.
...
This is a regression caused by commit
54b53b6018
2010-07-19 14:38:16 +02:00
61e5fec020
riched20: Process messages which arrive before WM_NCCREATE.
2010-07-08 17:33:25 +02:00
6072a69d38
richedit: Keep default char format on WM_SETFONT in plain text mode.
2010-06-07 15:27:52 +02:00
b88b007d95
richedit: Fix assignment to wrong variable (LLVM/Clang).
2010-05-25 12:02:28 +02:00
3f1d3e0ea1
richedit: Simplify redundant code in WM_IME_COMPOSITION.
2010-05-24 11:30:23 +02:00
e809bc887d
richedit: Commit undo items after modifications in WM_IME_COMPOSITION.
...
ME_InsertTextFromCursor could previously follow the ME_CommitUndo call
leaving uncommitted changes which would cause improper grouping of commits,
or an assertion failure.
2010-05-24 11:30:12 +02:00
fb7d6b783e
richedit: Missing HeapFree in WM_IME_COMPOSITION. (Smatch).
...
ME_InsertTextFromCursor copies the string passed into it rather than making
taking ownership of it.
2010-05-24 11:30:06 +02:00
dcbc22b985
richedit: Send EN_SELCHANGE after wrapping but before EN_CHANGE.
...
The call to ME_SendSelChange cannot be done in ME_CommitUndo like it was
before, because it must be done after wrapping. Native richedit controls
send EN_CHANGE first, which is sent in ME_UpdateRepaint, so
ME_SendSelChange must be before this notification in ME_UpdateRepaint.
2010-05-19 11:17:55 +02:00
d312d4e33c
richedit: Revert commit that caused a regression. (Bug 22758).
...
Revert commit 049cf5aca0
2010-05-19 11:17:55 +02:00
cf13e8a390
riched20: Avoid using long.
2010-05-17 12:42:33 +02:00
f772c799ae
riched20: Remove variables yprev and ys which are not really used from ME_ArrowPageUp.
2010-05-17 12:42:31 +02:00
049cf5aca0
richedit: Avoid notifying parent window in improper state.
...
ME_CommitUndo and ME_CommitCoalescingUndo call ME_SendSelChange, which
may notify the parent window that the selection has changed, therefore
should generally be called after wrapping the text. Otherwise, the parent
window may send a message to the editor and cause an assertion failure.
2010-05-17 12:42:31 +02:00
6dd4b071cc
riched20: Remove variable pCell which is not really used from ME_StreamIn.
2010-05-10 10:11:34 +02:00
2d462ad088
riched20: Remove variable ys which is not really used from ME_ArrowPageDown.
2010-05-10 10:11:29 +02:00
f29514fbec
riched20: Remove variable di which is not really used from ME_InsertEndRowFromCursor.
2010-05-03 15:42:18 +02:00
14ef0fed9c
riched20: Remove variable changed which is not really used from ME_PrepareParagraphForWrapping.
2010-05-03 15:40:04 +02:00
01777ac5ce
riched20: Remove variable yprev which is not really used from ME_ArrowPageDown.
2010-05-03 15:37:31 +02:00
bef5645eb1
makefiles: Remove the no longer needed explicit separators for dependencies.
2010-03-16 13:28:19 +01:00
534398a57e
richedit: GTL_PRECISE to GETTEXTLENGTHEX implies GTL_NUMBYTES.
...
If GTL_PRECISE is passed without specifying either GTL_NUMCHARS or
GTL_NUMBYTES, behave as if GTL_NUMBYTES was passed.
2010-03-01 11:33:01 +01:00
7ed13120ab
richedit: Make zooming affect all pictures.
2010-03-01 11:32:33 +01:00
1f2575ba7c
richedit: Documented paragraph border widths are in points not pixels.
...
The border widths documented by msdn are in points which are 72 dpi, which
is not equivalent to pixels (normally 96 dpi). I pre-converted all the
border widths to 96 dpi resolution since this avoids needed to store
fractions, and often avoids the need for convertion to the displays
resolution.
2010-03-01 11:32:18 +01:00
fe9933ae4d
richedit: Added some extra tests for EM_FORMATRANGE.
...
The existing tests were not properly testing the return value for the case
where all the text fits in the page rect, so this patch adds a couple of
simple tests for this case.
2010-02-22 12:03:09 +01:00
6164ce2d82
makefiles: Use the standard C_SRCS variable as the list of test files.
...
This enables it to be auto-updated by make_makefiles.
2010-02-22 10:47:11 +01:00
9106860c85
richedit: Prevent crash on word selection at end of paragraph.
2010-02-18 12:18:17 +01:00
535afbd3aa
richedit: Move function ME_GetParaLineSpace to make it static.
2010-02-10 11:32:31 +01:00
e9693d6272
richedit: Removed unused local variable yStart.
2010-02-05 10:06:30 +01:00
fc3e2ba954
riched20: Don't print the function name twice in ERR/WARN.
...
The ERR/WARN macros already print the function name.
2010-02-04 13:39:28 +01:00
0539d5e497
richedit: Initialize fields for windowless richedit controls.
...
Caught by valgrind.
2010-01-25 13:01:17 +01:00
530a6c4598
richedit: Prevent uninitialized value from being used.
...
NULL may be returned by ITextHost::TxGetDC. Caught by valgrind.
2010-01-25 13:01:05 +01:00
d3bc43b5ed
Grammar fixes "is doesn't" => "doesn't".
2010-01-11 11:33:59 -06:00
3b45ababfb
riched20: Remove some explicit LPARAM/WPARAM casts.
2009-12-28 12:27:13 +01:00
8808fccd57
riched20: Initialise window size.
...
Found by Valgrind.
2009-12-16 12:42:40 +01:00
d4383b4498
riched20: Initialise the style flags.
...
Found by Valgrind.
2009-12-15 16:09:12 +01:00
d88c47fccb
riched20: Fix a memory leak.
...
Found by Valgrind.
2009-12-14 12:04:05 +01:00
c848e4ee86
riched20: Check for NULL in rtf reader (Coverity).
2009-12-03 10:21:44 +01:00
c6ff530ad6
riched20/tests: Don't leak string in test.
2009-11-30 12:56:58 +01:00
38df8cfb04
richedit: When inserting an OLE object from an RTF stream, don't force update as the stream is not fully read.
2009-11-09 20:02:03 +01:00
ab9c51dd6a
richedit: Only increment objects' reference by one when inserting an OLE object.
2009-11-09 20:01:56 +01:00
12a417de8a
riched20: Implement handling of WM_KEYDOWN VK_TAB in the dialog mode.
2009-10-13 12:38:58 +02:00
a50ca4ace0
riched20: Implement handling of WM_KEYDOWN VK_ESCAPE in the dialog mode.
2009-10-13 12:38:54 +02:00
8fb119ba8b
riched20: Implement handling of WM_KEYDOWN VK_RETURN in the dialog mode.
2009-10-13 12:38:49 +02:00
851c33ddd9
riched20: Enable the dialog mode after receiving WM_GETDLGCODE message.
2009-10-13 12:38:44 +02:00
205df00c64
riched20: Cache ES_WANTRETURN style.
2009-10-13 12:38:40 +02:00
3fe20bdc7e
richedit: Handle to parent window is cached.
...
The parent window for the richedit control on creation is the one that
receives notify messages, even after the parent has been changed using
SetParent.
2009-09-30 17:41:06 +02:00
992381b36e
richedit: Added test to show that handle to parent is cached.
2009-09-30 17:40:59 +02:00
0342ab0df1
richedit: Use ITextHost interface in ME_LinkNotify.
...
Using the ITextHost interface allows this notification to be received
for windowless richedit controls. Windowed richedit conrols have an
ITextHost implementation that will fill in hwndFrom and idFrom, but
these should probably be initialized to 0 for windowless richedit
controls.
2009-09-28 12:54:16 +02:00
99b37b2376
richedit: Silence fixme for WM_STYLECHANGING & WM_STYLECHANGED.
2009-09-24 15:15:09 +02:00
8d524700d3
riched20: Make vtables const.
2009-09-08 13:06:49 +02:00
c1a1f0cfb4
riched20: Make sure we have a valid ITextHost vtable for all platforms.
2009-08-26 21:23:52 +02:00
6e80d875d4
riched20: Make ME_SetCursorToEnd() static.
2009-08-26 13:09:27 +02:00
a8e58307f9
richedit: Fixed check for nOffset at the end of the cursor's run.
...
For some reason the code previously mixed up a selection cursor with the
result cursor. The problem seemed to have corrected itself before as a
result of conversion between offsets and cursors, but my recent changes
made this bug more severe.
2009-08-17 13:57:50 +02:00
989bdd1579
richedit: Use ME_MoveCursorChars in ME_FindText to find relative offset.
...
When a previous character needed to be found, it is simpler to move
existing cursor rather than retravese the linked list to find the offset
again.
2009-08-13 15:35:37 +02:00
54b53b6018
richedit: Use ME_Cursor instead of offsets for stream out functions.
2009-08-13 15:35:28 +02:00
bd4704280d
richedit: Replace offsets arg with ME_Cursor for ME_InternalDeleteText.
...
Offsets are still used within the function, but this patch reduces the
use of it at the entry to the function.
2009-08-13 15:35:17 +02:00
8f0dfaba30
richedit: Removed ME_InsertRun since it uses character offsets.
...
The function was used in one place, and was simply a wrapper around a
call to ME_InsertRunAtCursor, so I removed it to avoids it use in other
parts of the code.
2009-08-13 15:35:07 +02:00
02228ee176
richedit: Use ME_Cursor instead of offsets for ME_CharFromPos.
2009-08-13 15:35:01 +02:00
a69ef26599
richedit: Use ME_Cursor instead of offsets for copying text.
2009-08-13 15:34:54 +02:00
60a72583f4
richedit: Use ME_Cursor instead of offsets for ME_UpdateLinkAttribute.
2009-08-13 15:34:47 +02:00
27c28ab292
richedit: Modified ME_MoveCursorsChars to move multiple chars.
...
Previously the function was only used to move a single character in
either direction, so I made the function more general so that it could
be used in more places.
2009-08-13 15:34:39 +02:00
326f9b3f3f
richedit: Fixed regression in ME_SetCharFormat.
...
Missed an assignment for end_run when the end cursor is provided and the
end position doesn't cause a split.
2009-08-13 11:45:13 +02:00
c92bb271b7
richedit: Use ME_Cursor instead of offsets for ME_GetTextRange.
2009-08-12 17:35:55 +02:00
2da0d8e933
richedit: Use ME_Cursor instead of offsets for ME_SetCharFormat.
...
The test that succeeded from this change was as a result of allowing the
end of the character format change be specified using NULL as the rest
of the text. Before, the end paragraph run at the end of the text was
not being set for this case, when all the text was supposed to have its
character format changed.
2009-08-12 17:35:50 +02:00
ade37203a5
richedit: Use ME_Cursor instead of offsets for ME_GetCharFormat.
...
Prevent extra conversions from character offset to ME_Cursor.
2009-08-12 17:35:42 +02:00
2bc726930f
richedit: Add helpers for setting cursor to start/end of text.
2009-08-12 17:35:30 +02:00
32dcd3bbe1
richedit: Created functions to move between runs and track paragraphs.
...
Plenty of places in the code find following or preceding runs, then
afterwards find the paragraph from the run. This is inefficient because
the same linked list is used for both runs and paragraphs, so changes in
paragraphs can be detected while returning the next or previous run.
2009-08-12 17:35:24 +02:00
Marcus Meissner