Commit Graph

73 Commits

Author SHA1 Message Date
Mark Jansen 145b410920 msi: Prevent uninitialized variable usage.
Observed with Lync 2010 setup in ReactOS. The embedded Silverlight
setup hits this case (no LASTUSEDSOURCE in the registry).

Signed-off-by: Mark Jansen <mark.jansen@reactos.org>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-02-18 16:00:53 +01:00
Hans Leidekker 6a3e79b002 msi/tests: Drop workarounds for Windows 2000.
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-09-26 16:53:10 +02:00
Hugh McMaster 11669fa5e2 Assorted spelling and grammar fixes.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-11-17 22:56:40 +09:00
Bernhard Übelacker a1dbf4d78b msi: Remove shortcut which calls RegEnumValueW with value and val_count as NULL. 2015-07-01 15:19:13 +09:00
Bernhard Übelacker db5f235a8b msi/tests: Test MsiSourceListEnumMediaDisks with volumeLabel and diskPrompt as NULL. 2015-07-01 15:19:09 +09:00
Michael Stefaniuc 481ff775ca msi: Simplify check for an empty string (PVS-Studio). 2014-11-05 19:37:10 +09:00
Francois Gouget 65bacd4b69 msi/tests: Avoid source test failures when running in an account with insufficient privileges. 2014-03-05 11:50:02 +01:00
Hans Leidekker 2a70f1bde3 msi/tests: Prepare source.c for the switch to -D__WINESRC__. 2013-10-15 14:28:21 +02:00
Hans Leidekker 419496d0c8 msi/tests: Allocate the user token dynamically and unify implementations. 2011-03-30 13:28:05 +02:00
Hans Leidekker 3d33fb93cc msi/tests: Determine Wow64 mode just once. 2010-10-11 17:11:26 +02:00
Hans Leidekker 21d09ffb43 msi/tests: Fix test failures on wow64. 2010-07-22 16:09:43 +02:00
Andrew Nguyen 93f92d51a4 msi/tests: Skip some source tests if a required product key cannot be created. 2010-07-09 11:41:11 +02:00
Andrew Nguyen 9c850c9f8a msi/tests: Fix a source test comment. 2010-07-09 11:41:00 +02:00
Andrew Nguyen abe900a23c msi/tests: Remove a redundant source test. 2010-07-09 11:40:56 +02:00
Andrew Nguyen ba180b8600 msi/tests: Free the user SID string buffer with the correct deallocator in the source tests. 2010-07-09 11:40:36 +02:00
Mikhail Maroukhine f930c87fd6 objbase.h: CLSIDFromString: Add constness to the parameters declaration in accordance with MSDN. 2010-03-29 12:11:02 +02:00
Hans Leidekker 3f70b07870 msi/tests: Fix a couple of user SID string leaks.
Found by valgrind.
2009-10-27 10:53:42 +01:00
Paul Vriens 44b53ef35e msi/tests: Fix test (logical || with non-zero constant). 2009-06-19 13:52:26 +02:00
Francois Gouget d9ffbe4e82 msi/tests: Use win_skip() to skip over unimplemented functionality. 2009-05-19 12:01:20 +02:00
Ge van Geldorp 215fd0b813 msi/tests: Handle running the tests as a domain user. 2009-04-07 14:21:25 +02:00
James Hawkins a7d5adc91f msi: Trace the username to help debug test failures on certain machines. 2009-02-26 12:14:13 +01:00
Ge van Geldorp 349d8bd1a1 msi/tests: Windows Installer 3.0 often returns ERROR_INVALID_PARAMETER. 2009-01-19 14:17:57 +01:00
Andrew Nguyen 6d75522fb4 msi/tests: Fix a few handle leaks.
This was pointed out by Christoph von Wittich.
2009-01-19 13:36:27 +01:00
Michael Stefaniuc 9975dcd19e msi/tests: Remove superfluous pointer casts. 2009-01-15 12:42:57 +01:00
Paul Vriens 2dfcb94211 msi/tests: Prevent a crash on NT4. 2008-09-15 11:23:42 +02:00
James Hawkins d880470dbf msi: Handle converting a value of REG_DWORD in MsiSourceListEnumMediaDisks. 2008-08-29 13:26:25 +02:00
Dan Kegel a302ec645c msi/tests: Initialize buffer lengths before calling MsiSourceListEnumMediaDisks. 2008-06-06 10:28:35 +02:00
Austin English 5644f05edf msi: Spelling fixes. 2008-04-08 12:25:13 +02:00
James Hawkins d69342cd67 msi: Initialize the size parameter. 2008-03-24 11:38:30 +01:00
James Hawkins e94b065df3 msi: Fix the type of the ID parameter of MsiSourceListEnumMediaDisks. 2008-03-20 14:27:35 +01:00
Francois Gouget 73f0b3c39b msi/tests: Skip the tests if we are unable to identify the user SID. This fixes crashes on Win9x. 2008-03-19 11:21:23 +01:00
James Hawkins 65f99ed91b msi: Test and fix MsiSourceListAddSource. 2008-03-13 11:36:24 +01:00
Paul Vriens ecf8c5af36 msi/tests: Skip tests for functions that are not available. 2008-02-27 14:52:24 +01:00
Paul Vriens e7937f3cd5 msi/tests: Make sure tests will run on Win9x and NT. 2008-02-27 14:52:24 +01:00
James Hawkins 7e8cd606a0 msi: Add tests for MsiSourceListEnumMediaDisks. 2008-02-26 11:19:45 +01:00
Paul Vriens 89c8e795d8 msi/tests: Make tests run on win9x/NT4 again. 2008-02-25 19:49:54 +01:00
James Hawkins 08172ad1c4 msi: Return the result of the call to OpenSourceKey. 2008-02-25 12:21:58 +01:00
James Hawkins 34d50c1e3e msi: Validate the parameters of MsiSourceListAddMediaDisk. 2008-02-25 12:21:51 +01:00
James Hawkins 1fced5cc1d msi: Add tests for MsiSourceListAddMediaDisk. 2008-02-25 12:21:42 +01:00
James Hawkins 8b540d2670 msi: Fix the INSTALLPROPERTY_LASTUSEDTYPE case. 2008-02-25 12:21:19 +01:00
James Hawkins 737dedfcbb msi: Fix the INSTALLPROPERTY_LASTUSEDSOURCE case. 2008-02-25 12:20:56 +01:00
James Hawkins d41cae07d5 msi: Factorize and fix the INSTALLPROPERTY_MEDIAPACKAGEPATH case. 2008-02-25 12:20:48 +01:00
James Hawkins 868de4d56b msi: Add more tests for MsiSourceListGetInfo. 2008-02-25 12:20:33 +01:00
James Hawkins e43eee8759 msi: Fix the INSTALLPROPERTY_LASTUSEDSOURCE case of MsiSourceListSetInfo. 2008-02-21 12:53:00 +01:00
James Hawkins 6c7339eea1 msi: Allow enumerating the sources without querying the source name. 2008-02-21 12:53:00 +01:00
James Hawkins 2d5ba8d20d msi: Implement MsiSourceListEnumSources. 2008-02-21 12:53:00 +01:00
James Hawkins 7cf6be8aeb msi: Return ERROR_INVALID_PARAMETER if the context is machine and szUserSid is non-NULL. 2008-02-19 13:39:25 +01:00
James Hawkins 4ee1745e81 msi: Validate the dwOptions parameter of MsiSourceListSetInfo. 2008-02-19 13:39:25 +01:00
James Hawkins 95ef6a1fbc msi: Simplify the MEDIAPACKAGEPATH and DISKPROMPT cases. 2008-02-19 13:39:25 +01:00
James Hawkins fe987103fb msi: Return the results from OpenSourceKey. 2008-02-19 13:39:25 +01:00