Commit Graph

84 Commits

Author SHA1 Message Date
Alexandre Julliard 5cb30bbf6e cabinet: Treat only -1 as an error from the FDICopy callback.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-12-15 18:48:55 +01:00
Michael Müller 67639e6ce7 cabinet: Set index of folder in FDICopy callback.
Signed-off-by: Michael Müller <michael@fds-team.de>
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-03-08 15:31:56 +01:00
Nikolay Sivov a6c47d7323 cabinet: Fix its vs it's typos.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-08-04 09:07:49 -05:00
Hugh McMaster 11669fa5e2 Assorted spelling and grammar fixes.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-11-17 22:56:40 +09:00
Vincent Povirk c97da4c944 cabinet: Accept hf == 0 in FDIIsCabinet. 2014-12-03 11:13:25 +01:00
Dmitry Timoshkov 3b8f4a280c cabinet: Remove a no longer valid comment about seeking and restoring CAB position. 2013-12-31 16:18:48 +01:00
Dmitry Timoshkov 4ddb9f6915 cabinet: Read CAB size from the file header instead of calling FDI seek callback with SEEK_END.
SEEK_END is not supported by some callback implementations.
2013-12-31 16:18:28 +01:00
Frédéric Delanoy fbcf83f79c cabinet: Use BOOL type where appropriate. 2013-10-04 12:46:29 +02:00
Andrew Talbot d03b13c534 cabinet: Avoid signed-unsigned integer comparisons. 2013-01-02 13:35:51 +01:00
Christian Costa 94bfd24f67 cabinet: Simplify concatenation of path and filename. 2012-11-28 20:14:43 +01:00
Christian Costa 8b6f917518 cabinet: Remove useless ERR and turn one ERR into a WARN. 2012-11-28 20:14:42 +01:00
Christian Costa db497bdc44 cabinet: Simplify concatenation of path and filename. 2012-11-23 18:06:06 +01:00
Jacek Caban 173dff4ccb cabinet: Improved debug traces. 2012-11-02 19:47:17 +01:00
Michael Stefaniuc f631780da4 cabinet: Avoid TRUE-FALSE conditional expressions. 2012-07-26 12:11:09 +02:00
Michael Stefaniuc b41c71e3ab cabinet: Simplify the "pointer to start of array" idiom. 2012-07-25 16:11:18 +02:00
Andrew Talbot 73e82bacc3 cabinet: Mark some fall-throughs in switch statements. 2011-09-26 18:12:50 +02:00
Frédéric Delanoy f932abf326 dlls: Assorted spelling fixes. 2011-08-01 18:26:27 +02:00
André Hentschel 9701621f0f cabinet: Be more verbose. 2011-03-29 12:20:17 +02:00
Paul Vriens 81f2a237f3 cabinet: Check correctly for the magic value (Coverity). 2011-03-14 12:18:14 +01:00
Alexandre Julliard 3dc669ffb5 cabinet: Fix the remaining todo_wine tests in fdi.c. 2011-02-19 13:05:57 +01:00
Alexandre Julliard 7a9b389465 cabinet: Move internal FDI definitions to fdi.c. 2011-02-04 15:25:31 +01:00
Alexandre Julliard 05702c146e cabinet: Call FDI function pointers explicitly instead of hiding them inside macros. 2011-02-04 15:25:31 +01:00
Alexandre Julliard 396c9fca21 cabinet: Pass an FDI pointer to internal functions instead of a handle. 2011-02-04 15:25:29 +01:00
Alexandre Julliard 826ccc1684 cabinet: Add a helper function to set error code in FDI. 2011-02-04 15:25:01 +01:00
Mikhail Maroukhine 09dca97fc3 cabinet: Fix compiler warning with flag -Wcast-qual. 2010-03-29 12:12:07 +02:00
Rob Shearman eae5b071c2 cabinet: Fix memory leaks on failure in FDICopy. 2009-12-14 16:14:39 +01:00
Marcus Meissner 87118d00fe cabinet: Fixed free_decompression_temps/_mem , handle NULL (Coverity). 2009-10-19 11:43:37 +02:00
Andrew Talbot 9ca199a87d cabinet: Constify a variable. 2009-05-26 14:25:12 +02:00
Andrew Talbot 9a079a64e6 cabinet: Declare a function static. 2009-02-09 12:22:49 +01:00
Andrew Talbot 61292cfc61 cabinet: Declare a function static. 2009-02-05 13:13:43 +01:00
Andrew Talbot 184dbe7e63 cabinet: Declare a function static. 2009-01-02 14:27:43 +01:00
Michael Stefaniuc e4db17f268 cabinet: Don't cast the return value of PF[CD]I_ALLOC; those are void pointers. 2009-01-02 11:53:48 +01:00
Alexandre Julliard 16fb8fd843 cabinet: Don't allocate a huge buffer on the stack. 2008-12-11 12:24:33 +01:00
Ricardo Filipe 1a12aace57 cabinet: Fix dead stores (llvm/clang). 2008-11-18 13:04:59 +01:00
Michael Stefaniuc bfe6fe678a cabinet: Do not cast NULL. 2008-11-03 13:38:43 +01:00
Rob Shearman 79ad9cbcdd cabinet: Check buffer size before copying in NONEfdi_decomp.
Check that the data will fit into the fixed sized buffer CAB(outbuf)
and return an error if not before copying.
2008-10-01 11:42:36 -05:00
Juan Lang c479ea631f cabinet: Use helper function to remove duplicate code. 2008-09-10 10:40:33 +02:00
Juan Lang 70cfa0c36e cabinet: Use helper function to remove duplicate code. 2008-09-10 10:40:27 +02:00
Alexandre Julliard c1add0ff51 cabinet: Always use INT_PTR for handles. 2008-06-18 20:48:54 +02:00
Dmitry Timoshkov 5ddd35f493 cabinet: Fix the regression caused by 4046075462. 2008-05-19 13:33:41 +02:00
Andrew Talbot 4046075462 cabinet: Remove order-of-evaluation dependencies. 2008-05-14 12:21:26 +02:00
Andrew Talbot 938150d01f cabinet: Indentation fix. 2008-05-05 13:34:05 +02:00
James Hawkins fe8c3f9059 cabinet: Revert "cabinet: Fix for FDICopy with an empty cabinet file.".
This reverts commit 33e561f53c.
Fixed the test that fails on all platforms.
2008-04-28 13:27:51 +02:00
Vitaly Perov 33e561f53c cabinet: Fix for FDICopy with an empty cabinet file. 2008-04-25 15:02:10 +02:00
Rob Shearman 903a486dc0 cabinet: Replace strcasecmp call with lstrcmpiA as strcasecmp isn't portable and doesn't take into account the current codepage. 2008-02-18 12:20:35 +01:00
Andrew Talbot 69599675a7 cabinet: Remove unneeded cast. 2007-12-31 17:41:09 +01:00
Andrew Talbot f2df3d7582 cabinet: Remove unneeded casts. 2007-12-06 12:07:36 +01:00
Andrew Talbot b3e56e9d0b cabinet: Remove unneeded casts. 2007-12-03 13:10:21 +01:00
Jeff Latimer 30892c8b8d cabinet: Remove unnecessary function. 2007-09-10 15:29:47 +02:00
James Hawkins 2918a272e3 cabinet: Return the value of GetLastError if FDICopy fails. 2007-08-24 11:26:48 +02:00