Commit Graph

209 Commits

Author SHA1 Message Date
Nikolay Sivov 48e7428964 comctl32/tab: Remove direct access to items array. 2009-03-30 15:07:47 +02:00
Nikolay Sivov 0e5dac618f comctl32/tab: Selected item should have TCIS_BUTTONPRESSED state. 2009-03-26 11:56:09 +01:00
Nikolay Sivov db60f69cba comctl32/tab: Handle state mask in TCM_[G,S]ETITEM. 2009-03-26 11:56:05 +01:00
Nikolay Sivov 751732e694 comctl32/tab: Draw tab button properly on TCIS_BUTTONPRESSED state. 2009-03-26 11:55:56 +01:00
Nikolay Sivov 92b0ad98e1 comctl32/tab: Implement TCM_[G,S]ETEXTENDEDSTYLE and TCS_EX_FLATSEPARATORS style. 2009-03-24 12:40:15 +01:00
Nikolay Sivov b896b92061 comctl32/tab: Fix button background filling on TCS_BUTTONS. 2009-03-24 12:39:17 +01:00
Nikolay Sivov 4585148547 comctl32/tab: Implement TCM_REMOVEIMAGE. 2009-03-24 12:38:37 +01:00
Gerald Pfeifer 2a7d98a52c comctl32: Simplify three TAB_ functions. 2009-03-02 13:59:51 +01:00
Aric Stewart 110a6048af comctl32/tab: Return default tab width in TCM_SETMINTABWIDTH if lParam is a negative value. 2008-12-03 11:37:58 +01:00
Lei Zhang 87ca1b9416 comctl32: Check for NULL input in TAB_AdjustRect. 2008-11-11 11:40:46 +01:00
Michael Stefaniuc d4b8948ce3 comctl32: Do not cast NULL. 2008-11-03 13:41:58 +01:00
Michael Stefaniuc b723e6f6b6 comctl32: Remove the superfluous casting of the LPVOID returned by Alloc(). 2008-10-24 14:24:59 +02:00
Detlef Riekenberg 2910b90c70 comctl32/tests: Fix tests to not depend on 96 dpi, make it pass in Wine. 2008-10-14 14:02:28 +02:00
Mikołaj Zalewski 60a1e20ba8 comctl32: Don't print ERRs for reflected messages. 2008-07-22 13:25:08 +02:00
Vitaliy Margolen 5c9fbb828d comctl32: tab: Fix drawing of the icons.
This patch partially reverts aa57ad37. It's not correct. The top/left
is added later on.
2008-05-06 11:25:19 +02:00
Lei Zhang 3980401231 comctl32: Use wine_dbgstr_rect() in traces. 2008-02-07 11:59:53 +01:00
Austin English c2a7914d1c comctl32: Spelling fixes. 2008-01-24 11:43:02 +01:00
Andrew Talbot 863ffb719b comctl32: Remove unneeded casts. 2008-01-02 12:38:41 +01:00
Lei Zhang f2519fdcda comctl32: Set tab focus correctly. 2007-10-30 11:31:38 +01:00
Lionel Debroux 58b743161b comctl32: Remove redundant NULL check before free (found by Smatch). 2007-10-22 12:36:08 +02:00
Aric Stewart 3822aa4b63 comctl32: TCM_SETCURSEL also updates the focus item. 2007-09-10 15:29:46 +02:00
Alexandre Julliard 0f63ad92cc comctl32: Remove useless pointer check. 2007-06-13 11:19:36 +02:00
Dmitry Timoshkov 3c9e7a7f33 wine: Switch to using 'long' for INT_PTR type for 64-bit compatibility. 2007-05-25 20:37:56 +02:00
Andrew Talbot 8366dd1703 comctl32: Constify some variables. 2007-04-03 11:21:17 +02:00
Hagop Hagopian 637a6116e2 comctl32: tab: Minor bug fixes in the curSel and curFocus getters and setters. 2007-03-19 12:16:41 +01:00
Felix Nawothnig 0f2f718dea comctl32: Layout and redraw on TCM_SETIMAGELIST. 2007-03-13 21:54:47 +01:00
Michael Stefaniuc 22ecd7aa67 comctl32: Remove redundant NULL checks before Free() (found by Smatch). 2007-03-08 11:58:04 +01:00
Felix Nawothnig 8784d47cba comctl32: Remove redundant NULL checks before Free() calls. 2007-02-14 12:22:39 +01:00
Felix Nawothnig 79e265accd comctl32: Remove unnecessary and misused mask member from TAB_ITEM. 2007-02-07 11:03:01 +01:00
Thomas Weidenmueller 2c620c8269 comctl32: Fix the TAB_ITEM_SIZE macro. 2007-02-05 12:25:16 +01:00
Oleg Krylov 32caf30f9c comctl32: Create tooltip windows with WS_POPUP style. 2006-10-25 20:21:34 +02:00
Alexandre Julliard 7cca856315 comctl32: Properly handle negative coordinates for mouse events. 2006-10-25 17:41:48 +02:00
Michael Ploujnikov 1c16d83379 comctl32: Win64 printf format warning fixes. 2006-10-14 20:17:06 +02:00
Francois Gouget 82babbee0b Add missing '\n's to Wine traces. 2006-10-05 17:46:48 +02:00
Jonathan Ernst 360a3f9142 Update the address of the Free Software Foundation. 2006-05-23 14:11:13 +02:00
James Hawkins aa57ad373d comctl32: A couple fixes for tab icon offsets.
- Shift selected icons up and non-selected icons down.
- Add the top or left draw rect to the vertical offset, because it may
  not be zero.
2006-03-23 20:20:33 +01:00
Tobias Loew 1911eed08e comctl32: Fix tab-control flickering. 2006-01-30 14:57:26 +01:00
Michael Kaufmann e9310da57b Handle WM_PRINTCLIENT.
Don't use SelectClipRgn in WM_PRINTCLIENT.
2005-11-08 12:52:35 +00:00
Dmitry Timoshkov 592a81ab22 Avoid printing out a possibly uninitialized variable. 2005-11-02 19:56:24 +00:00
Francois Gouget a1f9a13997 Use "static const" rather than "const static" as gcc -W complains
about the former.
2005-10-06 11:38:45 +00:00
Vitaliy Margolen 059a8c15f2 Don't arrange tabs if there is only one line. 2005-10-03 18:46:07 +00:00
Frank Richter 9e57091ffa Fix warnings in 64bit. 2005-08-30 10:07:17 +00:00
Mike McCormack 280bcf6e4a Fix gcc 4.0 warnings. 2005-08-27 10:00:38 +00:00
Vitaliy Margolen abd12e4dbf Fix handling of minimum tab width.
Add more tests to test it.
2005-08-23 10:05:54 +00:00
Aric Stewart bf129c41de Fix for dreamweaver site definition dialog. Need to initialize the
rect for a tab control to an empty rect if it is not visible.
2005-08-22 14:07:22 +00:00
Frank Richter b5940f7283 Fix text color for "button" style tabs when theming is enabled. 2005-08-11 18:35:00 +00:00
Frank Richter c952f08ba8 Add theming support for the tab control. 2005-07-28 10:14:52 +00:00
James Hawkins 645ec7d6e2 Audit the Tab control. 2005-06-06 10:03:03 +00:00
James Hawkins 4d639be88b - Factor out common text shifting logic.
- Shift selected tab text up instead of down.
2005-06-04 09:37:22 +00:00
James Hawkins 1aa7afeed9 Fixed centering of tab text. 2005-05-17 10:19:37 +00:00
Aric Stewart 8a0f989891 Handle WM_NCCALCSIZE in the tab control. 2005-05-12 09:57:10 +00:00
Vitaliy Margolen b58004d9ae Draw only visible tabs. 2005-04-13 14:40:12 +00:00
Dimitrie O. Paun 9da93dd879 Tab unicodification. 2005-04-11 14:21:15 +00:00
Francois Gouget 93416cdaf7 Assorted spelling fixes. 2005-03-23 13:15:18 +00:00
Jon Griffiths 3388eb0885 Remove unneeded calls to TAB_GetInfoPtr(), const fixes, inline small
funcs & remove unused parameters.
2005-02-25 16:19:07 +00:00
Eric Pouech cf1d00bb08 Removed excessive statement (break after return or goto, not useful
break, not needed vars...)
2005-01-09 16:42:53 +00:00
Vitaly Lipatov 6971e1d762 Add comments, fix negative value from GetCurFocus. 2005-01-03 20:12:42 +00:00
Alexandre Julliard ebe3c529b1 Janitorial: C booleans must not be compared against TRUE. 2004-12-09 14:07:59 +00:00
Thorsten Kani d93d3d5ada Use address of tab_item.extra when building drawitemstruct. 2004-10-26 00:22:31 +00:00
Jon Griffiths ef138f090e Items are variable sized, use an accessor to get at them.
Combine A/W calls together to remove duplication.
Don't leak text when removing/changing items.
Turn off hot tracking when we delete the last item.
Use the 'delete 1 item' logic when deleting all items.
2004-10-09 02:27:00 +00:00
Robert Shearman 62d60b9b39 - Set hbrBackground class property to same value as native.
- Remove no longer needed WM_ERASEBKGND handler.
- Use Unicode window functions instead of ANSI.
2004-09-14 00:44:26 +00:00
Hans Leidekker 411fc5f164 Fix signed/unsigned comparison warnings. 2004-09-02 23:00:53 +00:00
Robert Shearman cdb263e588 Replace GetWindowLong by GetWindowLongPtr. 2004-08-25 17:33:01 +00:00
Ulrich Czekalla 0d173d01a8 The rectangle passed in DRAWITEMSTRUCT is slightly too large as
compared with Windows.
2004-08-19 19:06:18 +00:00
Jon Griffiths 86a0e50a1d Don't crash on NULL tab text. 2004-07-16 02:30:48 +00:00
Jon Griffiths 438bf11a7d Implemented TCM_SETITEMEXTRA. 2004-06-04 18:11:03 +00:00
Vitaliy Margolen c03dabb2fe Adjust all dimensions to match native.
Invalidate whole tab area when multi-line.
In vertical tab placement go from top to bottom.
Fix annoying visual artifacts.
2004-03-02 04:52:35 +00:00
Vitaliy Margolen a6637ddb5d - Fix handling of TCS_RAGGEDRIGHT style.
- Clip UpDown control only if it is present.
- Add ToDos.
2004-02-07 01:02:03 +00:00
Francois Gouget 640cc3f3e1 Assorted spelling fixes. 2004-01-06 22:08:33 +00:00
Vitaliy Margolen 036dcf167e - Fix drawing of HotTracked tabs & buttons.
- More tab size fixes in different styles.
- Don't use new padding until style changes.
- Fix left alignment of labels &| icons.
- Don't draw over UpDown control.
- Fully erase tabs when scrolling.
- More tests.
2003-12-02 03:31:44 +00:00
Dimitrie O. Paun c594043316 Make the controls send notifications to the parent window passed to
them in CREATESTRUCT.  Based on a treeview patch by Igor Grahek.
2003-11-20 22:04:13 +00:00
Vitaliy Margolen 785bae8aae - Fix tab size for TCS_OWNERDRAWFIXED style.
- Correct size recalculation after setting tab width.
- Fix button sizes to match native.
- Center both vertically and horizontally tab text & icon.
- Use correct left/center alignment flags.
2003-10-31 00:06:42 +00:00
Maxime Bellengé ed3847247e Fix TAB_DeleteItem and TAB_DeleteAllItems regressions introduced by
the last TAB_InvalidateTabArea changes.
Correct the indentation for these functions.
2003-10-21 23:44:03 +00:00
Maxime Bellengé 8147ee1095 Only redraw the necessary area of the tab component and not the whole
component like windows does.
2003-10-14 20:12:05 +00:00
Vitaliy Margolen bd7bdbce3f Fix setting size of tab control. 2003-10-14 01:16:16 +00:00
Dimitrie O. Paun 7de279a73a Rename COMCTL32_{Alloc,ReAlloc,Free} to {Alloc,ReAlloc,Free}. 2003-09-22 21:32:33 +00:00
Alexandre Julliard cf52644a1c Removed the A/W constants for builtin cursors, icons and resource
types since they don't exist on Windows, and added typecasts
everywhere instead.
2003-09-10 03:56:47 +00:00
Alexandre Julliard e37c6e18d0 Fixed header dependencies to be fully compatible with the Windows
headers (with help from Dimitrie O. Paun).
2003-09-05 23:08:26 +00:00
Maxime Bellengé bcd1222650 Implemented TAB_SetMinTabWidth and TAB_HighlightItem. 2003-09-02 00:56:43 +00:00
Maxime Bellengé 0485fc19b6 Fix bounding rectangle computation for an ownerdraw tab. 2003-04-30 00:50:26 +00:00
Stephan BEUZE 8410e71fb5 Implemented message TCM_SETPADDING with the Dimitri's advice. 2003-04-27 20:34:30 +00:00
Mike Hearn c7b1874b54 Fix the tab height so the labels don't clip, and restore the offset
constant to what it was before.
2003-03-17 04:43:26 +00:00
Mike Hearn c6914b202a - Reduced tab offset constant slightly to avoid clipping the label.
- Prevent label overdraw of updown control by reducing the width of
  the invalidated region.
2003-03-12 20:14:12 +00:00
Mike Hearn 6b2d22a0f6 It's not just height that can be set to the default by passing zero to
TCM_SETITEMSIZE, but also width.
2003-03-10 19:04:13 +00:00
Vitaliy Margolen e6af4ec6bd Fix invisible tabs in TabControls with fixed tab width. 2003-03-04 04:34:03 +00:00
Dan Kegel 0fd521fee3 Change RECT to use LONG to match win32 standard headers and fix format
strings to use %ld for RECT elements.
2003-01-08 21:09:25 +00:00
Francois Gouget d2667a4ce3 Removed unnecessary HANDLE typecasts. 2002-12-02 18:10:57 +00:00
Michael Stefaniuc 353529b2c8 - fix the "int format, HANDLE arg" type of warnings for comctl32
- compile the comctl32 dll with -DSTRICT
2002-10-23 22:19:10 +00:00
Michael Stefaniuc 025c0b716b Prepare dlls/{comctl32,gdi,msvideo,setupapi,shell32,twain,winmm} for
the conversion of HWND to a void*.
2002-09-06 19:41:17 +00:00
Guy L. Albertelli 23739a339a Don't issue error message if message number in application range. 2002-07-16 01:23:59 +00:00
Guy L. Albertelli 533905e2ab - Add routines to dump out tab items internally and externally
- Adjust TAB_SetItemBounds to split vertical tabs more like the native.
- Document major difference in laying out the vertical tabs.
- Fix drawing of icons. Wrong item padding used in vertical case.
- Fixed size of horizontal padding.
2002-06-20 22:45:29 +00:00
Vincent Béron 9a62491660 Removed trailing whitespace. 2002-05-31 23:06:46 +00:00
Guy L. Albertelli dea6820b29 - Fixed drawing of borders to that of native (uses DrawEdge).
- Fixed drawing of separators to match the native.
- Fixed height of tabs and buttons to match native.
- Add/improved traces.
- Handle WM_SYSCOLORCHANGE message.
2002-05-29 00:32:02 +00:00
Alexandre Julliard 4344c368cb Got rid of GetSysColorPen. 2002-05-20 18:15:28 +00:00
Alexandre Julliard 0799c1a780 Added LGPL standard comment, and copyright notices where necessary.
Global replacement of debugtools.h by wine/debug.h.
2002-03-09 23:29:33 +00:00
Gerard Patel b3a3a8f3bc Forward tab notifications to the parent. 2001-12-24 20:24:58 +00:00
Nog f12e130fc2 Pass on all unhandeled messages to the owner. 2001-12-17 20:52:11 +00:00
Francois Gouget 070e749cfb Don't prefix %p with 0x.
Various English fixes.
2001-11-06 21:01:32 +00:00
Patrik Stridvall 3c0211f969 Cleanup code that is strange or difficult to parse. 2001-09-11 00:32:32 +00:00
Francois Gouget ee285b7ac8 Remove unnecessary single quoting of debugstr_xxx strings. 2001-05-11 20:03:40 +00:00