Commit Graph

2050 Commits

Author SHA1 Message Date
Daniel Lehman 9678045056 wininet: Always check if context can be deleted when freeing netconn.
Signed-off-by: Daniel Lehman <dlehman25@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-12-03 22:27:05 +01:00
André Hentschel 065ab77fc1 wininet/tests: Skip tests when querying INTERNET_OPTION_SECURITY_CERTIFICATE_STRUCT fails (newer win10).
Signed-off-by: André Hentschel <nerv@dawncrow.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-09-24 22:41:30 +02:00
Michael Stefaniuc b1a3b9e5ce wininet: Use the ARRAY_SIZE() macro.
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-09-20 19:44:17 +02:00
Michael Stefaniuc 717a17b24f wininet: Avoid an ARRAY_SIZE-like macro.
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-09-20 19:44:17 +02:00
Michael Müller bfe8510ec0 wininet: Resize buffer when call to InternetCanonicalizeUrlW fails in InternetCrackUrlW.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=40598
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-09-07 19:27:29 +02:00
Dmitry Timoshkov 24f3d50ccc wininet: Remove unused parameter from create_netconn().
Signed-off-by: Dmitry Timoshkov <dmitry@baikal.ru>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-09-07 19:27:22 +02:00
Alistair Leslie-Hughes 6552ddaaa5 wininet: Always copy the password even if blank.
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-20 19:36:08 +02:00
Michael Stefaniuc d870d4105d wininet: Use the more common ARRAY_SIZE spelling.
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-06 19:44:26 +02:00
Michael Stefaniuc 8d876e740e wininet/tests: Use the available ARRAY_SIZE() macro.
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-06-22 01:01:55 +02:00
Michael Stefaniuc 91c1fc2ff9 wininet/tests: Use the correct array size in a notification_data test.
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-06-21 11:18:35 +02:00
Jacek Caban 54b414b121 wininet: Simplify header string handling in HTTP_HttpSendRequestW.
Spotted by Mark Jansen, avoids potential double-free.

Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-06-11 16:51:19 +02:00
Jacek Caban 2bba45765b wininet: Add stub for INTERNET_OPTION_REFRESH.
Based on patch by Michael Müller.

Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-03 17:56:23 +02:00
Jacek Caban d9dd9023fd wininet: Allow INTERNET_OPTION_SETTINGS_CHANGED on all handle types.
Based on patch by Michael Müller.

Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-03 17:56:23 +02:00
Alistair Leslie-Hughes bb41feacd4 wininet: Add support for FormatMessage.
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-04-04 22:04:26 +02:00
Austin English c8861df6d1 wininet: Add ParseX509EncodedCertificateForListBoxEntry stub.
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-29 17:24:13 +02:00
André Hentschel be002fd92b wininet: Fix negated check for drain_content result (clang).
Introduced with 4f40039cd7

Signed-off-by: André Hentschel <nerv@dawncrow.de>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-28 23:39:20 +02:00
Piotr Caban ea0dae6db2 wininet: Fix https connections over proxy.
Successful CONNECT request switch to tunnel instead of having a message
body.

Signed-off-by: Piotr Caban <piotr@codeweavers.com>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-16 00:59:42 +01:00
Alexandre Julliard 105b3dc816 wininet/tests: Update the winehq.org certificate data.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-06 15:46:09 -06:00
Michael Stefaniuc a6a059f802 wininet: Use the global HeapAlloc() wrappers.
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-02-06 12:58:59 +01:00
Wei Xie 6d6dd78e5d wininet: Don't release connection too early.
Signed-off-by: Wei Xie <xiewei@linuxdeepin.com>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-01-19 16:40:55 +01:00
Wei Xie 3f06a09604 wininet/tests: Check null pointer in InternetGetSecurityInfoByURLW.
Signed-off-by: Wei xie <xiewei@linuxdeepin.com>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-01-09 16:03:50 +01:00
Alex Henrie 7b2ead8da0 wininet/tests: Fix off-by-one errors in HTTP tests (Coverity).
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-01-08 19:26:54 +01:00
Andrey Gusev dc9088b9eb wininet/tests: Fix resource leak.
Signed-off-by: Andrey Gusev <andrey.goosev@gmail.com>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-01-05 17:33:41 +01:00
Nikolay Sivov aeb4394299 wininet/tests: Fix some leaks (Coverity).
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-12-04 15:03:55 +01:00
Daniel Lehman b84ba52248 wininet: Use case-insensitive comparison for server name.
Signed-off-by: Daniel Lehman <dlehman@esri.com>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-11-29 21:30:02 +01:00
Alex Henrie 16226c44da wininet/tests: Skip cookie attributes tests on IE < 8.0.
INTERNET_COOKIE_HTTPONLY was introduced in IE 8.0.

Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-10-17 14:32:02 +02:00
Daniel Lehman 1b25de7d57 wininet: Fix proxy bypass with wildcard if domain length matches with server.
Signed-off-by: Daniel Lehman <dlehman@esri.com>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-08 16:23:15 +02:00
Alistair Leslie-Hughes 43deec95f6 wininet: Use standard wine_dbgstr_longlong.
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-08-25 12:47:14 +02:00
Jacek Caban e09155723b wininet/tests: Added more persistent connection tests.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-08-18 08:09:53 +09:00
Jacek Caban 085ce269b1 wininet: Drain content before reusing connection in open_http_connection.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-08-18 08:09:47 +09:00
Jacek Caban 59395d8845 wininet: Never do blocking reads in chunked_read if zero chunk size is aready read.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-08-18 08:09:44 +09:00
Jacek Caban 4f40039cd7 wininet: Release connection in HTTPREQ_Read only if remaining control data may be drainad without blocking.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-08-18 08:09:40 +09:00
Jacek Caban 8090d169ab wininet: Store error state separately from end of stream in chunked stream.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-08-18 08:09:36 +09:00
Jacek Caban 752d078a42 wininet: Always use drain_content specific to stream type.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-08-18 08:09:32 +09:00
Jacek Caban 90b936f0b2 wininet: Try to read reamaining data in chunked_drain_content.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-08-18 08:09:29 +09:00
Jacek Caban 2ecdac8846 wininet: Return error codes from HTTP streams.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-08-18 08:09:25 +09:00
Jacek Caban 7949a22b43 wininet: Correctly pass URL length to InternetCrackUrlW in get_redirect_url.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-08-08 20:13:57 +09:00
Jacek Caban a24b8267d5 wininet: Improved cookie debug traces.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-25 14:14:14 +02:00
Nikolay Sivov f55a116101 wininet: Fix potential use-after-free (Coverity).
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-10 20:51:11 +02:00
Jacek Caban 89f1d8c58a wininet: Fixed connection_pool_cs declaration.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-07 19:49:46 +02:00
Jacek Caban cee99826b6 wininet: Return an error on redirect with no host name specified.
Inspired by Michael Müller's patch.

Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-26 18:18:56 +02:00
Jacek Caban 61e28c01c6 wininet: Moved INTERNET_STATUS_REDIRECT notification to HTTP_HandleRedirect.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-26 18:18:54 +02:00
Jacek Caban 19cb65b156 wininet/tests: Fixed potential buffer overflow (coverity).
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-14 11:52:18 +02:00
Jacek Caban a0af1eba27 wininet/tests: Silence noisy traces.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-12 12:03:27 +02:00
Jacek Caban 23e78c01af wininet/tests: Added redirection tests using test server.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-31 21:33:37 +02:00
Jacek Caban 71ae1923d9 wininet/tests: Introduce open_socket_request helper.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-31 21:33:37 +02:00
Jacek Caban 74beb8236d wininet/tests: Create events once for all tests.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-31 21:33:37 +02:00
Jacek Caban 6d6c73863f wininet/tests: Added a helper for testing INTERNET_OPTION_URL.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-31 21:33:37 +02:00
Jacek Caban 9c959154f6 wininet: Correctly handle redirects to non-http URLs.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-31 20:51:47 +02:00
Akihiro Sagawa 05c23c95f8 wininet: Use isspaceW() instead of isspace() for WCHARs.
Found with Coccinelle.

Signed-off-by: Akihiro Sagawa <sagawa.aki@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-17 16:11:26 +02:00