198e0d5d78
shell32/tests: Trace the association properties for the DDE tests.
...
Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-26 23:17:57 +09:00
7e000abeda
shell32/tests: Call okShell() after a shell_execute{_ex}() test.
...
This ensures all the failed call parameters will be traced.
Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-26 23:17:24 +09:00
c133ef7326
shell32/tests: Trace the last ShellExecute command whenever a corresponding test fails.
...
okShell() serves to encapsulate handling of shell_call and also provides a means for further extensions.
Remove the shell_call static initialization to not hide potential
use-before-assignment compiler warnings.
Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-26 23:17:05 +09:00
09dac2f482
shell32/tests: Use the shell_execute{_ex}() call site for its traces and error messages.
...
This makes it easier to match their internal test failures with the site of the real test.
Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-19 21:44:15 +09:00
9cc07a2b31
shell32/tests: Trace the effective ShellExecuteEx() flags.
...
shell_execute_ex() adds some flags for its own internal needs. The
traces should reflect that.
Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-13 23:47:04 +09:00
f816bc93b0
shell32/tests: Tweak some overly optimistic ok() messages.
...
ShellExecute() is more likely to have returned an unexpected error code
than it is to have succeeded.
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-13 23:46:53 +09:00
3dff8bc213
shell32/tests: Fix the shortcut vs. class interaction test.
...
Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-12 19:10:04 +09:00
201de16e30
shell32/tests: Create_test_association() should either succeed or fail due to insufficient permissions.
...
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-12 19:10:04 +09:00
0a867de22d
shell32/tests: Check the hProcess field when ShellExecuteEx() fails.
...
Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-12 19:10:04 +09:00
2fb84d5c50
shell32/tests: The expectedArgs parameter of the DDE tests is an argument count, not a boolean.
...
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-12 19:10:03 +09:00
ccc6cfc1de
shell32/tests: Explicitly compare to HRESULT values.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-03 20:04:40 +01:00
2e4954eb69
shell32/tests: Basic tests for SHCreateSessionKey().
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-12-29 17:09:18 +01:00
2cff59ed5c
shell32: Minor cleanup of SHELL_execute (Clang).
...
Signed-off-by: André Hentschel <nerv@dawncrow.de>
Signed-off-by: Andrew Eikum <aeikum@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-12-22 20:18:56 +01:00
413c6f60cf
Assorted spelling fixes.
...
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-12-02 12:59:52 +09:00
3a6ac60555
shell32: Improved IDataObject::QueryGetData implementation.
...
Signed-off-by: Piotr Caban <piotr@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-11-25 01:28:32 +09:00
5cf9539650
shell32: Return as soon as requested CLSID is located (Coverity).
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-11-11 22:08:45 +09:00
aaafeb4cec
shell32: Implement IShellDispatch2::ShellExecute.
...
Signed-off-by: Andrew Eikum <aeikum@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-11-03 00:33:23 +09:00
4e88852415
shell32: Fix temporary item array leak (Valgrind).
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-10-29 21:20:07 +09:00
2fff77a0ee
shell32/tests: Fix prototype to match implementation (PVS-Studio).
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-10-21 21:09:13 +09:00
186bed3d16
shell32: Properly handle SHGetPathFromIDListW failure (PVS-Studio).
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-10-21 01:04:29 +09:00
4ee4c06410
shell32: Cleanup ReadCabinetState exports.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-10-21 00:25:35 +09:00
95ecc29a50
shell32: Remove another recurring return code check (PVS-Studio).
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-10-21 00:25:34 +09:00
e2275b0a2a
shell32: Remove recurring return value check (PVS-Studio).
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-10-19 12:22:39 +09:00
5853e7769c
shell32: Simplify conditional expression (PVS-Studio).
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-10-15 19:18:26 +09:00
972a74ddfe
shell32: Added dll manifest file.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
2015-10-01 16:33:28 +09:00
e585d17ff3
shell32/tests: Test icon ids that are invalid on all systems.
2015-09-16 22:11:09 +09:00
69d57ee72f
shell32: Do nothing if we can't convert PIDL to path in SHAddToRecentDocs.
2015-09-15 17:55:19 +09:00
637bcd5de9
shell32: Fix return type for helper functions of SHFileOption.
2015-09-01 21:11:16 +09:00
8657547d9e
shell32: Fix getting parent shell folder when it's the desktop folder.
...
BindToObject fails in this case.
2015-08-17 14:47:37 +09:00
642b2fe789
shell32: Use return value from IShellFolder_GetAttributesOf.
2015-08-17 14:47:30 +09:00
7ec5f555b0
shell32: Add a stub implementation of SHQueryUserNotificationState.
2015-08-06 21:42:30 +09:00
77b75ca14b
shell32: Don't hardcode icon sizes in SIC_LoadIcon.
2015-08-03 11:00:54 +02:00
e46c32ab46
shell32/ebrowser: Implement EBO_NOBORDER option.
2015-08-03 10:57:46 +02:00
118c469598
shell32/ebrowser: Use proper color for pane separator.
2015-08-03 10:57:37 +02:00
e7acfee978
shell32: Added GetCurrentProcessExplicitAppUserModelID() stub.
2015-07-22 16:42:42 +02:00
7d3f13a129
shell32: Ensure that commandline is null-terminated when no parameters are given.
2015-07-17 14:28:17 +09:00
943ead5022
shell32: Fix SHELL_execute code that removes quote arround file name.
2015-07-16 16:29:12 +09:00
663f9f4b21
shell32: Handle executable with space in path in SHELL_execute.
2015-07-16 16:29:09 +09:00
8e853a3e90
shell32: Remove code for separating arguments from file path.
2015-07-16 16:29:06 +09:00
0b9737b1ea
shell32: Fix threading model for the Known Folder Manager and Shell Link objects.
2015-07-08 16:02:23 +09:00
360cf273ae
shell32/tests: Test that shell view windows reference their shell view.
2015-07-07 16:52:21 +09:00
28caa68d41
shell32/tests: Try harder to close Open With window.
2015-07-07 16:52:20 +09:00
f5e16e0638
shell32/tests: Win 2k doesn't cope with spaces in the path.
2015-07-07 16:52:20 +09:00
c5053f5712
shell32/tests: Win XP splits the args if there are spaces in the path.
...
This isn't seen on winetest runs, but is when jobs are submitted to
the testbot. Presumably the path of the executable is different in
the two cases.
2015-07-07 16:52:19 +09:00
eff884f19b
shell32/tests: Destroy shell view windows.
2015-07-06 17:09:50 +09:00
71f1c90628
shell32/tests: Fix an ok() print.
2015-07-06 17:09:50 +09:00
69733d65e8
shell32: Handle string-to-guid conversion errors (Coverity).
2015-07-06 15:13:24 +09:00
9551179c0b
shell32/tests: Remove a misleading test.
2015-06-30 14:41:43 +09:00
e582495927
shell32: Use QueryInterface in FolderView_GetFolder.
...
test_IFolderView has a test that shows that the shell folder's reference
count before and after the call to IFolderView_GetFolder is the same.
However this is misleading because it is not a property of the
IFolderView_GetFolder method, but of the desktop shell folder object
that's used in the folder view. Windows <=2003 uses a cached object and
its AddRef/Release methods return constants.
2015-06-30 14:41:43 +09:00
c0cd954f98
shell32: Add missing parameter check in ISF_Desktop_fnQueryInterface.
2015-06-30 14:40:43 +09:00
Francois Gouget