Commit Graph

1530 Commits

Author SHA1 Message Date
Filip Navara 0e6c60076f - Don't use DrawEdge with NULL device context, it's invalid call and
sets last error.
- Tooltip icons must be destroyed with DestroyIcon and not with
  DeleteObject.
- Rebar cursors must be destroyed with DestroyCursor and not with
  DeleteObject.
2004-12-07 14:27:43 +00:00
Eric Kohl d267f993f9 DrawStatusText() must not process prefix characters. 2004-12-06 16:15:38 +00:00
Ulrich Czekalla 21970dc2f7 Prevent the animation thread from waiting on itself when it stops. 2004-12-01 15:27:18 +00:00
Dmitry Timoshkov 30bebfdc38 - Pass infoPtr around in month calendar control.
- Add support for WM_SETFONT and WM_GETFONT messages.
2004-11-30 17:35:16 +00:00
James Hawkins 88aeb475c0 Fixed a few memory leaks. 2004-11-30 17:33:27 +00:00
Robert Shearman d7dd3e37c8 Store the new style before redrawing and repositioning the control. 2004-11-30 17:28:10 +00:00
Alexandre Julliard a79c534c0e Avoid using the MAKEPOINTS macro, it's broken on big endian. 2004-11-24 18:28:31 +00:00
Huw Davies 3138b4a8fa The default font for the treeview should be the icon title font. 2004-11-21 15:41:08 +00:00
Zach Gorman 4b5a5868f1 Add the DT_NOPREFIX flag when calling DrawText() for single-line
listview controls.
2004-11-19 18:09:29 +00:00
Robert Shearman b98b7dd65d - Set cache bitmap dimensions correctly when a 0x0 image list is used.
- Optimize WM_STYLECHANGED handler to only redraw when a CCS_* style
  is changed, like native.
2004-11-10 01:30:47 +00:00
Dmitry Timoshkov 47361da574 - do not move updown control and buddy if an alignment was not requested
- in UDM_SETACCEL handler do not forget to update number of accelerators
- update arrows info in WM_LBUTTONDOWN as well as in WM_MOUSEMOVE
- use accelerators in WM_LBUTTONDOWN handler
2004-11-09 20:03:47 +00:00
Robert Shearman a9b1aa28b3 - bNtfUnicode is a dup' of bUnicode so remove it and fix the few
places where it was used.
- Remove a load of useless NULL infoPtr checks.
- Hardcode the default padding like native instead of using a wacky formula.
- Replace some tabs with spaces and remove NMHDR casts.
2004-11-08 22:17:02 +00:00
Dmitry Timoshkov 00176e33b3 Dimensions of month calendar control should not depend on the client
window size.
2004-11-08 20:27:02 +00:00
Robert Shearman 8d28e0314c Remove unnecessary WNDPROC casts. 2004-11-06 03:49:03 +00:00
Robert Shearman 75314f474f Implement TBN_RESTORE notification. 2004-11-06 03:45:38 +00:00
Dmitry Timoshkov d3eb0550f5 Convert NativeFont control to unicode, use hbrBackground as in native. 2004-11-01 21:08:10 +00:00
Dmitry Timoshkov 99a6afcd6c Do not retrieve infoPtr twice in ToolbarWindowProc entry. 2004-11-01 21:07:43 +00:00
Dimitrie O. Paun f07f08cfe6 Send notification messages in the format dictated by
infoPtr->notifyFormat.
2004-11-01 21:07:11 +00:00
Alexandre Julliard 7d716db7e7 Use correct type instead of void* in item linked list. 2004-10-27 21:37:02 +00:00
Dimitrie O. Paun c1996e9aeb Use typesafe signature where possible. 2004-10-27 21:16:27 +00:00
Dimitrie O. Paun 2bccfc4aa9 Rename STATUSWINDOWINFO to STATUS_INFO, for consistency with other
controls. Fix some prototypes. Always pass infoPtr around.
2004-10-27 21:16:17 +00:00
Dimitrie O. Paun bc88300968 Minor cleanups. 2004-10-27 21:16:03 +00:00
Dimitrie O. Paun 5873eb501e Use Unicode functions where possible. 2004-10-27 21:15:53 +00:00
Thorsten Kani d93d3d5ada Use address of tab_item.extra when building drawitemstruct. 2004-10-26 00:22:31 +00:00
Dimitrie O. Paun 63fe9d4490 Implement proper GWL_STYLE handling, proper reaction to style changes.
Merge {{Inc,Dec}rement,Reset{Up,Down}}Field into one method. Fix a
bunch of bugs in the process.  Implement DTM_[GS]ETMCFONT. Indentation
fixes, cleanups.
2004-10-26 00:11:31 +00:00
Dimitrie O. Paun 186b4b6843 Use only Unicode functions, it makes it easier to see we are fully
Unicode compliant.
2004-10-25 21:47:57 +00:00
Robert Shearman e0f1444d4e - Don't fill in any more information than native does for notifications.
- Store hit code in a signed integer so that we can see whether it is
  less than zero.
2004-10-25 21:45:14 +00:00
Robert Shearman acfd725df4 - Don't leak memory when an app sends TTM_SETTITLE twice.
- An lParam of 0 indicates that the title should be removed.
2004-10-25 21:44:50 +00:00
Francois Gouget 3bb5b093e8 Assorted spelling fixes. 2004-10-22 22:27:51 +00:00
Dimitrie O. Paun 6898ccbe65 Audit the Date Time Control. Unicodification.
Type safe functions (pass infoPtr and type safe values around).
Some cleanup and indentation fixes.
2004-10-22 19:52:08 +00:00
Uwe Bonnes 194bac7781 Monthcal_SetRange: Set proper value for min date. 2004-10-21 22:28:12 +00:00
Robert Shearman a4b013c9f2 Always remove WS_BORDER style from ComboBoxEx control. 2004-10-21 20:59:38 +00:00
Thorsten Kani c0a142ccee Don't add extra OFFSET_X/Y to the calculation of rcBitmap.top/left,
just use GetSystemMetrics.
2004-10-21 20:58:43 +00:00
Robert Shearman 5e6e9fb120 Correct the date of the completeness audit. 2004-10-21 19:56:32 +00:00
Dimitrie O. Paun 5d0366f5a0 Audit the month calendar. 2004-10-21 19:52:28 +00:00
Robert Shearman 18f0bf732d - Draw with ILD_TRANSPARENT instead of ILD_NORMAL to draw bitmaps from
the native shell image list properly (reported by Thorsten Kani).
- Rewrite TOOLBAR_NotifyFormat to avoid side-effects.
2004-10-21 19:52:16 +00:00
Robert Shearman 9cfb943561 Implement SetPathWordBreakProc and MirrorIcon. 2004-10-19 22:59:59 +00:00
Robert Shearman 5d0c01c4e0 Rebar completeness audit. 2004-10-19 22:59:14 +00:00
Ge van Geldorp 109f41aadc Pass correct uiParam for SPI_GETNONCLIENTMETRICS. 2004-10-19 21:09:42 +00:00
Ge van Geldorp 4e44eb2c9c Don't free subclass stack while it's still in use. 2004-10-18 23:14:38 +00:00
Robert Shearman a16223e302 - TBN_DELETINGBUTTON sends the command ID, not the index.
- Fill in tbButton structure for TBN_DELETINGBUTTON notification.
- Document TBN_QUERY* sending indices.
2004-10-18 19:39:22 +00:00
Robert Shearman 684197178a Implement ImageList_SetColorTable. 2004-10-18 19:36:13 +00:00
Gerald Pfeifer 8e85b37088 Completely disable unused function show_image(). 2004-10-14 00:34:47 +00:00
Jon Griffiths ef138f090e Items are variable sized, use an accessor to get at them.
Combine A/W calls together to remove duplication.
Don't leak text when removing/changing items.
Turn off hot tracking when we delete the last item.
Use the 'delete 1 item' logic when deleting all items.
2004-10-09 02:27:00 +00:00
Jon Griffiths ce0fbb5b28 ImageList_Merge should not fail if indices are bad.
Add tests for this case, a visible test mode and fix DrawIndirect test
under some native comctl32.dll's.
2004-10-07 17:34:56 +00:00
Jon Griffiths 0fa33cad49 Draw +/- correctly for large icon sizes. 2004-10-07 17:34:31 +00:00
Francois Gouget 486d020c1b Don't define COBJMACROS in objbase.h.
Update the Wine sources accordingly.
2004-10-07 03:06:48 +00:00
Francois Gouget 67aa858a31 Assorted spelling fixes. 2004-10-05 18:15:29 +00:00
Dmitry Timoshkov c6a51b4b4f If an animation is already playing do not restart it.
Remove WM_CLOSE handler, it leads to a memory corruption later on.
2004-10-04 20:40:12 +00:00
Aric Stewart 764ff272d6 Check to make sure PropSheetInfo* is not null before dereferencing it
for some windows messages.
2004-10-04 20:39:55 +00:00
Dmitry Timoshkov 5d460f2761 Do not use GlobalFree for a memory returned by LoadResource. 2004-10-04 19:29:29 +00:00
Vitaliy Margolen 477aa4501b Don't loose last band on insert. 2004-10-04 19:07:24 +00:00
Michael Stefaniuc fd306fb5d1 - native ImageList_Remove dosn't spit out an error message when
deleting an index out of range so don't do that either
- add 2 ImageList_Remove tests
2004-09-28 19:17:43 +00:00
Robert Shearman 847c81df89 Determine whether to do label edit before sending NM_CLICK. 2004-09-28 19:17:17 +00:00
Jon Griffiths f479f10660 Item height/expand button width must be >= than imagelist size.
Avoid a magic number, add FIXME for incorrect +/- drawing.
2004-09-28 02:35:48 +00:00
Robert Shearman ac5e454e2f - Implement WS_DISABLED style.
- Issue EN_CHANGE notification.
2004-09-25 00:30:08 +00:00
Robert Shearman 4790f82329 - Make the control look more like native by using the right font and
spacing.
- Use TextOutW rather than DrawTextW as we don't use any features of
  DrawTextW.
- Fix caret size and position.
- Implement WM_CHAR and WM_SYSCHAR messages.
2004-09-23 22:51:42 +00:00
Filip Navara 317d6c592a Fix obviously wrong condition in an "if" statement. 2004-09-23 22:51:29 +00:00
Filip Navara b6153a1165 Add note about unimplemented TB_SAVERESTORE message. 2004-09-23 22:51:14 +00:00
Dimitrie O. Paun 268f62f47d We now have ICC_LINK_CLASS. 2004-09-22 19:10:47 +00:00
Dimitrie O. Paun c26971c64c Cleanup W->A transition. 2004-09-22 19:10:27 +00:00
Robert Shearman 7cfe3c9ffc - Status update.
- Should create HOTKEY_INFO storage in WM_NCCREATE rather than in
  WM_CREATE so that we can also add the WS_EX_CLIENTEDGE style.
- Remove code that draws the client edge; it is already drawn by
  DefWindowProc.
2004-09-21 20:05:35 +00:00
Filip Navara 67c8cb28f9 - Implement PSM_INDEXTOID, PSM_INDEXTOPAGE and PSM_PAGETOINDEX messages.
- Partially implement the PSH_WIZARDCONTEXTHELP and PSH_NOCONTEXTHELP
  styles.
2004-09-20 19:13:36 +00:00
Robert Shearman 3c8fb21807 Document status of control against v6.0 of native version. 2004-09-20 19:10:43 +00:00
Robert Shearman 56b9d3c739 - Fix some TRACEs
- More A->W conversions missed by previous patch.
- Fix off-by-one error in validating drag-n-drop from available
  buttons list box to actual buttons list box.
- Unicode flag should be based on the notification window.
2004-09-20 19:10:05 +00:00
Robert Shearman f0509667e9 Use Unicode window messages. 2004-09-17 18:10:13 +00:00
Robert Shearman 6a4d392670 - Don't use TrackMouseEvents/WM_MOUSELEAVE API for handling the hot
button; use plain mouse capture instead like native.
- Return only HTTRANSPARENT/HTCLIENT from WM_NCHITTEST and remove
  associated hacks of WM_SETCURSOR, WM_NCLBUTTONDOWN and
  WM_NCLBUTTONUP.
- Refactor state change code so that state changes don't happen as
  side effects from messages such as WM_NCCALCSIZE, instead only from
  user input messages like WM_MOUSEMOVE.
2004-09-16 19:06:36 +00:00
Robert Shearman defcfc85db Use Unicode window messages. 2004-09-16 19:06:12 +00:00
Filip Navara 99423d4e48 Status update. 2004-09-14 01:06:44 +00:00
Robert Shearman d087c578b6 - Make customization list boxes into drag list boxes.
- Order available buttons in the same way as the native version.
2004-09-14 01:06:30 +00:00
Robert Shearman 3864956e7f - Clear data structure after dragging.
- WM_SETCURSOR does not need to be handled as it is not sent whilst
  the window is captured.
- Make uDragListMessage non-static so that we can re-use it
  elsewhere.
2004-09-14 01:06:11 +00:00
Robert Shearman b2499c9757 Set class hbrBackground and style to the same as native. 2004-09-14 00:45:26 +00:00
Robert Shearman 50c7fd4e85 - Set hbrBackground class property to same value as native.
- Use Unicode window functions instead of ANSI.
2004-09-14 00:44:38 +00:00
Robert Shearman 62d60b9b39 - Set hbrBackground class property to same value as native.
- Remove no longer needed WM_ERASEBKGND handler.
- Use Unicode window functions instead of ANSI.
2004-09-14 00:44:26 +00:00
Jon Griffiths 3772c73a6c CreateDCA -> CreateDCW 2004-09-13 23:22:30 +00:00
Filip Navara 043e27523d Fix resizing of wizards. 2004-09-13 23:19:51 +00:00
Vitaliy Margolen ba5d267b70 Make sure TreeView gets redrawn after calling EnsureVisible. 2004-09-13 19:17:35 +00:00
Filip Navara 8a8a66c328 Fill the area next to watermark bitmap with window color and subclass
exterior wizard pages to suppress drawing background.
2004-09-13 19:17:00 +00:00
Vitaliy Margolen 4cf764f503 Send correct tracing notification messages. 2004-09-13 18:05:02 +00:00
Filip Navara 4387895d86 Correct displaying of wizard subtitle. 2004-09-13 18:02:32 +00:00
Robert Shearman 8974541d6c - Status update.
- Remove no longer valid comment.
- Minor coding style cleanups.
2004-09-09 00:26:13 +00:00
Filip Navara 3b0aaea137 Do not distinguish exterior wizard pages by their position, but
instead expect that every page in wizard that doesn't have header is
exterior.
2004-09-08 21:47:03 +00:00
Robert Shearman 7bc76766cc Implement titles. 2004-09-07 20:43:44 +00:00
Robert Shearman e18a31eb4c Add 16x16 error, info and warning icons. 2004-09-07 20:43:30 +00:00
Filip Navara 32b23b3419 - Revert incorrect change to tab control resizing from revision 1.109.
- Move the property sheet resizing code from PROPSHEET_CreatePage to
  PROPSHEET_SetCurSel. It needs to be executed on every page change
  because the application can modify it during the notifications.
2004-09-07 20:28:14 +00:00
Filip Navara 002d91199a - Draw the Wizard97 header bitmaps before drawing the header strings.
- Center the header bitmap of the new Wizard97 correctly.
- Display the correct wizard title for any wizard type and do not
  change it for reqular property sheets.
2004-09-07 19:31:50 +00:00
Robert Shearman 8f870346cb - Obey TBCDRF_NOOFFSET for the button text.
- Make anchor highlighting behave more like native version.
- Don't recalculate toolbar in TOOLBAR_Unkwn460.
- Obey WM_SETREDRAW for the WM_ERASEBKGND message as well as
  WM_PAINT.
2004-09-06 21:26:25 +00:00
Kevin Koltzau c95959dc7f Fix bug with chained messages. 2004-09-06 20:26:04 +00:00
Hans Leidekker 411fc5f164 Fix signed/unsigned comparison warnings. 2004-09-02 23:00:53 +00:00
Ferenc Wagner e07e1ee547 Added \n to ok() strings in the imagelist tests. 2004-09-02 20:08:15 +00:00
Francois Gouget d661e1a2a9 MSVC does not like the typeof() in the function pointer declaration.
Fix a warning.
2004-08-31 17:32:43 +00:00
Filip Navara 335983ed91 Fix loading wizard title and subtitle from resources. 2004-08-30 18:39:32 +00:00
Robert Shearman 4d7892f886 TB_MARKITEM should redraw button. 2004-08-30 18:36:55 +00:00
Robert Shearman 0aa22f989b Allow image list tests to compile and run on old platforms. 2004-08-26 18:22:31 +00:00
Mike McCormack 8b424416bb Calculate the correct size of dialog templates in the propsheet
control.
2004-08-26 18:11:43 +00:00
Francois Gouget dff5004bc0 Assorted spelling fixes. 2004-08-26 00:31:20 +00:00
Robert Shearman cdb263e588 Replace GetWindowLong by GetWindowLongPtr. 2004-08-25 17:33:01 +00:00
Robert Shearman b18e158636 - Send NM_LDOWN notification.
- NM_RDBLCLK only needs to send a NMHDR structure.
- On mouse notifications returning 0 DefWndProc should be called.
2004-08-25 02:16:32 +00:00
Mike McCormack 99c83d4c57 Tests for icon and bitmap adding and removing and bitmap drawing with
image lists.
2004-08-24 18:41:52 +00:00
Robert Shearman f1ae41c7eb Fix regression with IE's Menu Bar. 2004-08-24 18:41:27 +00:00