Alexandre Julliard
3915cfbd02
comctl32/imagelist: Fix the allocated size of the has_alpha array.
2010-05-17 12:42:25 +02:00
Alexandre Julliard
45fd49bab6
comctl32/imagelist: Generate the mask from the alpha channel if present.
2010-05-16 18:23:04 +02:00
Alexandre Julliard
f2b993d414
comctl32/imagelist: Pre-multiply the colors by the alpha channel when storing an image with alpha.
2010-05-16 18:22:53 +02:00
Alexandre Julliard
91948f9ce8
comctl32: Always alpha blend images for 32-bpp imagelists.
2010-05-14 16:17:56 +02:00
Alexandre Julliard
33e7d0282b
comctl32: Store an alpha channel present flag for each image in an imagelist.
2010-05-14 16:17:56 +02:00
Alexandre Julliard
528722e4e1
comctl32: Also generate an alpha channel when replacing an image or icon in an imagelist.
2010-05-14 16:17:56 +02:00
Alexandre Julliard
f02adf3e2b
comctl32: Generate an alpha channel if necessary when adding images to a 32-bit imagelist.
2010-05-14 16:17:36 +02:00
Alexandre Julliard
f75c7b5f71
comctl32: Make ImageList_AddMasked call ImageList_Add instead of duplicating the functionality.
2010-05-14 13:37:04 +02:00
Gerald Pfeifer
29cc4c9193
comctl32/tests: Check for the outcome of the SendMessage calls in test_monthcal_size.
2010-05-14 11:04:24 +02:00
Gerald Pfeifer
00d5f87d30
comctl32: Remove document of (already removed) infoPtr from LISTVIEW_StyleChanged.
2010-05-13 11:51:19 +02:00
Gerald Pfeifer
b2ff743ccb
comctl32: Remove unused variable infoPtr from TVIEW_StyleChanging.
2010-05-12 18:48:11 +02:00
Huw Davies
c7a9e3a1b2
comctl32: Fix an hfont leak.
2010-05-11 17:44:25 +02:00
Gerald Pfeifer
47fff748cc
comctl32/tests: Remove variable hwndheader which is not really used from test_redraw.
2010-05-11 11:40:29 +02:00
Gerald Pfeifer
1bca01cbc1
comctl32: Remove unused parameter bEnable from LISTVIEW_Enable.
2010-05-11 11:09:51 +02:00
Gerald Pfeifer
0453154d99
comctl32: Remove unused parameter fwKeys from LISTVIEW_MouseHover.
2010-05-11 11:09:46 +02:00
Michael Stefaniuc
a712a29201
comctl32: Update some ImageList comments.
2010-05-11 11:06:16 +02:00
Alexandre Julliard
8ea1f3385a
comctl32: Apply the imagelist mask when alpha blending.
2010-05-10 18:20:20 +02:00
Gerald Pfeifer
3ff0890c11
comctl32/tests: Add tests for the return values of TreeView_SelectItem in test_select.
2010-05-10 10:11:52 +02:00
Nikolay Sivov
5eedf51df6
comctl32/rebar: Try to center child rectangle only if cyChild height is not zero.
2010-05-06 14:21:05 +02:00
Huw Davies
1af1784430
comctl32: Silence a few compiler warnings.
2010-05-05 17:59:41 +02:00
Sven Baars
fbd8722856
comctl32: Fix Dutch translation.
2010-05-05 17:49:04 +02:00
Alexandre Julliard
599531b7d9
comctl32: Add support for alpha blending in ImageList_DrawIndirect.
2010-05-05 12:47:24 +02:00
Gerald Pfeifer
34f9b1bc63
comctl32: Remove variable scrollRange which is not really used from PAGER_NCCalcSize.
2010-05-05 10:51:54 +02:00
Gerald Pfeifer
b021128c4b
comctl32/tests: Remove variables cx and cy which are not really used from test_approximate_viewrect.
2010-05-03 16:47:30 +02:00
Gerald Pfeifer
a2edb3c55c
comctl32/tests: Remove variable hwndheader which is not really used from test_items.
2010-05-03 15:42:41 +02:00
Gerald Pfeifer
44f1fbced4
comctl32: Remove variable old_focused which is not really used from MONTHCAL_Mouse.
2010-05-03 15:40:30 +02:00
Nikolay Sivov
d57247ce39
comctl32/listview: Rework item selection with letter keys, fix some glitches.
2010-04-27 15:44:34 -05:00
Gerald Pfeifer
414b506909
comctl32: Remove variable iRet which is not really used from test_EnumMRUList.
2010-04-26 06:59:47 -05:00
Gerald Pfeifer
8101a13eaf
comctl32: Remove variable old which is not really used from DATETIME_LButtonDown.
2010-04-26 06:59:37 -05:00
Nikolay Sivov
379cf46873
comctl32/listview: Don't change Z-order of edit window while resizing edit box.
2010-04-25 19:22:18 -05:00
Nikolay Sivov
1ccbadcf23
comctl32/listview: Remove forward declaration and unused parameter from edit box creation helper.
2010-04-25 07:34:49 -05:00
Nikolay Sivov
dd3fc17884
comctl32/listview: Add callback subitem on column insertion.
2010-04-22 18:11:42 +02:00
Alexandre Julliard
5d6e052926
comctl32: Fix handling of bitmap header size for V4/V5 bitmaps.
2010-04-21 14:56:37 +02:00
Nikolay Sivov
7d846eb19f
comctl32/listview: Properly handle subitem hittesting outside of horizontal columns bounds.
2010-04-21 11:57:32 +02:00
Gerald Pfeifer
aa745feddc
comctl32: Remove unused scrollInfo from LISTVIEW_MouseWheel.
2010-04-20 16:22:23 +02:00
Nikolay Sivov
7371d0d2fc
comctl32/listview: Exit early on LVM_CREATEDRAGIMAGE if null pointer passed for a point.
2010-04-20 16:21:37 +02:00
Dmitry Timoshkov
93437fc963
comctl32: Do not use width of the passed to ImageList_Add bitmap as an icon width.
2010-04-07 13:51:45 +02:00
Mikhail Maroukhine
6443d87543
comctl32: Fix compiler warnings.
2010-03-29 12:10:00 +02:00
Mikhail Maroukhine
3cad4a1d16
comctl32: Fix incorrect const type casting.
2010-03-29 12:09:28 +02:00
Mikhail Maroukhine
bd6f218165
comctl32: Fix compiler warnings with flag -Wcast-qual.
2010-03-26 10:32:33 +01:00
Michael Stefaniuc
0c2ec54535
comctl32/tests: Use the SendMessage instead of ListView_Scroll.
2010-03-26 10:29:52 +01:00
Mikhail Maroukhine
ad68792a14
comctl32/tests: Remove superfluous casts.
2010-03-25 09:45:06 +01:00
Francois Gouget
2659ac14f8
comctl32/tests: fix an ok() call's trailing '\n'.
2010-03-22 10:48:30 +01:00
Alexandre Julliard
bef5645eb1
makefiles: Remove the no longer needed explicit separators for dependencies.
2010-03-16 13:28:19 +01:00
Jeff Latimer
4f20455e4c
comctl32: cchTextMax needs to be set for LVS_OWNERDATA as it uses LVN_GETDISPINFO notifications.
2010-03-15 15:13:54 +01:00
Nikolay Sivov
b1b54ae39f
comctl32/datetime: Use user locale for format.
2010-03-15 14:18:06 +01:00
Dylan Smith
7617cc4bcc
comctl32/tests: Added scrolled listview test for LVM_GETSUBITEMRECT.
2010-03-03 11:52:28 +01:00
Dylan Smith
a7053ecc4c
comctl32/listview: Scrolling affects subitem rect.
2010-03-03 11:52:21 +01:00
Dylan Smith
3952da836a
comctl32/tests: Add NULL terminator to unicode string constant.
2010-03-03 11:52:07 +01:00
Nikolay Sivov
006362567b
comctl32/toolbar: Fix possible null pointer dereference.
2010-03-02 11:12:05 +01:00
Reece Dunn
78ce24d632
comctl32/mru: In EnumMRUListA, ensure that the string is NULL terminated and the correct size is returned.
2010-02-26 13:02:33 +01:00
Alexandre Julliard
2432b0f6b9
comctl32/tests: Fix broken check of the ok() macro return value.
...
Spotted by Yann Droneaud.
2010-02-24 16:04:18 +01:00
Dmitry Timoshkov
27e9b5bdb4
comctl32: Initialize item.mask before sending HDM_GETITEM message.
2010-02-22 12:08:33 +01:00
Alexandre Julliard
6164ce2d82
makefiles: Use the standard C_SRCS variable as the list of test files.
...
This enables it to be auto-updated by make_makefiles.
2010-02-22 10:47:11 +01:00
Dmitry Timoshkov
c1fd55d6c9
comctl32: Listview should accept both unicode and ansi notifications.
...
Listview receives notifications not only from built-in header control,
but also from custom or subclassed application controls, there is no
need to assert(0) on application input, printing a FIXME is the maximum
we can do on an unknown input.
2010-02-18 15:01:01 +01:00
Nikolay Sivov
70890031a3
comctl32/rebar: Don't try to access band data before it's needed.
2010-02-12 11:54:17 +01:00
Nikolay Sivov
057267d85e
comctl32/listview: Revert item width calculation to fix performance issues.
2010-02-08 17:49:47 +01:00
Nikolay Sivov
8c16c4030b
comctl32/updown: Use set acceleration value while processing keyboard keypresses.
2010-02-04 17:27:37 +01:00
Alexandre Julliard
9e47c59427
comctl32: Actually grow the array in DPA_Grow.
2010-01-29 13:30:00 +01:00
Michael Stefaniuc
223603cc1c
comctl32: Use IS_INTRESOURCE instead of HIWORD to check a resource.
2010-01-26 12:13:51 +01:00
Peter Dons Tychsen
a3528a7642
comctl32: Handle WM_NOTIFY correctly when the parent returns zero.
2010-01-22 13:09:01 +01:00
Jason Edmeades
81d8135424
comctl32/listview: Issue LVM_DELETEALLITEMS from WM_DESTROY.
2010-01-14 10:22:23 -06:00
Paul Vriens
9cf1af7cac
comctl32: Fix size parameter for memset (Coccinelle).
2010-01-11 11:34:18 -06:00
Marcin Baczyński
9e951e8d14
comctl32: Remove superfluous void* cast.
2010-01-07 17:59:57 +01:00
Nikolay Sivov
6ca7654ec7
comctl32/listview: Fix memory leak on subrange deletion.
2010-01-07 09:26:00 +01:00
Nikolay Sivov
acec38873f
comctl32/comboex: Fix a leak for text string stored for edit item.
2010-01-04 11:42:34 +01:00
André Hentschel
9d9c4061f9
comctl32: Improve German translation.
2010-01-04 11:41:28 +01:00
Gerald Pfeifer
8b73b131de
comctl32: Remove obsolete comment on RB_SETPALETTE from REBAR_WindowProc().
2009-12-28 14:22:28 +01:00
Michael Stefaniuc
9c15472a3b
comctl32: The return value of notify_with_scroll() is never used.
...
So don't bother returning something from that function.
2009-12-28 12:27:15 +01:00
Michael Stefaniuc
9dd502a332
comctl32: Remove some explicit LPARAM/WPARAM casts.
2009-12-28 12:27:14 +01:00
Michael Stefaniuc
92e4e63353
comctl32/tests: Remove some superfluous casts around SendMessage().
2009-12-28 12:27:14 +01:00
Nikolay Sivov
f897a91247
comctl32/updown: Fix formatting for hex mode.
2009-12-28 12:27:14 +01:00
Nikolay Sivov
46194d39f6
comctl32/rebar: Check for null handles before invalidation.
...
This prevents all windows invalidation.
2009-12-28 12:27:14 +01:00
Nikolay Sivov
2e1aa43ab1
comctl32/tests: Skip test on <5.8x systems.
2009-12-28 11:55:39 +01:00
Nikolay Sivov
02c06f0d66
comctl32/rebar: Avoid empty band range when changing layout.
2009-12-24 12:15:41 +01:00
Nikolay Sivov
6398448974
comctl32/comboex: Move debugging traces that require additional code into TRACE_ON() condition.
2009-12-24 12:15:41 +01:00
Nikolay Sivov
253edf0fbb
comctl32/comboex: Get rid of useless helper.
2009-12-24 12:15:41 +01:00
Nikolay Sivov
7d748b6ba0
comctl32/comboex: Don't invalidate all windows if Edit box isn't set up.
2009-12-24 12:15:41 +01:00
Nikolay Sivov
7deb277900
comctl32/comboex: Fix silly typo in CBEM_SETITEM handler (lParam wasn't set).
2009-12-24 12:15:41 +01:00
Nikolay Sivov
96d965f295
comctl32/comboex: Add test for internally sent Edit messages, remove corresponding comments.
2009-12-24 12:15:41 +01:00
Nikolay Sivov
ecc89bf6ef
comctl32/comboex: Use subclass chain for internally used controls.
2009-12-24 12:15:41 +01:00
Nikolay Sivov
7fa3778d8c
comctl32/rebar: Fix default just inserted band colors.
2009-12-23 14:27:30 +01:00
Nikolay Sivov
80ed866ff4
comctl32/tests: Explicitly create rebar for each test, cleanup main function a bit.
2009-12-23 14:27:30 +01:00
Nikolay Sivov
9ef90f480a
comctl32/updown: Don't change control z-order, this breaks auto buddy binding.
2009-12-23 14:27:30 +01:00
Nikolay Sivov
750ce6be35
comctl32/updown: Don't update buddy text if it's the same.
2009-12-23 14:27:30 +01:00
Paul Vriens
f0a35db253
comctl32/tests: Fix a test failure on older comctl32.
2009-12-22 15:40:00 +01:00
Nikolay Sivov
6cc141ff59
comctl32/updown: Simplify buddy subclassing using SetWindowSubclass chain.
2009-12-22 13:48:26 +01:00
Nikolay Sivov
705aee525a
comctl32/tests: Use win_skip() while skipping subclass tests.
2009-12-22 13:48:25 +01:00
Nikolay Sivov
48d42d4a93
comctl32/tests: Some tests for buddy procedure subclassing.
2009-12-22 13:48:25 +01:00
Nikolay Sivov
8fc96f20a3
comctl32/tests: Add ability to create any number of edit buddies.
2009-12-22 13:48:25 +01:00
Jason Edmeades
64bd51b1d3
comctl32/toolbar: Improve fixme message conditions.
2009-12-22 13:48:24 +01:00
Michael Stefaniuc
93d45253cd
comctl32/tests: Don't cast NULL to an integer type.
2009-12-21 15:01:24 +01:00
Nikolay Sivov
48efba00b6
comctl32/rebar: Don't read outside of bands array on dragging.
2009-12-21 15:01:24 +01:00
Nikolay Sivov
07fc19bbe3
comctl32/rebar: Collapse some parameter checks and winproc entries.
2009-12-21 15:01:24 +01:00
Nikolay Sivov
b6abcb2f86
comctl32/rebar: Move parameter cast to winproc.
2009-12-21 15:01:24 +01:00
Nikolay Sivov
1e74d5992c
comctl32/rebar: Use DPA to manage bands data.
2009-12-21 15:01:24 +01:00
Alexandre Julliard
6fd93a6c7e
comctl32: Use the module instance instead of that of the owner window for the toolbar configuration dialog.
2009-12-21 11:20:19 +01:00
Paul Vriens
fb1fada93a
comctl32/tests: Fix some test failures on older comctl32.
2009-12-15 11:44:56 +01:00
Nikolay Sivov
e81f2642f1
comctl32/treeview: Implement NM_SETCURSOR notification.
2009-12-14 12:04:05 +01:00
Nikolay Sivov
49dabfe31d
comctl32/treeview: Draw +/- signs with text color, not the lines' one.
...
+/- aren't affected by customdraw settings, only per control
set colors used.
2009-12-14 12:04:05 +01:00
Nikolay Sivov
b65a7a0052
comctl32/treeview: Fix default colors set on creation.
2009-12-14 12:04:05 +01:00
Nikolay Sivov
28d5410596
comctl32/treeview: Fix mouse tracking request code.
...
After query current tracking state passed parameters could be overwritten,
similar fix for Listview was recently committed.
2009-12-14 12:04:05 +01:00
Paul Vriens
1d0e02b63e
comctl32/tests: Fix a test failure on older comctl32.
2009-12-10 16:53:32 +01:00
Nikolay Sivov
83f2135e0d
comctl32/tests: Get rid of static handles, split tests finally.
2009-12-10 11:56:43 +01:00
Nikolay Sivov
6823e0f3ec
comctl32/treeview: Remove some forward declarations.
2009-12-10 11:56:35 +01:00
Nikolay Sivov
e3c34f2d29
comctl32/treeview: Use additional helper for item invalidation.
2009-12-10 11:56:23 +01:00
Kirill K. Smirnov
dc45e2c513
comctl32/treeview: Avoid a NULL pointer dereference.
2009-12-09 14:54:01 +01:00
Nikolay Sivov
c2a7535e9d
comctl32/listview: Update item width every time new item is inserted.
...
This prevents retaining previously stored width and unexpected item
displaying collapsing with ending ellipsis.
2009-12-09 14:25:21 +01:00
Nikolay Sivov
7d6412c82d
comctl32/datetime: Free internal data completely on control destruction.
2009-12-07 14:18:26 +01:00
Nikolay Sivov
bd8fc9c474
comctl32/tests: Don't forget to free array after tests.
2009-12-07 14:18:26 +01:00
Nikolay Sivov
0f003ef48d
comctl32/tests: Free imagelist after use.
2009-12-07 14:18:26 +01:00
Nikolay Sivov
6d989feff9
comctl32/treeview: Free items pointer array and root item on control destruction.
...
Two issues here: item pointers array wasn't freed, root item data wasn't freed.
Found by Valgrind.
2009-12-07 14:18:26 +01:00
Nikolay Sivov
eaee84f4db
comctl32/updown: Set width to default value on creation.
2009-12-03 14:02:54 +01:00
Nikolay Sivov
b2d89f4823
comctl32/updown: Specify all styles explicitly in tests.
2009-12-03 14:02:54 +01:00
Ilya Shpigor
fa92edfa48
comctl32: Implementation the WM_GETTEXT processing of datetime control.
2009-12-02 16:08:45 +01:00
Ilya Shpigor
e4e55ed8b4
comctl32: Test the WM_GETTEXT processing of datetime control.
2009-12-01 15:10:37 +01:00
Nikolay Sivov
1804941797
comctl32/treeview: Simplify WM_CHAR handler.
2009-12-01 13:14:11 +01:00
Nikolay Sivov
277c5139d2
comctl32/treeview: Clean up winproc a bit, move parameter check to handlers.
2009-12-01 13:14:06 +01:00
Michael Stefaniuc
4376ccf3fc
comctl32: Use FAILED instead of !SUCCEEDED.
2009-12-01 13:04:36 +01:00
Nikolay Sivov
d2e169fadd
comctl32/header: Avoid uninitialized memory passed to HDM_INSERTITEM, some fields are always copied.
2009-11-30 12:56:53 +01:00
Nikolay Sivov
1e1c1310f5
comctl32/listview: Get rid of duplicated helper in tests.
2009-11-30 12:56:47 +01:00
Nikolay Sivov
78e7b3cf9c
comctl32/listview: New hover value should be passed using LPARAM.
2009-11-30 12:56:30 +01:00
Nikolay Sivov
ea058d22ba
comctl32/listview: Add NM_HOVER notification.
2009-11-30 12:56:21 +01:00
Nikolay Sivov
5f191553e8
comctl32/listview: Make mouse hover work.
...
Event data was overwritten by TME_QUERY response.
2009-11-30 12:56:05 +01:00
Nikolay Sivov
8eb9e7ebd5
comctl32/listview: Draw LVIS_CUT items with white foreground color.
2009-11-30 12:55:50 +01:00
Nikolay Sivov
999810566b
comctl32/listview: Implement LVS_EX_HEADERINALLVIEWS.
2009-11-30 12:55:43 +01:00
Nikolay Sivov
dcd54f08fc
comctl32/listview: Get rid of helper used once.
2009-11-30 12:55:23 +01:00
Nikolay Sivov
a729e040e6
comctl32/listview: Further winproc simplification.
2009-11-30 12:55:12 +01:00
Nikolay Sivov
60f0f4e8ca
comctl32/listview: Call default procedure directly from handlers if such forwarding needed.
2009-11-30 12:55:00 +01:00
Nikolay Sivov
8d43bdd2ee
comctl32/listview: Remove parameter check from winproc for LVM_SETITEMPOSITION32.
2009-11-30 12:54:37 +01:00
Nikolay Sivov
62c610df3c
comctl32/listview: Collapse some handlers call in winproc.
2009-11-30 12:54:01 +01:00
Nikolay Sivov
fc43895f49
comctl32/listview: Default column width in LVS_LIST to better value.
2009-11-30 12:53:40 +01:00
Sergey Khodych
fa7c2b5c5f
comctl32/toolbar: Use proper button index when freeing a string in TOOLBAR_DeleteButton.
2009-11-23 13:09:25 +01:00
Nikolay Sivov
850ea2a711
comctl32/listview: Add support for LVFI_SUBSTRING.
2009-11-23 10:38:13 +01:00
Nikolay Sivov
b7b7b7113e
comctl32/listview: Fix find using partial string logic.
2009-11-23 10:38:00 +01:00
Nikolay Sivov
90c4abe86f
comctl32/listview: Add LVSIL_GROUPHEADER definition.
2009-11-23 10:37:44 +01:00
Nikolay Sivov
79c55c5dd1
comctl32/listview: Group control data members, there's no reasonable structure here.
2009-11-23 10:37:23 +01:00
Nikolay Sivov
899a53eda5
comctl32/listview: Send LVN_ENDLABELEDIT in any case, but with null text if it's the same.
2009-11-23 10:37:03 +01:00
Nikolay Sivov
f5f0763827
comctl32/listview: Don't forward WM_COMMAND (EN_KILLFOCUS) from Edit to parent window.
2009-11-23 10:36:51 +01:00
Nikolay Sivov
c39268967d
comctl32/listview: Do nothing on LVM_CANCELEDITLABEL if there's no label.
2009-11-23 10:36:41 +01:00
Nikolay Sivov
9cec74f300
comctl32/tab: Reset current selection on negative focus value.
2009-11-20 14:48:40 +01:00
Nikolay Sivov
33a1e827a7
comctl32/tab: Fix selection change when selected item is deleted.
2009-11-20 14:48:35 +01:00
Nikolay Sivov
336a68be54
comctl32/tab: Split tests to several functions not to depend from each other.
2009-11-20 14:48:31 +01:00
Nikolay Sivov
3371ba9f73
comctl32/tab: Fix reading out of array bounds on TCM_SETCURSEL.
2009-11-20 14:48:27 +01:00
Nikolay Sivov
c044fa8a59
comctl32/monthcal: Don't pass uninitialized data to MCM_SETTODAY, test isn't about this.
2009-11-19 16:16:52 +01:00
Nikolay Sivov
b0861921b2
comctl32/listview: Compare item text on insert depending on A/W message.
2009-11-19 14:24:31 +01:00
Paul Vriens
9e73769112
comctl32/tests: Fix some test failures on comctl32 4.70.
2009-11-19 12:29:30 +01:00
Owen Rudge
482c454e50
comctl32/tests: Fix imagelist v6 test failures on XP.
2009-11-19 11:48:51 +01:00
Owen Rudge
5ce3af5b37
comctl32/tests: Use SHIL_SYSSMALL instead of LARGE, and compare with system metrics.
...
This patch fixes a test failure if a user has a non-standard icon size
set. Windows 7, for instance, offers more variation than previous
versions of Windows in icon scaling. We should get the system icon
metric and compare our icon size against that.
2009-11-19 11:48:38 +01:00
Owen Rudge
459361d4d6
comctl32/tests: Use defined flags instead of magic numbers in v6 tests.
2009-11-17 15:14:53 +01:00