Commit Graph

276 Commits

Author SHA1 Message Date
Rémi Bernon ff0f5e4024 winspool.drv: Fix incorrect read of enumerated printer count.
This was changed from a unsigned int to a pointer in
e5d37832ee and this use was missed,
causing prefix creation hang if the allocated printers array is not
filled with zeros.

Signed-off-by: Rémi Bernon <rbernon@codeweavers.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-11-15 18:40:27 +01:00
Alexandre Julliard e5d37832ee winspool.drv: Implement Wow64 entry points in the Unix library.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-11-09 22:02:54 +01:00
Huw Davies e043d1d3af winspool: Use wide character string literals.
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-10-27 22:40:49 +02:00
Huw Davies 18697defa5 winspool: Add a helper to open various printer registry keys.
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-10-27 22:40:49 +02:00
Huw Davies da0db2eb79 winspool: Build with msvcrt.
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-10-27 22:40:49 +02:00
Huw Davies 8ecd220c8e winspool: Move the unix job schedulers to cups.c.
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-10-27 22:40:49 +02:00
Huw Davies a75c1aa78e winspool: Move the default page size query to cups.c.
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-10-26 18:31:13 +02:00
Huw Davies f519535879 winspool: Move ppd retrieval to cups.c.
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-10-26 18:31:07 +02:00
Huw Davies 5a163d5537 winspool: Move CUPS printer enumeration to cups.c.
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-10-26 18:30:57 +02:00
Huw Davies 9d8bf3bf96 winspool: Call the ppd retrieval function from add_printer_driver().
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-10-26 18:30:50 +02:00
Huw Davies e432c1cd30 winspool: Remove support for parsing /etc/printcap.
This is extremely obsolete and doesn't provide the location
of the ppd file anyway.

Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-10-26 18:30:31 +02:00
Huw Davies 4bb4d90c70 winspool: Move loading of libcups to cups.c.
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-10-26 18:30:10 +02:00
Esme Povirk 6e14766ad5 localspl: Choose print environment based on architecture.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=51815
Signed-off-by: Esme Povirk <esme@codeweavers.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-10-19 10:49:11 +02:00
Esme Povirk 0d05b01ce4 localspl: Add ARM print environments.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=51815
Signed-off-by: Esme Povirk <esme@codeweavers.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-10-19 10:49:08 +02:00
Jacek Caban 8eddb793a6 winspool: Use DocumentPropertiesW for DocumentPropertiesA.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-09-13 19:57:29 +02:00
Jacek Caban 68feb134af winspool: Use configuration file for DocumentPropertiesW.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-09-13 19:57:28 +02:00
Jacek Caban 7b28bb433d winspool: Use DeviceCapabilitiesW for DeviceCapabilitiesA.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-09-13 19:57:28 +02:00
Jacek Caban afc7c0c9d1 winspool: Use configuration file for DeviceCapabilitiesW.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-09-13 19:57:28 +02:00
Francois Gouget 182a8d8861 winspool.drv: Fix ASCII / ANSI mixups in comments and TRACE() messages.
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-08-25 18:29:04 +02:00
Huw Davies 0cddf6fe21 winspool: Forward EnumFormsA() to EnumFormsW().
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-05-19 17:05:02 +02:00
Huw Davies fc947eef19 winspool: Forward GetFormA() to GetFormW().
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-05-19 17:05:02 +02:00
Huw Davies bb51415904 localspl: Implement EnumForms().
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-05-19 17:05:02 +02:00
Huw Davies 7d4a7f8557 winspool: Forward the unicode forms functions to localspl.
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-05-19 16:58:26 +02:00
Owen Rudge 6b906e8237 winspool: Filter invalid characters when creating the PPD filename.
Fixes potential crash when trying to print if a CUPS printer name
contains an asterisk.

Signed-off-by: Owen Rudge <orudge@codeweavers.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-03-10 18:44:49 +01:00
Zebediah Figura 8337533675 winspool: Stop setting the PrinterPorts profile section.
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-07-24 10:17:27 +02:00
Zebediah Figura a5ef9295bc winspool: Stop modifying the "Devices" profile section.
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-07-23 22:30:48 +02:00
Zebediah Figura 0ab71192b8 winspool: Stop setting the "Devices" key.
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-07-23 22:30:48 +02:00
Zebediah Figura e8d254116e winspool: Remove the "force" parameter to WINSPOOL_SetDefaultPrinter().
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-07-23 22:30:48 +02:00
Vijay Kiran Kamuju 992a0ae7b9 winspool.drv: Implement AddPrintProcessorA via AddPrintProcessorW.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=26171
Signed-off-by: Vijay Kiran Kamuju <infyquest@gmail.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-06-03 21:46:11 +02:00
Alexandre Julliard 5016716f6e winspool: Use standard dlopen() instead of the libwine wrappers.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-04-07 14:26:20 +02:00
Dmitry Timoshkov bd7ba264b6 winspool: Implement IsValidDevmodeW.
Signed-off-by: Dmitry Timoshkov <dmitry@baikal.ru>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-10-16 13:58:19 +02:00
Dmitry Timoshkov df8c52cd91 winspool: Add support for level 1 printer info to GetPrinter.
Signed-off-by: Dmitry Timoshkov <dmitry@baikal.ru>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-09-30 11:47:21 +02:00
Alexandre Julliard 3d6febc997 include: Get rid of the DPRINTF() macro.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-04-08 19:34:44 +02:00
Piotr Caban 4c106a9319 winspool.drv: Don't use strcasecmp.
Signed-off-by: Piotr Caban <piotr@codeweavers.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-04-04 16:58:59 +02:00
Alexandre Julliard d4bc97c554 winspool.drv: Make cupsGetPPD optional to work around deprecation warning.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-12-14 18:24:46 +01:00
Alex Henrie 4761c367e0 winspool.drv: Make constant 'fmtW' static.
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-12-03 10:53:52 +01:00
Huw Davies 0c5ce58505 winspool: Skip the old printer check if it has a NULL port name.
Based on a patch by Alistair Leslie-Hughes.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=33502
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-11-22 23:55:58 +01:00
Michael Stefaniuc 18e2df401e winspool.drv: Use the ARRAY_SIZE() macro.
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-09-10 22:35:54 +02:00
Dmitry Timoshkov 4adfa3dc26 winspool: Add performance counters service stubs.
Signed-off-by: Dmitry Timoshkov <dmitry@baikal.ru>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-12 12:57:54 +02:00
Andrey Gusev b7987c6b32 winspool.drv: Avoid bitwise operation.
Signed-off-by: Andrey Gusev <andrey.goosev@gmail.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-10-09 19:51:22 +02:00
Nikolay Sivov 614ad0c8c2 winspool: Fix potential string buffer leaks (Coverity).
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-12-23 11:40:59 +01:00
Nikolay Sivov a3aad9d80f winspool: Initialize string pointers passed to StartDocDlgW() (Coverity).
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-12-23 11:40:57 +01:00
Detlef Riekenberg 7cba560ab2 winspool: Use all Fields from DRIVER_INFO_8A when we add a Printer Driver.
Signed-off-by: Detlef Riekenberg <wine.dev@web.de>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-11-28 13:54:51 +01:00
Detlef Riekenberg b611acc736 winspool: Return a failure code in ClosePrinter.
Signed-off-by: Detlef Riekenberg <wine.dev@web.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-11-02 17:02:36 +01:00
Detlef Riekenberg 686cfe3aaf winspool: Add our driver for all usable Printer environments.
Signed-off-by: Detlef Riekenberg <wine.dev@web.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-10-20 16:26:26 -07:00
Ken Thomases 10065d2acd winspool.drv: Include <cups/ppd.h> to fix building against the macOS 10.12 SDK.
The cupsGetPPD() function was moved there from <cups/cups.h> because it's
deprecated.

Signed-off-by: Ken Thomases <ken@codeweavers.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-06 15:31:43 +09:00
André Hentschel 88c77da35d winspool: Implement SetPrinterW for level 8.
Signed-off-by: André Hentschel <nerv@dawncrow.de>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-03 10:11:24 +09:00
Jeremy White 71f018cba5 winspool.drv: If the call to cupsPrintFile fails, print the cups error message.
Signed-off-by: Jeremy White <jwhite@codeweavers.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-29 16:38:51 +09:00
Austin English 110b53affc winspool.drv: Add EnumPrinterKeyA/W stubs.
Signed-off-by: Austin English <austinenglish@gmail.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-22 01:26:15 +09:00
Francois Gouget 413c6f60cf Assorted spelling fixes.
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-12-02 12:59:52 +09:00