Rob Shearman
13e47d762a
rpcrt4: Set the memory pointer in NdrBaseTypeUnmarshall to the buffer if we're unmarshalling on a server without memory being passed in.
2007-12-05 13:49:08 +01:00
Rob Shearman
17132f7e1f
rpcrt4: Set fMustAlloc to TRUE when unmarshalling an object pointer.
2007-12-05 13:48:59 +01:00
Rob Shearman
c866b06806
rpcrt4: Add tests for a pointer to a conformant strings.
2007-12-04 18:18:03 +01:00
Rob Shearman
2a9fae7565
rpcrt4: Set the destination pointer in PointerUnmarshall before calling the referenced type's unmarshalling routine.
...
When a pointer that is dereferenced is encountered then this can result
in a stale pointer (i.e. the one that is marshalled into the buffer for
the embedded pointer unmarshalling case) being used instead of the one
that was intended.
2007-12-04 18:18:01 +01:00
Rob Shearman
a016d7b335
rpcrt4: Handle all non-continuable exceptions in CStdStubBuffer_Invoke.
2007-12-04 13:33:10 +01:00
Rob Shearman
6dcc3fe62e
rpcrt4: Put the delegating stub thunks in an executable memory page, rather than on the heap.
2007-12-04 13:32:41 +01:00
Rob Shearman
341208bf1b
rpcrt4: Call IRpcChannelBuffer_GetDestCtx in NdrStubInitialize, just like we do in NdrProxyInitialize.
2007-12-04 13:32:29 +01:00
Rob Shearman
f191f59ee4
rpcrt4: Flesh out more of the IRpcChannelBuffer vtable to make the test_delegating_Invoke test succeed on Windows.
2007-12-04 13:31:59 +01:00
Rob Shearman
620fca405d
rpcrt4: Test that the string retrieved from get_name was actually unmarshalled correctly.
2007-12-03 13:10:21 +01:00
Rob Shearman
d8e467b0fd
rpcrt4: Reverse the conditions for which *pPointer is assigned base_ptr_val in PointerUnmarshall.
...
In one condition (fMustAlloc == TRUE), base_ptr_val may be uninitialised
and so cause a valgrind warning. Reversing the check is harmless and
doesn't result in a performance decrease.
2007-12-03 13:10:21 +01:00
Rob Shearman
eef207e3f1
rpcrt4: Initialise the memory in test_simple_struct_marshal before passing it to NdrSimpleStructUnmarshall.
...
Otherwise, the unmarshalling code will read from unintialised memory
when trying to reuse the embedded pointers in the memory block.
Also fix a couple of memory leaks.
2007-12-03 13:10:21 +01:00
Rob Shearman
c735a14788
rpcrt4: Fix NdrSimpleStructUnmarshall to cope with [in, out] embedded pointers.
2007-11-30 11:56:30 +01:00
Rob Shearman
b676309db3
rpcrt4: Improve PointerUnmarshall to cope with keeping the non-NULL source pointer of a client unmarshall.
...
This will enable various types with embedded pointers to handle [in,out]
parameters correctly by keeping the existing memory.
2007-11-30 11:56:21 +01:00
Rob Shearman
4e8f69ac2d
rpcrt4: Move forcing of fMustAlloc to NULL to the callers of EmbeddedPointerUnmarshall.
...
This will enable them to be individually fixed up to use memory if it
was provided by the caller.
2007-11-30 11:56:11 +01:00
Rob Shearman
43e0c67fe2
rpcrt4: EmbeddedPointerUnmarshall doesn't need to change the address of the allocated memory, so reduce the level of indirection of the memory parameter by one.
2007-11-30 11:56:04 +01:00
Rob Shearman
34522de870
rpcrt4: Errors in sending or receiving packets should result in RPC_S_CALL_FAILED being returned, not RPC_S_PROTOCOL_ERROR.
2007-11-30 11:55:50 +01:00
Rob Shearman
8668369b4f
rpcrt4: Fix an integer overflow in NdrConformantStructMarshall and NdrConformantStructUnmarshall.
2007-11-29 13:31:05 +01:00
Rob Shearman
074898ba2b
rpcrt4: Fix some more potential buffer overflows.
2007-11-29 13:30:58 +01:00
Rob Shearman
5a3c34eb89
rpcrt4: Check there is enough space in the buffer and that the size doesn't cause an overflow when copying data to it.
2007-11-29 13:30:21 +01:00
Rob Shearman
d0223ecc0e
rpcrt4: Check for integer overflows when increasing the buffer length.
...
Rename safe_buffer_copy to safe_copy_from_buffer.
2007-11-29 13:30:04 +01:00
Rob Shearman
4171309731
rpcrt4: Fix the tests for up_enum16.
...
It is different to the other base types as it has a different size on
the wire to in memory, so it can't just be set to the buffer when
unmarshalling.
2007-11-27 16:42:17 +01:00
Michael Stefaniuc
61ed0c99e6
rpcrt4: socket() returns -1 on error so check the return value against that.
2007-11-27 12:29:45 +01:00
Rob Shearman
046f24a0e7
rpcrt4: Raise an exception if a NULL ref-pointer is passed in to PointerMarshall or PointerBufferSize.
2007-11-21 12:03:35 +01:00
Rob Shearman
8a15423ab7
rpcrt4: Hold the thread-data's critical section while cancelling a call.
...
Check that there is a connection before trying to cancel it.
2007-11-19 13:53:22 +01:00
Francois Gouget
4fddc5e726
rpcrt4: Add some missing prototypes and better match the PSDK types.
2007-11-13 23:28:06 +01:00
Rob Shearman
3634dc1b1c
rpcrt4: Fix a copy and paste mistake in declaring threaddata_cs_debug.
...
Reported by Hans Leidekker.
2007-11-13 23:28:05 +01:00
Francois Gouget
b6ad7b5ef7
rpcrt4: Add an API documentation stub to make winapi_check happy.
2007-11-13 13:37:24 +01:00
Rob Shearman
a51486c657
rpcrt4: Implement RpcCancelThread for the ncacn_ip_tcp protocol sequence.
2007-11-13 13:34:50 +01:00
Rob Shearman
7ad36eabfc
rpcrt4: Add stubs for RpcMgmtSetCancelTimeout and RpcCancelThread.
2007-11-07 11:57:25 +01:00
Rob Shearman
ebe885d782
rpcrt4: Add a stub for RpcErrorStartEnumeration.
2007-11-07 11:57:20 +01:00
Dan Hipschman
a0ac63961d
widl: Don't rely on type_memsize to return 0 for all conformant arrays.
2007-11-06 13:02:56 +01:00
Rob Shearman
04dc115b54
rpcrt4: Handle FC_IGNORE in the base type functions.
2007-11-05 15:06:06 +01:00
Dan Hipschman
8d15820f79
widl: Handle pointers to conformant arrays (e.g., "[size_is(, n)] int **p; ").
2007-11-05 13:24:37 +01:00
Dan Hipschman
8caa325eb7
rpcrt4: Initialize allocated pointers to NULL in PointerUnmarshall.
...
This patch initializes allocated pointers in PointerUnmarshall since later
code checks the value for NULL (specifically, NdrConformantArrayUnmarshall).
2007-11-05 13:24:36 +01:00
Dan Hipschman
eaffc0a0da
rpcrt4/tests: Initialize memory in the get_name test.
...
This initializes the memory for an [in] parameter.
2007-11-05 13:24:36 +01:00
Rob Shearman
c4a1a081a9
rpcrt4: Factorise out the argument processing from NdrStubCall2 into two functions.
2007-11-05 13:24:36 +01:00
Rob Shearman
83bc80ada0
rpcrt4: Move some type definitions from ndr_stubless.c to ndr_stubless.h.
2007-11-05 13:24:36 +01:00
Rob Shearman
3eac5b4e59
rpcrt4: Add a small bit of documentation as to what NdrStubCall2 does.
2007-11-05 13:24:36 +01:00
Rob Shearman
18c16a8027
rpcrt4: Add a test for the pointers in [in,out] pointer structs not changing when the pointers aren't NULL.
2007-11-02 12:37:35 +01:00
Gerald Pfeifer
826a6d09d4
rpcrt4: Initialize variable to avoid compiler warning.
2007-10-25 12:48:01 +02:00
Dan Hipschman
ff8930f2bf
widl: Fix problems with variable-size user types.
2007-10-22 13:47:56 +02:00
Dan Hipschman
1d0f9378bc
widl: Detect conformant arrays of user types correctly.
2007-10-18 12:09:23 +02:00
Dan Hipschman
e219087c65
rpcrt4/tests: Free memory from one of the tests.
2007-10-15 16:55:31 +02:00
Dan Hipschman
acfde97b9e
rpcrt4, widl: Make pointer layouts compatible with windows; fix conformant array tests.
2007-10-11 16:24:28 +02:00
Dan Hipschman
d00ff2ed58
widl: Make structs containing user types bogus; fix square_test_us test failure.
2007-10-09 11:39:26 +02:00
Dan Hipschman
e0b209815d
rpcrt4/tests: Make server.idl compatible with MIDL.
2007-10-09 11:39:21 +02:00
Alexandre Julliard
b7df430831
rpcrt4/tests: Remove static keywords that hide test failures.
2007-09-27 20:13:21 +02:00
Dan Hipschman
723c8bacfa
widl: Fix string codes in pointer descriptions.
2007-09-27 10:09:38 +02:00
Dan Hipschman
347f2a2da2
widl: Fix top-level conformant arrays with pointer attributes.
2007-09-27 10:09:32 +02:00
Dan Hipschman
767a1f26f6
widl: Handle top-level conformance for complex arrays.
2007-09-20 14:27:29 +02:00