Commit Graph

152 Commits

Author SHA1 Message Date
Andrew Talbot 2db311a843 comctl32: Dangling pointers fix. 2008-04-28 14:32:17 +02:00
Andrew Talbot bab7871cac comctl32: Remove unused variables. 2008-04-14 12:09:13 +02:00
Andrew Talbot 8d555e825b comctl32: Assign to structs instead of using memcpy. 2008-02-12 23:00:03 +01:00
Lei Zhang 3980401231 comctl32: Use wine_dbgstr_rect() in traces. 2008-02-07 11:59:53 +01:00
Rob Shearman 0d44f6f070 comctl32: Forward the WM_GETTEXTLENGTH message from ComboEx controls to its edit control. 2007-11-20 12:28:59 +01:00
Thomas Weidenmueller 05a9678d20 comctl32: Fix handling of CB_RESETCONTENT in ComboBoxEx. 2007-11-19 12:55:19 +01:00
Rob Shearman 266a5a9d23 comctl32: Don't set the focus to the text box when the ComboBoxEx receives a CBN_SELENDCANCEL notification. 2007-10-25 12:14:26 +02:00
Dmitry Timoshkov 3c9e7a7f33 wine: Switch to using 'long' for INT_PTR type for 64-bit compatibility. 2007-05-25 20:37:56 +02:00
Andrew Talbot f76d076f8e comctl32: Constify some variables. 2007-03-22 11:28:03 +01:00
Andrew Talbot 74ab88ca97 comctl32: Replace inline static with static inline. 2007-03-17 20:03:19 +01:00
Michael Stefaniuc 22ecd7aa67 comctl32: Remove redundant NULL checks before Free() (found by Smatch). 2007-03-08 11:58:04 +01:00
Samuel Lidén Borell 0ee7264c37 comctl32: Use mask value in COMBOEX_GetItemA too. 2007-02-26 14:39:10 +01:00
Felix Nawothnig 8784d47cba comctl32: Remove redundant NULL checks before Free() calls. 2007-02-14 12:22:39 +01:00
Michael Ploujnikov 1c16d83379 comctl32: Win64 printf format warning fixes. 2006-10-14 20:17:06 +02:00
Mike McCormack 1207e84af5 comctl32: Return the correct value for CB_GETLBTEXTLEN. 2006-10-06 12:54:38 +02:00
Jonathan Ernst 360a3f9142 Update the address of the Free Software Foundation. 2006-05-23 14:11:13 +02:00
Francois Gouget 0edbaf7e80 Remove spaces before '\n' in traces. 2005-11-10 12:14:56 +00:00
Jason Edmeades a18b7baa87 Fix some off by one calculations in the comboboxex functions, and
handle an out of range positive index the same as windows + unit test
case.
2005-09-21 09:41:44 +00:00
Frank Richter 9e57091ffa Fix warnings in 64bit. 2005-08-30 10:07:17 +00:00
Felix Nawothnig 2fcd42aac2 Set iItem to index before notifying callback items. 2005-05-04 10:37:17 +00:00
Francois Gouget 93416cdaf7 Assorted spelling fixes. 2005-03-23 13:15:18 +00:00
Dimitrie O. Paun dcd3fde210 Complete unicodification. 2005-03-21 10:30:33 +00:00
Eric Pouech cf1d00bb08 Removed excessive statement (break after return or goto, not useful
break, not needed vars...)
2005-01-09 16:42:53 +00:00
Alexandre Julliard a79c534c0e Avoid using the MAKEPOINTS macro, it's broken on big endian. 2004-11-24 18:28:31 +00:00
Robert Shearman 8d28e0314c Remove unnecessary WNDPROC casts. 2004-11-06 03:49:03 +00:00
Alexandre Julliard 7d716db7e7 Use correct type instead of void* in item linked list. 2004-10-27 21:37:02 +00:00
Dimitrie O. Paun bc88300968 Minor cleanups. 2004-10-27 21:16:03 +00:00
Robert Shearman a4b013c9f2 Always remove WS_BORDER style from ComboBoxEx control. 2004-10-21 20:59:38 +00:00
Robert Shearman 9cfb943561 Implement SetPathWordBreakProc and MirrorIcon. 2004-10-19 22:59:59 +00:00
Hans Leidekker 411fc5f164 Fix signed/unsigned comparison warnings. 2004-09-02 23:00:53 +00:00
Robert Shearman cdb263e588 Replace GetWindowLong by GetWindowLongPtr. 2004-08-25 17:33:01 +00:00
Ulrich Czekalla 12d61c1db6 Forward focus to combobox, otherwise edit control won't get focus. 2004-08-19 19:09:15 +00:00
Francois Gouget 52c0832161 Make Unicode strings static const. 2004-04-20 01:12:17 +00:00
Robert Shearman 3c6956d3ea Spelling fixes. 2004-03-11 00:39:53 +00:00
Dimitrie O. Paun c594043316 Make the controls send notifications to the parent window passed to
them in CREATESTRUCT.  Based on a treeview patch by Igor Grahek.
2003-11-20 22:04:13 +00:00
Dimitrie O. Paun 7de279a73a Rename COMCTL32_{Alloc,ReAlloc,Free} to {Alloc,ReAlloc,Free}. 2003-09-22 21:32:33 +00:00
Alexandre Julliard f5cb3dde17 Moved undocumented functions out of the exported commctrl.h. 2003-09-17 20:15:21 +00:00
Alexandre Julliard cf52644a1c Removed the A/W constants for builtin cursors, icons and resource
types since they don't exist on Windows, and added typecasts
everywhere instead.
2003-09-10 03:56:47 +00:00
Alexandre Julliard e37c6e18d0 Fixed header dependencies to be fully compatible with the Windows
headers (with help from Dimitrie O. Paun).
2003-09-05 23:08:26 +00:00
Dan Kegel 0fd521fee3 Change RECT to use LONG to match win32 standard headers and fix format
strings to use %ld for RECT elements.
2003-01-08 21:09:25 +00:00
Rolf Kalbermatter 6c79930413 Add config.h/port.h to allow compilation/linking in MSVC.
Fix some unsigned/signed warnings.
2002-12-16 22:43:58 +00:00
Francois Gouget d2667a4ce3 Removed unnecessary HANDLE typecasts. 2002-12-02 18:10:57 +00:00
Huw Davies 8d74ef1030 Check the return value of ImageList_GetImageInfo before adjusting the
size.
2002-11-13 19:39:09 +00:00
Carlos Lozano 5347222b23 lParam was not properly sent in COMBOEX_DrawItem. 2002-10-31 22:02:47 +00:00
Carlos 392defd3ef lParam was not properly sent in CBEN_GETDISPINFOW. 2002-10-28 18:50:14 +00:00
Michael Stefaniuc 353529b2c8 - fix the "int format, HANDLE arg" type of warnings for comctl32
- compile the comctl32 dll with -DSTRICT
2002-10-23 22:19:10 +00:00
Michael Stefaniuc f3d1893f80 Add needed casts for a "no warnings" compile of comctl32. 2002-10-23 20:19:22 +00:00
Dimitrie O. Paun da9bac4d9e Add comment on what is known about the current state of the controls
relative to comctl32.dll version 6.0.
2002-10-16 18:57:14 +00:00
Dimitrie O. Paun 856a91b734 - Fix bug in mouse position reading.
- Remove useless code.
- Small code cleanups.
2002-09-09 19:21:30 +00:00
Michael Stefaniuc 025c0b716b Prepare dlls/{comctl32,gdi,msvideo,setupapi,shell32,twain,winmm} for
the conversion of HWND to a void*.
2002-09-06 19:41:17 +00:00
Dimitrie O. Paun ca13564733 Implement CBES_EX_NOSIZELIMIT style. 2002-08-30 00:02:20 +00:00
Dimitrie O. Paun 69c9c432e4 - implement CBEN_DRAGBEGIN
- remove useless FIXMEs
2002-08-28 22:21:46 +00:00
Dimitrie O. Paun f14b527f40 Implement CBES_EX_PATHWORDBREAKPROC for the ComboEx control. 2002-08-27 18:16:48 +00:00
Dimitrie O. Paun 9ff6e77698 - implement CBES_EX_CASESENSITIVE
- fix severe bug in CB_FINDEXACTSTRING
- small cleanups
2002-08-26 21:46:25 +00:00
Dmitry Timoshkov 2f2e4fab6c Added WM_GET/SETTEXT support. 2002-08-13 18:07:02 +00:00
Guy L. Albertelli 23739a339a Don't issue error message if message number in application range. 2002-07-16 01:23:59 +00:00
Vincent Béron 9a62491660 Removed trailing whitespace. 2002-05-31 23:06:46 +00:00
Dimitrie O. Paun 55f9b75163 Fix WM_NOTIFYFORMAT handling. 2002-04-23 19:27:10 +00:00
Dimitrie O. Paun d5d431feae - implement LPSTR_TEXTCALLBACK
- fix many memory-management bugs
- many Unicode fixes
- fix indentation in a few places
- bits of code cleanup
2002-04-11 17:33:47 +00:00
Dimitrie O. Paun 43230a2f42 - fix indentation
- handle all out-of-memory cases
- better drawing code
- fix CBES_EX_NOEDITIMAGE handling
- implement CBES_EX_NOEDITIMAGEINDENT
- implement I_{INDENT,IMAGE}CALLBACK
- fix notification code for ANSI/Unicode
- make use of iOverlay image
2002-04-08 20:16:01 +00:00
Dimitrie O. Paun 7c3fca16c5 - fix edit box placement
- reorganize drawing for proper handling of edit box
- typesafety when processing messages
- subclass edit to handle up/down arrows
- more robust handling of failure cases
- numerous bugs fixed
- complete unicodification
- more specific debug messages
- remove cvs log info from file
- consistent indentation
2002-04-05 21:16:19 +00:00
Alexandre Julliard 0799c1a780 Added LGPL standard comment, and copyright notices where necessary.
Global replacement of debugtools.h by wine/debug.h.
2002-03-09 23:29:33 +00:00
Guy L. Albertelli 683c00ae3f Initialize pszText to 0 for internal ->ceItem to eliminate moves to
garbage locations.
2002-02-12 18:41:48 +00:00
Aric Stewart 1282ef9420 Use the supplied buffer when copying item text. 2002-02-08 17:10:49 +00:00
Sander van Leeuwen fcc148b283 Never delete the font object received by WM_SETFONT. 2002-01-04 21:50:01 +00:00
Francois Gouget 070e749cfb Don't prefix %p with 0x.
Various English fixes.
2001-11-06 21:01:32 +00:00
Jörg Mayer e5b5af9d66 Fixed a few signed/unsigned and "unsigned < 0 always true" warnings. 2001-08-10 22:49:35 +00:00
Guy L. Albertelli d750780f8c Fix conversion of W structure to A structure during notify. 2001-07-20 17:57:24 +00:00
Guy L. Albertelli b2207c7f36 - Fix memory leaks.
- Add support for WM_NOTIFYFORMAT and support both ANSI and UNICODE
  notify formats.
- Fix some drawing issues with COMBOEX_DrawItem.
2001-06-24 00:22:20 +00:00
Guy L. Albertelli bad759075c - Implement CB_{GET|SET}ITEMDATA for CombBoxEx.
- Implement WM_NCCREATE to remove unwanted window styles (as native does).
- Clean up some traces.
2001-04-20 18:27:19 +00:00
Michael Stefaniuc 3a0c6a9490 Fix for small typo. 2001-04-10 21:16:31 +00:00
Jeff Garzik 9fd15a9f2f Added needed string.h includes. 2001-03-22 19:33:57 +00:00
Guy L. Albertelli a7a006a00d - Documented things known to be unimplemented.
- Implemented CBN_SELCHANGE, CBN_KILLFOCUS, and CBN_SELENDOK.
- Corrected CBEN_ENDEDIT notifies to always have edit control text.
- Locked "selected" state of icon to focus state of edit control (if
  it exists) just like native.
2001-03-16 16:41:56 +00:00
Guy L. Albertelli 45e6f62457 - Implement CB_SETCURSEL, CBEM_DELETEITEM, CBEM_GETITEM,
CBEM_{GET|SET}UNICODEFORMAT, CB_FINDSTRINGEXACT, WM_COMMAND,
  WM_DELETEITEM.
- Implement extended style CBES_EX_NOEDITIMAGE, and warn others are
  not yet implemented.
- Restructure DrawItem code to do things more rationally.
2001-02-20 01:53:43 +00:00
Guy L. Albertelli a249595957 - Rewrite WM_CREATE to match native (allocating own Edit control, etc).
- Implement additional WNDPROCs for the Combo and Edit controls to
  handle different functions.
- Implement CBEM_SETCURSEL and CBEM_HASEDITCHANGED.
2001-01-26 21:00:10 +00:00
James Juran f4d5fefb0a Add <string.h> to files that needed it. 2001-01-26 20:43:40 +00:00
Guy L. Albertelli 762ed03a3e Pass WM_COMMAND and WM_NOTIFY to parent as received. 2000-12-18 03:12:31 +00:00
Alexandre Julliard 24a62ab9b0 Got rid of the Wine internal lstrcpy* functions and of winestring.h. 2000-11-28 22:40:56 +00:00
Marcus Meissner 643fcffaac CBEM_SETITEMW done by example from SETITEMA, converted SETITEMA to use
it.
2000-11-06 20:22:06 +00:00
Marcus Meissner a0dc42101a Forward CBEM_SETEXSTYLE to CBEM_SETEXTENDEDSTYLE, pass WM_SETTEXT and
WM_GETTEXT down to combo box.
2000-11-05 03:19:06 +00:00
Guy L. Albertelli 312beec840 Handle special case where itemID = -1 (special focus rect draw). 2000-10-31 01:00:39 +00:00
Uwe Bonnes a07258d581 COMBOEX_DrawItem: check return value of SendMessageA(...,CB_GETITEMDATA,...) 2000-10-29 18:04:45 +00:00
Guy L. Albertelli c6c53cd935 - improved trace information
- implemented CB_SETITEMHEIGHT, WM_WINDOWPOSCHANGING,
  WM_MEASUREITEM, WM_DRAWITEM
- changed CBEM_INSERTITEMA, CBEM_SETIMAGELIST,
  WM_CREATE, WM_DESTROY
- above changes correct window rectangle, draws items, and creates
  control correctly.
2000-10-29 01:16:53 +00:00
Alexandre Julliard 70c9e095ef Removed all non-standard common control headers from the include
directory.
2000-08-09 00:41:17 +00:00
Gerard Patel a1b2fc2a80 Protect against use of comctl32 private control memory after it has
been freed.
2000-05-10 01:34:53 +00:00
Alexandre Julliard d711ad9e0a Removed superfluous GlobalFindAtom calls. 2000-02-13 15:10:16 +00:00
Patrik Stridvall 26ffb3cd76 Fixed/added missing/wrong function prototypes and made internal
functions static.
1999-07-31 14:41:43 +00:00
Alexandre Julliard a099a555c3 Converted to the new debug interface, using script written by Patrik
Stridvall.
1999-06-12 15:45:58 +00:00
Patrik Stridvall 9e61c1cc9b Changed xxx(VOID) to xxx(void). 1999-06-12 08:27:49 +00:00
Patrik Stridvall 896889f317 ANSI C fixes. 1999-05-08 12:50:36 +00:00
Patrik Stridvall b4b9fae671 New debug scheme with explicit debug channels declaration. 1999-04-19 14:56:29 +00:00
Dimitrie O. Paun 05c0c8ef13 Changed some debug messages from one channel to another, to clean up a
bit the debug channel usage.
1999-03-28 15:07:41 +00:00
Marcus Meissner 3480e4a596 Removed no longer necessary win.h include, added now necessary other
includes (win.h used only by UPDOWN now).
1999-03-16 10:53:11 +00:00
Eric Kohl cad17ff708 Replaced direct access to the WND structure by corresponding calls to
Win32 functions.
1999-03-12 17:42:50 +00:00
Alexandre Julliard a396029270 Large-scale renaming of all Win32 functions and types to use the
standard Windows names.
1999-02-26 11:11:13 +00:00
Marcus Meissner 04c3e1d456 Removed a lot of occurences of windows.h (and added necessary other
includes).
1999-02-19 10:37:02 +00:00
Marcus Meissner 317af320cf Optimized include/*.h: (recursively) include all headers needed by
this .h file, but only those. Necessary fixes to a lot of .c files,
started optimizing "windows.h" away from some of them. Moved
GetCurrentTask prototype to wine/winbase16.h.
1999-02-17 13:51:06 +00:00
James Juran c2a1063940 Commented out unused variables to prevent needless compiler warnings. 1999-01-28 16:33:44 +00:00
Andreas Mohr 7a6228d1e1 Fixed a bunch of compiler warnings. 1998-12-11 09:16:48 +00:00
Eric Kohl 66ef011ce5 Added CMEM_SETITEM32A and message forwarding to combobox. 1998-11-22 17:58:40 +00:00