Commit Graph

72 Commits

Author SHA1 Message Date
Zebediah Figura baea371c3d msi: Add exception handling around all custom action RPC calls.
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-09-10 12:30:01 +02:00
Andrey Gusev 5bd1b6f410 msi: Remove checks for negative value.
Signed-off-by: Andrey Gusev <andrey.goosev@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-06-26 09:27:32 +02:00
Zebediah Figura 6b54a4bc2e msi: Avoid using awstring in MsiFormatRecordW().
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-16 10:16:45 +02:00
Zebediah Figura 75aa132b52 msi: Handle the remote case directly in MsiFormatRecordA().
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-16 10:16:41 +02:00
Zebediah Figura ef7ed29348 msi: Make MsiFormatRecord() RPC-compatible.
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-04-25 10:53:13 +02:00
Zebediah Figura 8bfb4e8b62 msi: Convert the IWineMsiRemote* remote interfaces to RPC stubs.
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-04-16 11:48:17 +02:00
Hans Leidekker f517022ecc msi: Fix an invalid write in build_default_format (Valgrind).
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-10-04 16:53:10 +02:00
Nikolay Sivov 3ca2dfe462 msi: Avoid uninitialized pointer access on error path (Coverity).
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-08-08 20:53:08 +09:00
Zebediah Figura 51bd884384 msi: Properly parse empty format strings.
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-11 18:26:03 +02:00
Nikolay Sivov 0bcf4a5bb6 msi: Fix a leak on error path (Coverity). 2014-04-10 09:11:50 +02:00
Nikolay Sivov c01c0b52ed msi: Fix a leak of allocated string buffer on error path (Coverity). 2014-03-27 12:06:04 +01:00
Hans Leidekker 462ec1ba43 msi: Return correct length for the empty string from deformat_string. 2012-11-07 18:12:08 +01:00
Hans Leidekker cfadbddcaf msi: Avoid a crash when target paths have not yet been resolved. 2012-11-06 20:00:27 +01:00
Hans Leidekker 570322069c msi: Preserve strings with embedded nulls in the record formatting implementation. 2012-11-05 17:44:18 +01:00
Hans Leidekker 52a87c9054 msi: Add a length parameter to msi_strcpy_to_awstring and use it where appropriate. 2012-10-29 14:41:49 +01:00
Hans Leidekker 929d234072 msi: Return length instead of size from deformat_string. 2012-10-29 14:41:41 +01:00
Hans Leidekker 0c43024af7 msi: Get rid of helpers.c. 2011-05-06 16:39:08 +02:00
Hans Leidekker 8fb5368d4e msi: Use a separate function to retrieve the target folder path. 2011-05-02 16:39:52 +02:00
Hans Leidekker b96e5d21c6 msi: Split up resolve_folder. 2011-02-07 10:17:15 -06:00
Hans Leidekker a4c25196b0 msi: Fix memory leaks in deformat_string_internal. 2010-05-20 16:25:44 +02:00
Hans Leidekker 186f4efa3f msi: Make msi_get_property_int and friends take a pointer to a database instead of a package.
They only operate on a database and this way we can use them before a package is created.
2010-04-21 11:57:33 +02:00
Hans Leidekker c1670fb353 msi: Don't trace an out parameter. 2009-06-04 12:17:59 +02:00
Michael Stefaniuc 6bd893a960 msi: Change MSIHANDLE to ULONG for Win64 compatibility.
Also fix the compiler warnings produced by this change.
2009-01-05 12:34:12 +01:00
Rob Shearman 4a75b8bf09 msi: Fix the value parameter of IWineMsiRemotePackage::FormatRecord to have the right level of indirection for an [out] parameter.
Remove the redundant size parameter and simplify the client code such 
that the remote function is only called once, with the value being 
automatically allocated. Add corresponding code on the server side to 
automatically allocate said value.
2008-04-17 11:39:37 +02:00
Rob Shearman 3183ad65d2 msi: Fix buffer size calculation in build_default_format. 2008-02-28 10:44:11 +01:00
James Hawkins 45d7d6a4e1 msi: Fix skipping a NULL record. 2008-02-26 11:19:29 +01:00
Michael Stefaniuc 41848c828b msi: Fix "type of 'x' defaults to 'int'" warnings. 2008-02-06 11:36:04 +01:00
James Hawkins 5a0d459cc4 msi: Reimplement MsiFormatRecord. 2008-02-05 12:19:37 +01:00
Andrew Talbot 15d6436295 msi: Remove unneeded cast. 2007-12-24 13:30:24 +01:00
James Hawkins 0a05a87436 msi: Downgrade an ERR to a WARN. 2007-11-26 12:28:37 +01:00
Juan Lang a3331c6f22 msi: Initialize nested. 2007-09-18 10:42:14 +02:00
Juan Lang 71a78c4478 msi: Make sure nested is initialized. 2007-09-18 10:42:05 +02:00
Juan Lang c2d66da665 msi: Don't crash if record has no fields. 2007-09-18 10:41:58 +02:00
Francois Gouget 5771700019 msi: Better match the PSDK types, remove some now unused types from win32.api, and update it to fix the winapi_check warnings. 2007-08-09 14:12:44 +02:00
James Hawkins ba4919912c msi: Forward MsiFormatRecordA to MsiFormatRecordW. 2007-07-06 18:12:05 +02:00
James Hawkins cba1b1e1f4 msi: Handle remote calls to MsiFormatRecordW. 2007-07-06 18:12:00 +02:00
Andrew Talbot 58c55881be msi: Constify a variable. 2007-06-12 11:18:39 +02:00
James Hawkins ea2c96c5df msi: Add the ability to deformat the component's source. 2007-05-25 19:30:50 +02:00
James Hawkins f5c2806ca1 msi: Remove a misleading ERR, as this fails if a file doesn't exist, which is common. 2007-05-25 19:30:42 +02:00
James Hawkins 8cedb218c3 msi: Load the folder property if available and requested. 2007-03-29 21:01:42 +02:00
Mike McCormack 80affb3c2d msi: Merge action.h into msipriv.h. 2006-10-10 16:12:12 +02:00
Mike McCormack f1d4646a49 msi: Win64 printf format warning fixes. 2006-10-05 11:32:32 +02:00
James Hawkins ff6fe41df7 msi: Use the TargetPath of a file if the file doesn't exist in MsiFormatRecord. 2006-09-07 13:57:35 +02:00
James Hawkins a248cc8f62 msi: Fix creation of the default format in MsiFormatRecord. 2006-09-07 13:57:24 +02:00
Jonathan Ernst 360a3f9142 Update the address of the Free Software Foundation. 2006-05-23 14:11:13 +02:00
Bill Medland b56ed22277 msi: Prevent array underflow in MsiFormat when measuring with zero-length buffer. 2005-12-21 21:19:47 +01:00
Magnus Olsen a06aa5e996 msi: Fixed deformat_environment to not cut off string. 2005-12-19 18:17:28 +01:00
Francois Gouget 0edbaf7e80 Remove spaces before '\n' in traces. 2005-11-10 12:14:56 +00:00
Mike McCormack 51c6618d8d Rename load_dynamic_stringW to msi_dup_record_field to better describe
what it does, and replace a few instances with MSI_RecordGetString to
avoid allocating memory.
2005-10-27 12:36:12 +00:00
Mike McCormack 6dc309187c Fix some simple memory leaks. 2005-09-21 09:43:29 +00:00