From fd3cf6f2ddf00e4e5e8df8dc4998016f38fa6c98 Mon Sep 17 00:00:00 2001 From: Daniel Lehman Date: Fri, 22 Oct 2021 16:41:29 +0300 Subject: [PATCH] msxml3: Update error for missing closing quote. Signed-off-by: Daniel Lehman Signed-off-by: Nikolay Sivov Signed-off-by: Alexandre Julliard --- dlls/msxml3/pi.c | 2 +- dlls/msxml3/tests/domdoc.c | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/dlls/msxml3/pi.c b/dlls/msxml3/pi.c index 80e6ad70755..1d96c9391ee 100644 --- a/dlls/msxml3/pi.c +++ b/dlls/msxml3/pi.c @@ -298,7 +298,7 @@ static HRESULT xml_get_value(xmlChar **p, xmlChar **value) v = *p; while (**p && **p != q) *p += 1; - if (!**p) return XML_E_EXPECTINGCLOSEQUOTE; + if (!**p) return XML_E_BADCHARINSTRING; len = *p - v; if (!len) return XML_E_MISSINGNAME; *p += 1; diff --git a/dlls/msxml3/tests/domdoc.c b/dlls/msxml3/tests/domdoc.c index e1f71bf5445..22fbe06abd7 100644 --- a/dlls/msxml3/tests/domdoc.c +++ b/dlls/msxml3/tests/domdoc.c @@ -8601,10 +8601,8 @@ todo_wine hr = IXMLDOMDocument_createProcessingInstruction(doc, _bstr_("xml"), _bstr_("version=\"1.0\" encoding=UTF-8"), &pi); ok(hr == XML_E_MISSINGQUOTE, "got 0x%08x\n", hr); hr = IXMLDOMDocument_createProcessingInstruction(doc, _bstr_("xml"), _bstr_("version=\"1.0\" encoding='UTF-8\""), &pi); -todo_wine ok(hr == XML_E_BADCHARINSTRING, "got 0x%08x\n", hr); hr = IXMLDOMDocument_createProcessingInstruction(doc, _bstr_("xml"), _bstr_("version=\"1.0\" encoding=\"UTF-8"), &pi); -todo_wine ok(hr == XML_E_BADCHARINSTRING, "got 0x%08x\n", hr); pi = NULL; hr = IXMLDOMDocument_createProcessingInstruction(doc, _bstr_("xml"), _bstr_("version=\"1.0\" encoding='UTF-8'"), &pi);