From fb7d6b783e8f8c48943772da3fd909e968887137 Mon Sep 17 00:00:00 2001 From: Dylan Smith Date: Mon, 24 May 2010 01:04:42 -0400 Subject: [PATCH] richedit: Missing HeapFree in WM_IME_COMPOSITION. (Smatch). ME_InsertTextFromCursor copies the string passed into it rather than making taking ownership of it. --- dlls/riched20/editor.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/dlls/riched20/editor.c b/dlls/riched20/editor.c index 85e8f147d92..77646149372 100644 --- a/dlls/riched20/editor.c +++ b/dlls/riched20/editor.c @@ -4268,6 +4268,7 @@ LRESULT ME_HandleMessage(ME_TextEditor *editor, UINT msg, WPARAM wParam, ImmGetCompositionStringW(hIMC, GCS_RESULTSTR, lpCompStr, dwBufLen); lpCompStr[dwBufLen/sizeof(WCHAR)] = 0; ME_InsertTextFromCursor(editor,0,lpCompStr,dwBufLen/sizeof(WCHAR),style); + HeapFree(GetProcessHeap(), 0, lpCompStr); } else if (lParam & GCS_COMPSTR) { @@ -4280,6 +4281,7 @@ LRESULT ME_HandleMessage(ME_TextEditor *editor, UINT msg, WPARAM wParam, lpCompStr[dwBufLen/sizeof(WCHAR)] = 0; ME_InsertTextFromCursor(editor,0,lpCompStr,dwBufLen/sizeof(WCHAR),style); + HeapFree(GetProcessHeap(), 0, lpCompStr); ME_SetSelection(editor,editor->imeStartIndex, editor->imeStartIndex + dwBufLen/sizeof(WCHAR)); }