mstask: ITaskTrigger::SetTrigger() should fail on NULL input.

Signed-off-by: Dmitry Timoshkov <dmitry@baikal.ru>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
This commit is contained in:
Dmitry Timoshkov 2018-05-14 15:49:17 +08:00 committed by Alexandre Julliard
parent 340bf9b513
commit fa4c707466
2 changed files with 5 additions and 0 deletions

View File

@ -103,6 +103,8 @@ static HRESULT WINAPI MSTASK_ITaskTrigger_SetTrigger(
TRACE("(%p, %p)\n", iface, pTrigger); TRACE("(%p, %p)\n", iface, pTrigger);
if (!pTrigger) return E_INVALIDARG;
/* Verify valid structure size */ /* Verify valid structure size */
if (pTrigger->cbTriggerSize != sizeof(*pTrigger)) if (pTrigger->cbTriggerSize != sizeof(*pTrigger))
return E_INVALIDARG; return E_INVALIDARG;

View File

@ -136,6 +136,9 @@ static void test_SetTrigger_GetTrigger(void)
hres = ITask_CreateTrigger(test_task, &idx, &test_trigger); hres = ITask_CreateTrigger(test_task, &idx, &test_trigger);
ok(hres == S_OK, "got %#x\n", hres); ok(hres == S_OK, "got %#x\n", hres);
hres = ITaskTrigger_SetTrigger(test_trigger, NULL);
ok(hres == E_INVALIDARG, "got %#x\n", hres);
/* Setup a trigger with base values for this test run */ /* Setup a trigger with base values for this test run */
GetLocalTime(&time); GetLocalTime(&time);
empty_trigger_state.wStartHour = time.wHour; empty_trigger_state.wStartHour = time.wHour;