ReceiveTempSMS
/
Sweden-Number
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

user.exe: Avoid truncating strcmp result (Coverity).

This commit is contained in:
Marcus Meissner 2012-07-07 11:52:24 +02:00 committed by Alexandre Julliard
parent 0ef705fb69
commit f917cd0e42
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
dlls/user.exe16/user.c
View File

@ -2557,7 +2557,14 @@ INT16 WINAPIV wsprintf16( LPSTR buffer, LPCSTR spec, VA_LIST16 valist )
*/ */
INT16 WINAPI lstrcmp16( LPCSTR str1, LPCSTR str2 ) INT16 WINAPI lstrcmp16( LPCSTR str1, LPCSTR str2 )
{ {
return strcmp( str1, str2 ); int ret;
/* Looks too complicated, but in optimized strcpy we might get
* a 32bit wide difference and would truncate it to 16 bit, so
* erroneously returning equality. */
ret = strcmp( str1, str2 );
if (ret < 0) return -1;
if (ret > 0) return 1;
return 0;
} }