ReceiveTempSMS
/
Sweden-Number
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

msxml3: IXMLDOMAttribute shouldn't report its parent.

This commit is contained in:
Nikolay Sivov 2010-02-09 21:00:25 +03:00 committed by Alexandre Julliard
parent 535afbd3aa
commit f65fd26fe1
2 changed files with 16 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
dlls/msxml3/attribute.c
View File

@ -213,7 +213,10 @@ static HRESULT WINAPI domattr_get_parentNode(
IXMLDOMNode** parent )
{
domattr *This = impl_from_IXMLDOMAttribute( iface );
return IXMLDOMNode_get_parentNode( IXMLDOMNode_from_impl(&This->node), parent );
TRACE("(%p)->(%p)\n", This, parent);
if (!parent) return E_INVALIDARG;
*parent = NULL;
return S_FALSE;
}
static HRESULT WINAPI domattr_get_childNodes(

13
dlls/msxml3/tests/domdoc.c
View File

@ -1216,8 +1216,19 @@ static void test_domnode( void )
r = IXMLDOMElement_getAttributeNode( element, str, &attr);
ok( r == S_OK, "GetAttributeNode ret %08x\n", r );
ok( attr != NULL, "getAttributeNode returned NULL\n" );
if(attr)
if (attr)
{
r = IXMLDOMAttribute_get_parentNode( attr, NULL );
ok( r == E_INVALIDARG, "Expected E_INVALIDARG, ret %08x\n", r );
/* attribute doesn't have a parent in msxml interpretation */
node = (IXMLDOMNode*)0xdeadbeef;
r = IXMLDOMAttribute_get_parentNode( attr, &node );
ok( r == S_FALSE, "Expected S_FALSE, ret %08x\n", r );
ok( node == NULL, "Expected NULL, got %p\n", node );
IXMLDOMAttribute_Release(attr);
}
SysFreeString( str );