ReceiveTempSMS
/
Sweden-Number
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

advapi32: Fix a buffer size query in LsaLookupSids.

This commit is contained in:
Hans Leidekker 2010-10-06 15:45:30 +02:00 committed by Alexandre Julliard
parent 9e166a9690
commit ee18ead545
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
dlls/advapi32/lsa.c
View File

@ -483,7 +483,9 @@ NTSTATUS WINAPI LsaLookupSids(
(*Names)[i].Name.Length = 0; (*Names)[i].Name.Length = 0;
(*Names)[i].Name.MaximumLength = 0; (*Names)[i].Name.MaximumLength = 0;
(*Names)[i].Name.Buffer = NULL; (*Names)[i].Name.Buffer = NULL;
if (LookupAccountSidW(NULL, Sids[i], NULL, &name_size, NULL, &domain_size, &use))
if (!LookupAccountSidW(NULL, Sids[i], NULL, &name_size, NULL, &domain_size, &use) &&
GetLastError() == ERROR_INSUFFICIENT_BUFFER)
{ {
LSA_UNICODE_STRING domain; LSA_UNICODE_STRING domain;
@ -502,11 +504,11 @@ NTSTATUS WINAPI LsaLookupSids(
domain.Buffer = NULL; domain.Buffer = NULL;
} }
(*Names)[i].Use = use;
(*Names)[i].Name.Length = (name_size - 1) * sizeof(WCHAR); (*Names)[i].Name.Length = (name_size - 1) * sizeof(WCHAR);
(*Names)[i].Name.MaximumLength = name_size * sizeof(WCHAR); (*Names)[i].Name.MaximumLength = name_size * sizeof(WCHAR);
(*Names)[i].Name.Buffer = HeapAlloc(GetProcessHeap(),0,name_size * sizeof(WCHAR)); (*Names)[i].Name.Buffer = HeapAlloc(GetProcessHeap(), 0, name_size * sizeof(WCHAR));
LookupAccountSidW(NULL, Sids[i], (*Names)[i].Name.Buffer, &name_size, domain.Buffer, &domain_size, &use); LookupAccountSidW(NULL, Sids[i], (*Names)[i].Name.Buffer, &name_size, domain.Buffer, &domain_size, &use);
(*Names)[i].Use = use;
if (domain_size) if (domain_size)
(*Names)[i].DomainIndex = build_domain(*ReferencedDomains, &domain); (*Names)[i].DomainIndex = build_domain(*ReferencedDomains, &domain);