From e9063b77769be6c2ed5bff2d3da17741d898459d Mon Sep 17 00:00:00 2001 From: Alistair Leslie-Hughes Date: Sat, 16 Feb 2008 22:31:01 +1100 Subject: [PATCH] msxml3: Implement IXMLDOMAttribute name property. --- dlls/msxml3/attribute.c | 5 +++-- dlls/msxml3/tests/domdoc.c | 12 ++++++++++++ 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/dlls/msxml3/attribute.c b/dlls/msxml3/attribute.c index 805bafec477..49c39fed1fb 100644 --- a/dlls/msxml3/attribute.c +++ b/dlls/msxml3/attribute.c @@ -433,8 +433,9 @@ static HRESULT WINAPI domattr_get_name( IXMLDOMAttribute *iface, BSTR *p) { - FIXME("\n"); - return E_NOTIMPL; + /* name property returns the same value as nodeName */ + domattr *This = impl_from_IXMLDOMAttribute( iface ); + return IXMLDOMNode_get_nodeName( This->node, p ); } static HRESULT WINAPI domattr_get_value( diff --git a/dlls/msxml3/tests/domdoc.c b/dlls/msxml3/tests/domdoc.c index 424de185668..2401878ba0a 100644 --- a/dlls/msxml3/tests/domdoc.c +++ b/dlls/msxml3/tests/domdoc.c @@ -2128,6 +2128,18 @@ static void test_xmlTypes(void) ok( !lstrcmpW( str, _bstr_("attribute") ), "incorrect nodeTypeString string\n"); SysFreeString(str); + /* test nodeName */ + hr = IXMLDOMAttribute_get_nodeName(pAttrubute, &str); + ok(hr == S_OK, "ret %08x\n", hr ); + ok( !lstrcmpW( str, szAttribute ), "incorrect nodeName string\n"); + SysFreeString(str); + + /* test name property */ + hr = IXMLDOMAttribute_get_name(pAttrubute, &str); + ok(hr == S_OK, "ret %08x\n", hr ); + ok( !lstrcmpW( str, szAttribute ), "incorrect name string\n"); + SysFreeString(str); + hr = IXMLDOMAttribute_get_xml(pAttrubute, &str); ok(hr == S_OK, "ret %08x\n", hr ); ok( !lstrcmpW( str, szAttributeXML ), "incorrect attribute xml\n");