ReceiveTempSMS
/
Sweden-Number
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

oleaut32: Fix uninitialized variable access in VarXor() for earlier failure paths (Coverity). 

Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
This commit is contained in:
Nikolay Sivov 2021-09-14 20:12:12 +03:00 committed by Alexandre Julliard
parent 2fe70331d9
commit e4451427d8
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
dlls/oleaut32/variant.c
View File

@ -4635,6 +4635,7 @@ HRESULT WINAPI VarXor(LPVARIANT pVarLeft, LPVARIANT pVarRight, LPVARIANT pVarOut
return S_OK; return S_OK;
} }
V_VT(&varLeft) = V_VT(&varRight) = VT_EMPTY;
VariantInit(&tempLeft); VariantInit(&tempLeft);
VariantInit(&tempRight); VariantInit(&tempRight);
@ -4653,8 +4654,6 @@ HRESULT WINAPI VarXor(LPVARIANT pVarLeft, LPVARIANT pVarRight, LPVARIANT pVarOut
} }
/* Copy our inputs so we don't disturb anything */ /* Copy our inputs so we don't disturb anything */
V_VT(&varLeft) = V_VT(&varRight) = VT_EMPTY;
hRet = VariantCopy(&varLeft, pVarLeft); hRet = VariantCopy(&varLeft, pVarLeft);
if (FAILED(hRet)) if (FAILED(hRet))
goto VarXor_Exit; goto VarXor_Exit;