From dbfa8eedf79cd7fa54917a4ad6f5a4520b97c87d Mon Sep 17 00:00:00 2001 From: Michael Stefaniuc Date: Tue, 25 Sep 2007 01:15:07 +0200 Subject: [PATCH] ole32: Free memory on error path (found by Smatch). --- dlls/ole32/oleproxy.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dlls/ole32/oleproxy.c b/dlls/ole32/oleproxy.c index e8079411c8f..42dc8d1023d 100644 --- a/dlls/ole32/oleproxy.c +++ b/dlls/ole32/oleproxy.c @@ -402,9 +402,10 @@ static HRESULT WINAPI CFProxy_CreateInstance( hGlobal = GlobalAlloc(GMEM_MOVEABLE|GMEM_NODISCARD|GMEM_SHARE,msg.cbBuffer); memcpy(GlobalLock(hGlobal),msg.Buffer,msg.cbBuffer); hres = CreateStreamOnHGlobal(hGlobal,TRUE,&pStream); - if (hres) { + if (hres != S_OK) { FIXME("CreateStreamOnHGlobal failed with %x\n",hres); IRpcChannelBuffer_FreeBuffer(This->chanbuf,&msg); + GlobalFree(hGlobal); return hres; } hres = IStream_Read(pStream, ppv, sizeof(*ppv), NULL);