ReceiveTempSMS
/
Sweden-Number
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

crypt32: Use a larger temporary buffer in CRYPT_AsnDecodeOidIgnoreTag().

This commit is contained in:
Henri Verbeet 2012-01-26 00:21:19 +01:00 committed by Alexandre Julliard
parent f355f59345
commit db15675280
1 changed files with 3 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
dlls/crypt32/decode.c
View File

@ -1310,22 +1310,17 @@ static BOOL CRYPT_AsnDecodeOidIgnoreTag(const BYTE *pbEncoded, DWORD cbEncoded,
if (dataLen) if (dataLen)
{ {
/* The largest possible string for the first two components
* is 2.175 (= 2 * 40 + 175 = 255), so this is big enough.
*/
char firstTwo[6];
const BYTE *ptr; const BYTE *ptr;
char str[32];
snprintf(firstTwo, sizeof(firstTwo), "%d.%d", snprintf(str, sizeof(str), "%d.%d",
pbEncoded[1 + lenBytes] / 40, pbEncoded[1 + lenBytes] / 40,
pbEncoded[1 + lenBytes] - (pbEncoded[1 + lenBytes] / 40) pbEncoded[1 + lenBytes] - (pbEncoded[1 + lenBytes] / 40)
* 40); * 40);
bytesNeeded += strlen(firstTwo) + 1; bytesNeeded += strlen(str) + 1;
for (ptr = pbEncoded + 2 + lenBytes; ret && for (ptr = pbEncoded + 2 + lenBytes; ret &&
ptr - pbEncoded - 1 - lenBytes < dataLen; ) ptr - pbEncoded - 1 - lenBytes < dataLen; )
{ {
/* large enough for ".4000000" */
char str[9];
int val = 0; int val = 0;
while (ptr - pbEncoded - 1 - lenBytes < dataLen && while (ptr - pbEncoded - 1 - lenBytes < dataLen &&