ReceiveTempSMS/Sweden-Number
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix a regression in the performance of named pipes by only making the

Browse Source 
fd non-blocking when overlapped I/O is requested for the fd (reported
by Ivan Leo Puoti).
This commit is contained in:
Robert Shearman 2005-06-09 09:46:55 +00:00 committed by Alexandre Julliard
parent f55de5cf35
commit d681022d68
1 changed files with 13 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
server/named_pipe.c
View File

@ -616,17 +616,26 @@ DECL_HANDLER(open_named_pipe)
client = create_pipe_client( server, req->flags ); client = create_pipe_client( server, req->flags );
if( client ) if( client )
{ {
if( !socketpair( PF_UNIX, SOCK_STREAM, 0, fds ) && if (!socketpair( PF_UNIX, SOCK_STREAM, 0, fds ))
(fcntl( fds[0], F_SETFL, O_NONBLOCK ) != -1) &&
(fcntl( fds[1], F_SETFL, O_NONBLOCK ) != -1))
{ {
int res = 0;
assert( !client->fd ); assert( !client->fd );
assert( !server->fd ); assert( !server->fd );
/* for performance reasons, only set nonblocking mode when using
* overlapped I/O. Otherwise, we will be doing too much busy
* looping */
if (is_overlapped( req->flags ))
res = fcntl( fds[1], F_SETFL, O_NONBLOCK );
if ((res != -1) && is_overlapped( server->options ))
res = fcntl( fds[0], F_SETFL, O_NONBLOCK );
client->fd = create_anonymous_fd( &pipe_client_fd_ops, client->fd = create_anonymous_fd( &pipe_client_fd_ops,
fds[1], &client->obj ); fds[1], &client->obj );
server->fd = create_anonymous_fd( &pipe_server_fd_ops, server->fd = create_anonymous_fd( &pipe_server_fd_ops,
fds[0], &server->obj ); fds[0], &server->obj );
if (client->fd && server->fd) if (client->fd && server->fd && res != 1)
{ {
if( server->state == ps_wait_open ) if( server->state == ps_wait_open )
async_terminate_head( &server->wait_q, STATUS_SUCCESS ); async_terminate_head( &server->wait_q, STATUS_SUCCESS );