ReceiveTempSMS
/
Sweden-Number
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

advapi32: Add some input parameter checks to BackupEventLog.

This commit is contained in:
Paul Vriens 2009-10-30 09:51:15 +01:00 committed by Alexandre Julliard
parent b90ef8c6d9
commit d2227cb8a4
2 changed files with 29 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
dlls/advapi32/eventlog.c
View File

@ -64,8 +64,14 @@ static inline LPWSTR SERV_dup( LPCSTR str )
*/
BOOL WINAPI BackupEventLogA( HANDLE hEventLog, LPCSTR lpBackupFileName )
{
FIXME("(%p,%s) stub\n", hEventLog, debugstr_a(lpBackupFileName));
return TRUE;
LPWSTR backupW;
BOOL ret;
backupW = SERV_dup(lpBackupFileName);
ret = BackupEventLogW(hEventLog, backupW);
HeapFree(GetProcessHeap(), 0, backupW);
return ret;
}
/******************************************************************************
@ -75,8 +81,27 @@ BOOL WINAPI BackupEventLogA( HANDLE hEventLog, LPCSTR lpBackupFileName )
*/
BOOL WINAPI BackupEventLogW( HANDLE hEventLog, LPCWSTR lpBackupFileName )
{
FIXME("(%p,%s) stub\n", hEventLog, debugstr_w(lpBackupFileName));
return TRUE;
FIXME("(%p,%s) stub\n", hEventLog, debugstr_w(lpBackupFileName));
if (!lpBackupFileName)
{
SetLastError(ERROR_INVALID_PARAMETER);
return FALSE;
}
if (!hEventLog)
{
SetLastError(ERROR_INVALID_HANDLE);
return FALSE;
}
if (GetFileAttributesW(lpBackupFileName) != INVALID_FILE_ATTRIBUTES)
{
SetLastError(ERROR_ALREADY_EXISTS);
return FALSE;
}
return TRUE;
}
/******************************************************************************

7
dlls/advapi32/tests/eventlog.c
View File

@ -223,15 +223,11 @@ static void test_backup(void)
SetLastError(0xdeadbeef);
ret = BackupEventLogA(NULL, NULL);
todo_wine
{
ok(!ret, "Expected failure\n");
ok(GetLastError() == ERROR_INVALID_PARAMETER, "Expected ERROR_INVALID_PARAMETER, got %d\n", GetLastError());
}
SetLastError(0xdeadbeef);
ret = BackupEventLogA(NULL, backup);
todo_wine
ok(!ret, "Expected failure\n");
ok(GetFileAttributesA(backup) == INVALID_FILE_ATTRIBUTES, "Expected no backup file\n");
@ -239,11 +235,8 @@ static void test_backup(void)
SetLastError(0xdeadbeef);
ret = BackupEventLogA(handle, NULL);
todo_wine
{
ok(!ret, "Expected failure\n");
ok(GetLastError() == ERROR_INVALID_PARAMETER, "Expected ERROR_INVALID_PARAMETER, got %d\n", GetLastError());
}
ret = BackupEventLogA(handle, backup);
ok(ret, "Expected succes\n");