mfreadwrite/reader: Make the stream sample allocator callback own a reference to the source reader.

The stream sample allocator callback NotifyRelease() method assumes that
the source reader is valid. Therefore it must own a reference to it,
otherwise it might get called while the source reader is being destroyed,
causing a crash.

Signed-off-by: Giovanni Mascellani <gmascellani@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
This commit is contained in:
Giovanni Mascellani 2022-04-09 09:16:17 +03:00 committed by Alexandre Julliard
parent a4e4e19fe0
commit cdb0471eca
1 changed files with 4 additions and 2 deletions

View File

@ -2282,12 +2282,14 @@ static HRESULT WINAPI stream_sample_allocator_cb_QueryInterface(IMFVideoSampleAl
static ULONG WINAPI stream_sample_allocator_cb_AddRef(IMFVideoSampleAllocatorNotify *iface)
{
return 2;
struct media_stream *stream = impl_stream_from_IMFVideoSampleAllocatorNotify(iface);
return source_reader_addref(stream->reader);
}
static ULONG WINAPI stream_sample_allocator_cb_Release(IMFVideoSampleAllocatorNotify *iface)
{
return 1;
struct media_stream *stream = impl_stream_from_IMFVideoSampleAllocatorNotify(iface);
return source_reader_release(stream->reader);
}
static HRESULT WINAPI stream_sample_allocator_cb_NotifyRelease(IMFVideoSampleAllocatorNotify *iface)