ReceiveTempSMS
/
Sweden-Number
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

msi: Fix leaks in stop_service_dependents (coverity).

This commit is contained in:
Frédéric Delanoy 2012-11-16 11:50:27 +01:00 committed by Alexandre Julliard
parent 499c53175b
commit cac26d47a0
1 changed files with 10 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
dlls/msi/action.c
View File

@ -6043,6 +6043,7 @@ static BOOL stop_service_dependents(SC_HANDLE scm, SC_HANDLE service)
ENUM_SERVICE_STATUSW *dependencies; ENUM_SERVICE_STATUSW *dependencies;
SERVICE_STATUS ss; SERVICE_STATUS ss;
SC_HANDLE depserv; SC_HANDLE depserv;
BOOL stopped, ret = FALSE;
if (EnumDependentServicesW(service, SERVICE_ACTIVE, NULL, if (EnumDependentServicesW(service, SERVICE_ACTIVE, NULL,
0, &needed, &count)) 0, &needed, &count))
@ -6057,24 +6058,26 @@ static BOOL stop_service_dependents(SC_HANDLE scm, SC_HANDLE service)
if (!EnumDependentServicesW(service, SERVICE_ACTIVE, dependencies, if (!EnumDependentServicesW(service, SERVICE_ACTIVE, dependencies,
needed, &needed, &count)) needed, &needed, &count))
goto error; goto done;
for (i = 0; i < count; i++) for (i = 0; i < count; i++)
{ {
depserv = OpenServiceW(scm, dependencies[i].lpServiceName, depserv = OpenServiceW(scm, dependencies[i].lpServiceName,
SERVICE_STOP | SERVICE_QUERY_STATUS); SERVICE_STOP | SERVICE_QUERY_STATUS);
if (!depserv) if (!depserv)
goto error; goto done;
if (!ControlService(depserv, SERVICE_CONTROL_STOP, &ss)) stopped = ControlService(depserv, SERVICE_CONTROL_STOP, &ss);
goto error; CloseServiceHandle(depserv);
if (!stopped)
goto done;
} }
return TRUE; ret = TRUE;
error: done:
msi_free(dependencies); msi_free(dependencies);
return FALSE; return ret;
} }
static UINT stop_service( LPCWSTR name ) static UINT stop_service( LPCWSTR name )