diff --git a/dlls/wininet/internet.c b/dlls/wininet/internet.c index 5e5bceafef6..d0228bee375 100644 --- a/dlls/wininet/internet.c +++ b/dlls/wininet/internet.c @@ -3663,10 +3663,7 @@ BOOL WINAPI InternetCreateUrlA(LPURL_COMPONENTSA lpUrlComponents, DWORD dwFlags, TRACE("(%p,%d,%p,%p)\n", lpUrlComponents, dwFlags, lpszUrl, lpdwUrlLength); - if (!lpUrlComponents) - return FALSE; - - if (lpUrlComponents->dwStructSize != sizeof(URL_COMPONENTSW) || !lpdwUrlLength) + if (!lpUrlComponents || lpUrlComponents->dwStructSize != sizeof(URL_COMPONENTSW) || !lpdwUrlLength) { INTERNET_SetLastError(ERROR_INVALID_PARAMETER); return FALSE; @@ -3733,10 +3730,7 @@ BOOL WINAPI InternetCreateUrlW(LPURL_COMPONENTSW lpUrlComponents, DWORD dwFlags, TRACE("(%p,%d,%p,%p)\n", lpUrlComponents, dwFlags, lpszUrl, lpdwUrlLength); - if (!lpUrlComponents) - return FALSE; - - if (lpUrlComponents->dwStructSize != sizeof(URL_COMPONENTSW) || !lpdwUrlLength) + if (!lpUrlComponents || lpUrlComponents->dwStructSize != sizeof(URL_COMPONENTSW) || !lpdwUrlLength) { INTERNET_SetLastError(ERROR_INVALID_PARAMETER); return FALSE; diff --git a/dlls/wininet/tests/url.c b/dlls/wininet/tests/url.c index 125e6418410..6da48bed62e 100644 --- a/dlls/wininet/tests/url.c +++ b/dlls/wininet/tests/url.c @@ -404,11 +404,11 @@ static void InternetCreateUrlA_test(void) host[] = "host"; /* test NULL lpUrlComponents */ - ret = InternetCreateUrlA(NULL, 0, NULL, &len); SetLastError(0xdeadbeef); + ret = InternetCreateUrlA(NULL, 0, NULL, &len); ok(!ret, "Expected failure\n"); - ok(GetLastError() == 0xdeadbeef, - "Expected 0xdeadbeef, got %d\n", GetLastError()); + ok(GetLastError() == ERROR_INVALID_PARAMETER, + "Expected ERROR_INVALID_PARAMETER, got %d\n", GetLastError()); ok(len == -1, "Expected len -1, got %d\n", len); /* test zero'ed lpUrlComponents */