From c0596e0ae91ee942dac6c5a8891000093c9aa3ae Mon Sep 17 00:00:00 2001 From: Robert Shearman <rob@codeweavers.com> Date: Mon, 24 Jul 2006 11:45:50 +0100 Subject: [PATCH] msi: The szLogFile parameter of MsiEnableLogW is optional, so handle the case of it being NULL. --- dlls/msi/msi.c | 21 +++++++++++++-------- 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/dlls/msi/msi.c b/dlls/msi/msi.c index f8bd9636180..7e4bae312a0 100644 --- a/dlls/msi/msi.c +++ b/dlls/msi/msi.c @@ -632,15 +632,20 @@ UINT WINAPI MsiEnableLogW(DWORD dwLogMode, LPCWSTR szLogFile, DWORD attributes) TRACE("%08lx %s %08lx\n", dwLogMode, debugstr_w(szLogFile), attributes); - lstrcpyW(gszLogFile,szLogFile); - if (!(attributes & INSTALLLOGATTRIBUTES_APPEND)) - DeleteFileW(szLogFile); - file = CreateFileW(szLogFile, GENERIC_WRITE, 0, NULL, OPEN_ALWAYS, - FILE_ATTRIBUTE_NORMAL, NULL); - if (file != INVALID_HANDLE_VALUE) - CloseHandle(file); + if (szLogFile) + { + lstrcpyW(gszLogFile,szLogFile); + if (!(attributes & INSTALLLOGATTRIBUTES_APPEND)) + DeleteFileW(szLogFile); + file = CreateFileW(szLogFile, GENERIC_WRITE, 0, NULL, OPEN_ALWAYS, + FILE_ATTRIBUTE_NORMAL, NULL); + if (file != INVALID_HANDLE_VALUE) + CloseHandle(file); + else + ERR("Unable to enable log %s\n",debugstr_w(szLogFile)); + } else - ERR("Unable to enable log %s\n",debugstr_w(szLogFile)); + gszLogFile[0] = '\0'; return ERROR_SUCCESS; }