From bfab009e67338d3f6b0142c55ec3383a5147f6a3 Mon Sep 17 00:00:00 2001 From: Jacek Caban Date: Thu, 26 Mar 2020 20:54:05 +0100 Subject: [PATCH] rpcrt4: Fix use after free in get_iface_info. Signed-off-by: Jacek Caban Signed-off-by: Alexandre Julliard --- dlls/rpcrt4/ndr_typelib.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/dlls/rpcrt4/ndr_typelib.c b/dlls/rpcrt4/ndr_typelib.c index 91c4a07464f..f1f25885b75 100644 --- a/dlls/rpcrt4/ndr_typelib.c +++ b/dlls/rpcrt4/ndr_typelib.c @@ -1276,18 +1276,18 @@ static HRESULT get_iface_info(ITypeInfo *typeinfo, WORD *funcs, WORD *parentfunc if (FAILED(hr)) goto err; hr = ITypeInfo_GetRefTypeInfo(*real_typeinfo, reftype, &parentinfo); - if (SUCCEEDED(hr)) - { - hr = ITypeInfo_GetTypeAttr(parentinfo, &typeattr); - ITypeInfo_Release(parentinfo); - } if (FAILED(hr)) goto err; - *parentiid = typeattr->guid; - ITypeInfo_ReleaseTypeAttr(parentinfo, typeattr); - - return S_OK; + hr = ITypeInfo_GetTypeAttr(parentinfo, &typeattr); + if (SUCCEEDED(hr)) + { + *parentiid = typeattr->guid; + ITypeInfo_ReleaseTypeAttr(parentinfo, typeattr); + } + ITypeInfo_Release(parentinfo); + if (SUCCEEDED(hr)) + return hr; err: ITypeInfo_Release(*real_typeinfo);