ReceiveTempSMS/Sweden-Number
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fixed two leaks in file- and itemmoniker.

Browse Source
This commit is contained in:
Juergen Schmied 2002-07-16 01:43:24 +00:00 committed by Alexandre Julliard
parent 2c5a41b027
commit bdd7d8bc47
2 changed files with 29 additions and 36 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
dlls/ole32/filemoniker.c
View File

@ -870,21 +870,18 @@ HRESULT WINAPI FileMonikerImpl_IsEqual(IMoniker* iface,IMoniker* pmkOtherMoniker
IMoniker_GetClassID(pmkOtherMoniker,&clsid); IMoniker_GetClassID(pmkOtherMoniker,&clsid);
if (!IsEqualCLSID(&clsid,&CLSID_FileMoniker)) if (!IsEqualCLSID(&clsid,&CLSID_FileMoniker))
return S_FALSE; return S_FALSE;
res = CreateBindCtx(0,&bind); res = CreateBindCtx(0,&bind);
if (FAILED(res)) if (FAILED(res)) return res;
return res;
IMoniker_GetDisplayName(pmkOtherMoniker,bind,NULL,&filePath);
if (lstrcmpiW(filePath,
This->filePathName)!=0)
if (SUCCEEDED(IMoniker_GetDisplayName(pmkOtherMoniker,bind,NULL,&filePath))) {
int result = lstrcmpiW(filePath, This->filePathName);
CoTaskMemFree(filePath);
if ( result == 0 ) return S_OK;
}
return S_FALSE; return S_FALSE;
return S_OK;
} }
/****************************************************************************** /******************************************************************************

44
dlls/ole32/itemmoniker.c
View File

@ -387,20 +387,20 @@ HRESULT WINAPI ItemMonikerImpl_Construct(ItemMonikerImpl* This, LPCOLESTR lpszDe
This->itemName=HeapAlloc(GetProcessHeap(),0,sizeof(WCHAR)*(sizeStr1+1)); This->itemName=HeapAlloc(GetProcessHeap(),0,sizeof(WCHAR)*(sizeStr1+1));
if (!This->itemName) if (!This->itemName)
return E_OUTOFMEMORY; return E_OUTOFMEMORY;
strcpyW(This->itemName,lpszItem); lstrcpyW(This->itemName,lpszItem);
if (!lpszDelim) if (!lpszDelim)
FIXME("lpszDelim is NULL. Using empty string which is possibly wrong.\n"); FIXME("lpszDelim is NULL. Using empty string which is possibly wrong.\n");
delim = lpszDelim ? lpszDelim : emptystr; delim = lpszDelim ? lpszDelim : emptystr;
sizeStr2=strlenW(delim); sizeStr2=lstrlenW(delim);
This->itemDelimiter=HeapAlloc(GetProcessHeap(),0,sizeof(WCHAR)*(sizeStr2+1)); This->itemDelimiter=HeapAlloc(GetProcessHeap(),0,sizeof(WCHAR)*(sizeStr2+1));
if (!This->itemDelimiter) { if (!This->itemDelimiter) {
HeapFree(GetProcessHeap(),0,This->itemName); HeapFree(GetProcessHeap(),0,This->itemName);
return E_OUTOFMEMORY; return E_OUTOFMEMORY;
} }
strcpyW(This->itemDelimiter,delim); lstrcpyW(This->itemDelimiter,delim);
return S_OK; return S_OK;
} }
@ -611,32 +611,28 @@ HRESULT WINAPI ItemMonikerImpl_IsEqual(IMoniker* iface,IMoniker* pmkOtherMoniker
CLSID clsid; CLSID clsid;
LPOLESTR dispName1,dispName2; LPOLESTR dispName1,dispName2;
IBindCtx* bind; IBindCtx* bind;
HRESULT res; HRESULT res = S_FALSE;
TRACE("(%p,%p)\n",iface,pmkOtherMoniker); TRACE("(%p,%p)\n",iface,pmkOtherMoniker);
if (pmkOtherMoniker==NULL) if (!pmkOtherMoniker) return S_FALSE;
return S_FALSE;
/* This method returns S_OK if both monikers are item monikers and their display names are */
/* identical (using a case-insensitive comparison); otherwise, the method returns S_FALSE. */
IMoniker_GetClassID(pmkOtherMoniker,&clsid); /* check if both are ItemMoniker */
if(FAILED (IMoniker_GetClassID(pmkOtherMoniker,&clsid))) return S_FALSE;
if(!IsEqualCLSID(&clsid,&CLSID_ItemMoniker)) return S_FALSE;
if (!IsEqualCLSID(&clsid,&CLSID_ItemMoniker)) /* check if both displaynames are the same */
return S_FALSE; if(SUCCEEDED ((res = CreateBindCtx(0,&bind)))) {
if(SUCCEEDED (IMoniker_GetDisplayName(iface,bind,NULL,&dispName1))) {
res=CreateBindCtx(0,&bind); if(SUCCEEDED (IMoniker_GetDisplayName(pmkOtherMoniker,bind,NULL,&dispName2))) {
if (FAILED(res)) if(lstrcmpW(dispName1,dispName2)==0) res = S_OK;
CoTaskMemFree(dispName2);
}
CoTaskMemFree(dispName1);
}
}
return res; return res;
IMoniker_GetDisplayName(iface,bind,NULL,&dispName1);
IMoniker_GetDisplayName(pmkOtherMoniker,bind,NULL,&dispName2);
if (lstrcmpW(dispName1,dispName2)!=0)
return S_FALSE;
return S_OK;
} }
/****************************************************************************** /******************************************************************************
@ -842,8 +838,8 @@ HRESULT WINAPI ItemMonikerImpl_GetDisplayName(IMoniker* iface,
if (*ppszDisplayName==NULL) if (*ppszDisplayName==NULL)
return E_OUTOFMEMORY; return E_OUTOFMEMORY;
strcpyW(*ppszDisplayName,This->itemDelimiter); lstrcpyW(*ppszDisplayName,This->itemDelimiter);
strcatW(*ppszDisplayName,This->itemName); lstrcatW(*ppszDisplayName,This->itemName);
return S_OK; return S_OK;
} }