ReceiveTempSMS
/
Sweden-Number
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

ddraw/tests: Disable a test that causes heap corruption on some Nvidia. 

Signed-off-by: Stefan Dösinger <stefan@codeweavers.com
Signed-off-by: Henri Verbeet <hverbeet@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
This commit is contained in:
Stefan Dösinger 2020-01-07 12:40:05 +01:00 committed by Alexandre Julliard
parent 7adb30b24c
commit b9a9ad4c03
4 changed files with 52 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
dlls/ddraw/tests/ddraw1.c
View File

@ -12908,9 +12908,19 @@ static void test_clipper_refcount(void)
IDirectDrawClipper_Release(clipper);
IDirectDrawClipper_Release(clipper);
hr = IDirectDrawSurface_GetClipper(surface, &clipper2);
ok(SUCCEEDED(hr), "Failed to get clipper, hr %#x.\n", hr);
ok(clipper == clipper2, "Got clipper %p, expected %p.\n", clipper2, clipper);
if (!ddraw_is_nvidia(ddraw))
{
/* Disabled because it causes heap corruption (HeapValidate fails and random
* hangs in a later HeapFree) on Windows on one of my Machines: MacbookPro 10,1
* running Windows 10 18363.535 and Nvidia driver 425.31. Driver version 441.66
* is affected too.
*
* The same Windows and driver versions run the test without heap corruption on
* a Geforce 1060 GTX card. I have not seen the problem on AMD GPUs either. */
hr = IDirectDrawSurface_GetClipper(surface, &clipper2);
ok(SUCCEEDED(hr), "Failed to get clipper, hr %#x.\n", hr);
ok(clipper == clipper2, "Got clipper %p, expected %p.\n", clipper2, clipper);
}
/* Show that invoking the Release method does not crash, but don't get the
* vtable through the clipper pointer because it is no longer pointing to

16
dlls/ddraw/tests/ddraw2.c
View File

@ -13737,9 +13737,19 @@ static void test_clipper_refcount(void)
IDirectDrawClipper_Release(clipper);
IDirectDrawClipper_Release(clipper);
hr = IDirectDrawSurface_GetClipper(surface, &clipper2);
ok(SUCCEEDED(hr), "Failed to get clipper, hr %#x.\n", hr);
ok(clipper == clipper2, "Got clipper %p, expected %p.\n", clipper2, clipper);
if (!ddraw_is_nvidia(ddraw))
{
/* Disabled because it causes heap corruption (HeapValidate fails and random
* hangs in a later HeapFree) on Windows on one of my Machines: MacbookPro 10,1
* running Windows 10 18363.535 and Nvidia driver 425.31. Driver version 441.66
* is affected too.
*
* The same Windows and driver versions run the test without heap corruption on
* a Geforce 1060 GTX card. I have not seen the problem on AMD GPUs either. */
hr = IDirectDrawSurface_GetClipper(surface, &clipper2);
ok(SUCCEEDED(hr), "Failed to get clipper, hr %#x.\n", hr);
ok(clipper == clipper2, "Got clipper %p, expected %p.\n", clipper2, clipper);
}
/* Show that invoking the Release method does not crash, but don't get the
* vtable through the clipper pointer because it is no longer pointing to

16
dlls/ddraw/tests/ddraw4.c
View File

@ -16388,9 +16388,19 @@ static void test_clipper_refcount(void)
IDirectDrawClipper_Release(clipper);
IDirectDrawClipper_Release(clipper);
hr = IDirectDrawSurface4_GetClipper(surface, &clipper2);
ok(SUCCEEDED(hr), "Failed to get clipper, hr %#x.\n", hr);
ok(clipper == clipper2, "Got clipper %p, expected %p.\n", clipper2, clipper);
if (!ddraw_is_nvidia(ddraw))
{
/* Disabled because it causes heap corruption (HeapValidate fails and random
* hangs in a later HeapFree) on Windows on one of my Machines: MacbookPro 10,1
* running Windows 10 18363.535 and Nvidia driver 425.31. Driver version 441.66
* is affected too.
*
* The same Windows and driver versions run the test without heap corruption on
* a Geforce 1060 GTX card. I have not seen the problem on AMD GPUs either. */
hr = IDirectDrawSurface4_GetClipper(surface, &clipper2);
ok(SUCCEEDED(hr), "Failed to get clipper, hr %#x.\n", hr);
ok(clipper == clipper2, "Got clipper %p, expected %p.\n", clipper2, clipper);
}
/* Show that invoking the Release method does not crash, but don't get the
* vtable through the clipper pointer because it is no longer pointing to

16
dlls/ddraw/tests/ddraw7.c
View File

@ -16290,9 +16290,19 @@ static void test_clipper_refcount(void)
IDirectDrawClipper_Release(clipper);
IDirectDrawClipper_Release(clipper);
hr = IDirectDrawSurface7_GetClipper(surface, &clipper2);
ok(SUCCEEDED(hr), "Failed to get clipper, hr %#x.\n", hr);
ok(clipper == clipper2, "Got clipper %p, expected %p.\n", clipper2, clipper);
if (!ddraw_is_nvidia(ddraw))
{
/* Disabled because it causes heap corruption (HeapValidate fails and random
* hangs in a later HeapFree) on Windows on one of my Machines: MacbookPro 10,1
* running Windows 10 18363.535 and Nvidia driver 425.31. Driver version 441.66
* is affected too.
*
* The same Windows and driver versions run the test without heap corruption on
* a Geforce 1060 GTX card. I have not seen the problem on AMD GPUs either. */
hr = IDirectDrawSurface7_GetClipper(surface, &clipper2);
ok(SUCCEEDED(hr), "Failed to get clipper, hr %#x.\n", hr);
ok(clipper == clipper2, "Got clipper %p, expected %p.\n", clipper2, clipper);
}
/* Show that invoking the Release method does not crash, but don't get the
* vtable through the clipper pointer because it is no longer pointing to