ReceiveTempSMS
/
Sweden-Number
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

krnl386.exe16: Do not truncate the strcmp result (Coverity).

This commit is contained in:
Marcus Meissner 2012-07-07 11:52:21 +02:00 committed by Alexandre Julliard
parent 1f1686fddd
commit aa58bcfec9
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
dlls/krnl386.exe16/kernel.c
View File

@ -254,7 +254,14 @@ SEGPTR WINAPI KERNEL_AnsiLower16( SEGPTR strOrChar )
*/ */
INT16 WINAPI KERNEL_lstrcmp16( LPCSTR str1, LPCSTR str2 ) INT16 WINAPI KERNEL_lstrcmp16( LPCSTR str1, LPCSTR str2 )
{ {
return (INT16)strcmp( str1, str2 ); int ret = strcmp( str1, str2 );
/* Looks too complicated, but in optimized strcpy we might get
* a 32bit wide difference and would truncate it to 16 bit, so
* erroneously returning equality. */
if (ret < 0) return -1;
if (ret > 0) return 1;
return 0;
} }
/*********************************************************************** /***********************************************************************