ReceiveTempSMS/Sweden-Number
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Avoid ConvertToGlobalHandle calls.

Browse Source
This commit is contained in:
Raphael Junqueira 2005-03-09 11:48:05 +00:00 committed by Alexandre Julliard
parent 6f2f76c410
commit aa5676bd27
1 changed files with 8 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
dlls/dplayx/dplobby.c
View File

@ -1156,22 +1156,16 @@ BOOL DPL_CreateAndSetLobbyHandles( DWORD dwDestProcessId, HANDLE hDestProcess,
LPHANDLE lphRead ) LPHANDLE lphRead )
{ {
/* These are the handles for the created process */ /* These are the handles for the created process */
HANDLE hAppStart, hAppDeath, hAppRead, hTemp; HANDLE hAppStart = 0, hAppDeath = 0, hAppRead = 0;
SECURITY_ATTRIBUTES s_attrib; SECURITY_ATTRIBUTES s_attrib;
s_attrib.nLength = sizeof( s_attrib ); s_attrib.nLength = sizeof( s_attrib );
s_attrib.lpSecurityDescriptor = NULL; s_attrib.lpSecurityDescriptor = NULL;
s_attrib.bInheritHandle = TRUE; s_attrib.bInheritHandle = TRUE;
/* FIXME: Is there a handle leak here? */ *lphStart = CreateEventW( &s_attrib, TRUE, FALSE, NULL );
hTemp = CreateEventW( &s_attrib, TRUE, FALSE, NULL ); *lphDeath = CreateEventW( &s_attrib, TRUE, FALSE, NULL );
*lphStart = ConvertToGlobalHandle( hTemp ); *lphRead = CreateEventW( &s_attrib, TRUE, FALSE, NULL );
hTemp = CreateEventW( &s_attrib, TRUE, FALSE, NULL );
*lphDeath = ConvertToGlobalHandle( hTemp );
hTemp = CreateEventW( &s_attrib, TRUE, FALSE, NULL );
*lphRead = ConvertToGlobalHandle( hTemp );
if( ( !DuplicateHandle( GetCurrentProcess(), *lphStart, if( ( !DuplicateHandle( GetCurrentProcess(), *lphStart,
hDestProcess, &hAppStart, hDestProcess, &hAppStart,
@ -1184,6 +1178,9 @@ BOOL DPL_CreateAndSetLobbyHandles( DWORD dwDestProcessId, HANDLE hDestProcess,
0, FALSE, DUPLICATE_SAME_ACCESS ) ) 0, FALSE, DUPLICATE_SAME_ACCESS ) )
) )
{ {
if (*lphStart) { CloseHandle(*lphStart); *lphStart = 0; }
if (*lphDeath) { CloseHandle(*lphDeath); *lphDeath = 0; }
if (*lphRead) { CloseHandle(*lphRead); *lphRead = 0; }
/* FIXME: Handle leak... */ /* FIXME: Handle leak... */
ERR( "Unable to dup handles\n" ); ERR( "Unable to dup handles\n" );
return FALSE; return FALSE;
@ -1192,6 +1189,7 @@ BOOL DPL_CreateAndSetLobbyHandles( DWORD dwDestProcessId, HANDLE hDestProcess,
if( !DPLAYX_SetLobbyHandles( dwDestProcessId, if( !DPLAYX_SetLobbyHandles( dwDestProcessId,
hAppStart, hAppDeath, hAppRead ) ) hAppStart, hAppDeath, hAppRead ) )
{ {
/* FIXME: Handle leak... */
return FALSE; return FALSE;
} }