From a9fc71b48eb6fdffacba5a36dbc5d3f51e0a94ce Mon Sep 17 00:00:00 2001 From: Nikolay Sivov Date: Tue, 9 Feb 2010 18:07:54 +0300 Subject: [PATCH] msxml3: Support comment node type in IXMLDOMNode_get_baseName. --- dlls/msxml3/node.c | 1 + dlls/msxml3/tests/domdoc.c | 6 ++++++ 2 files changed, 7 insertions(+) diff --git a/dlls/msxml3/node.c b/dlls/msxml3/node.c index ebf865ed67f..d486bd930ea 100644 --- a/dlls/msxml3/node.c +++ b/dlls/msxml3/node.c @@ -1626,6 +1626,7 @@ static HRESULT WINAPI xmlnode_get_baseName( r = S_OK; break; case XML_TEXT_NODE: + case XML_COMMENT_NODE: break; default: ERR("Unhandled type %d\n", This->node->type ); diff --git a/dlls/msxml3/tests/domdoc.c b/dlls/msxml3/tests/domdoc.c index bc052bea53f..3c5c53cf404 100644 --- a/dlls/msxml3/tests/domdoc.c +++ b/dlls/msxml3/tests/domdoc.c @@ -982,6 +982,12 @@ static void test_domdoc( void ) ok(r == S_FALSE, "ret %08x\n", r ); ok(nodeChild == NULL, "pLastChild not NULL\n"); + /* baseName */ + str = (BSTR)0xdeadbeef; + IXMLDOMComment_get_baseName(node_comment, &str); + ok(r == S_FALSE, "ret %08x\n", r ); + ok(str == NULL, "Expected NULL\n"); + IXMLDOMComment_Release( node_comment ); }