From a624977f21a1a1668326882f84a47d3a7f5cb58d Mon Sep 17 00:00:00 2001
From: Michael Stefaniuc <mstefani@redhat.de>
Date: Tue, 25 Jul 2006 10:30:04 +0200
Subject: [PATCH] server: Fix some comparisons between signed and unsigned.

---
 server/console.c  |  2 +-
 server/ptrace.c   |  2 +-
 server/queue.c    |  2 +-
 server/registry.c |  4 ++--
 server/token.c    | 10 ++++------
 5 files changed, 9 insertions(+), 11 deletions(-)

diff --git a/server/console.c b/server/console.c
index 5e65704fa43..f57e4fe9ac4 100644
--- a/server/console.c
+++ b/server/console.c
@@ -1021,7 +1021,7 @@ static int write_console_output( struct screen_buffer *screen_buffer, data_size_
                                  const void* data, enum char_info_mode mode,
                                  int x, int y, int wrap )
 {
-    int i;
+    unsigned int i;
     char_info_t *end, *dest = screen_buffer->data + y * screen_buffer->width + x;
 
     if (y >= screen_buffer->height) return 0;
diff --git a/server/ptrace.c b/server/ptrace.c
index c84451b16a1..4de242f4521 100644
--- a/server/ptrace.c
+++ b/server/ptrace.c
@@ -288,7 +288,7 @@ static int read_thread_int( struct thread *thread, const int *addr, int *data )
 static int write_thread_int( struct thread *thread, int *addr, int data, unsigned int mask )
 {
     int res;
-    if (mask != ~0)
+    if (mask != ~0u)
     {
         if (read_thread_int( thread, addr, &res ) == -1) return -1;
         data = (data & mask) | (res & ~mask);
diff --git a/server/queue.c b/server/queue.c
index 965ede00393..a292c8032f2 100644
--- a/server/queue.c
+++ b/server/queue.c
@@ -1298,7 +1298,7 @@ static int check_hw_message_filter( user_handle_t win, unsigned int msg_code,
 
 
 /* find a hardware message for the given queue */
-static int get_hardware_message( struct thread *thread, int hw_id, user_handle_t filter_win,
+static int get_hardware_message( struct thread *thread, unsigned int hw_id, user_handle_t filter_win,
                                  unsigned int first, unsigned int last, struct get_message_reply *reply )
 {
     struct thread_input *input = thread->queue->input;
diff --git a/server/registry.c b/server/registry.c
index f56051c2163..92511889885 100644
--- a/server/registry.c
+++ b/server/registry.c
@@ -669,8 +669,8 @@ static void enum_key( const struct key *key, int index, int info_class,
 {
     int i;
     data_size_t len, namelen, classlen;
-    int max_subkey = 0, max_class = 0;
-    int max_value = 0, max_data = 0;
+    data_size_t max_subkey = 0, max_class = 0;
+    data_size_t max_value = 0, max_data = 0;
     char *data;
 
     if (index != -1)  /* -1 means use the specified key directly */
diff --git a/server/token.c b/server/token.c
index 1d08eebf68c..ce08e95ac9e 100644
--- a/server/token.c
+++ b/server/token.c
@@ -419,7 +419,7 @@ static struct token *create_token( unsigned primary, const SID *user,
     struct token *token = alloc_object( &token_ops );
     if (token)
     {
-        int i;
+        unsigned int i;
 
         list_init( &token->privileges );
         list_init( &token->groups );
@@ -623,8 +623,7 @@ static unsigned int token_adjust_privileges( struct token *token, const LUID_AND
                                              unsigned int count, LUID_AND_ATTRIBUTES *mod_privs,
                                              unsigned int mod_privs_count )
 {
-    int i;
-    unsigned int modified_count = 0;
+    unsigned int i, modified_count = 0;
 
     for (i = 0; i < count; i++)
     {
@@ -669,8 +668,7 @@ int token_check_privileges( struct token *token, int all_required,
                             const LUID_AND_ATTRIBUTES *reqprivs,
                             unsigned int count, LUID_AND_ATTRIBUTES *usedprivs)
 {
-    int i;
-    unsigned int enabled_count = 0;
+    unsigned int i, enabled_count = 0;
 
     for (i = 0; i < count; i++)
     {
@@ -944,7 +942,7 @@ DECL_HANDLER(adjust_token_privileges)
 
         if (req->get_modified_state && !req->disable_all)
         {
-            int i;
+            unsigned int i;
             /* count modified privs */
             for (i = 0; i < priv_count; i++)
             {