From a5317eb846e779159924cf0254b3837d10e28019 Mon Sep 17 00:00:00 2001 From: Rob Shearman Date: Wed, 21 Feb 2007 17:13:25 +0000 Subject: [PATCH] kernel32: Fix an off-by-one error in GetComputerNameExA/W. The dns_* functions expect the input buffer to have space for size characters plus the nul terminating character. --- dlls/kernel32/computername.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/kernel32/computername.c b/dlls/kernel32/computername.c index d0d9d04a480..eebaed70924 100644 --- a/dlls/kernel32/computername.c +++ b/dlls/kernel32/computername.c @@ -406,7 +406,7 @@ BOOL WINAPI GetComputerNameA(LPSTR name, LPDWORD size) BOOL WINAPI GetComputerNameExA(COMPUTER_NAME_FORMAT type, LPSTR name, LPDWORD size) { char buf[256]; - int len = sizeof (buf), ret; + int len = sizeof(buf) - 1, ret; TRACE("%d, %p, %p\n", type, name, size); switch( type ) { @@ -458,7 +458,7 @@ BOOL WINAPI GetComputerNameExA(COMPUTER_NAME_FORMAT type, LPSTR name, LPDWORD si BOOL WINAPI GetComputerNameExW( COMPUTER_NAME_FORMAT type, LPWSTR name, LPDWORD size ) { char buf[256]; - int len = sizeof (buf), ret; + int len = sizeof(buf) - 1, ret; TRACE("%d, %p, %p\n", type, name, size); switch( type )