msi: Use MSI_QueryGetRecord in ACTION_AppSearchDr.
This commit is contained in:
parent
e864f2f2c3
commit
a0d0453501
|
@ -775,39 +775,29 @@ static UINT ACTION_SearchDirectory(MSIPACKAGE *package, MSISIGNATURE *sig,
|
|||
static UINT ACTION_AppSearchSigName(MSIPACKAGE *package, LPCWSTR sigName,
|
||||
MSISIGNATURE *sig, LPWSTR *appValue);
|
||||
|
||||
static UINT ACTION_AppSearchDr(MSIPACKAGE *package, LPWSTR *appValue,
|
||||
MSISIGNATURE *sig)
|
||||
static UINT ACTION_AppSearchDr(MSIPACKAGE *package, LPWSTR *appValue, MSISIGNATURE *sig)
|
||||
{
|
||||
MSIQUERY *view;
|
||||
UINT rc;
|
||||
static const WCHAR ExecSeqQuery[] = {
|
||||
static const WCHAR query[] = {
|
||||
's','e','l','e','c','t',' ','*',' ',
|
||||
'f','r','o','m',' ',
|
||||
'D','r','L','o','c','a','t','o','r',' ',
|
||||
'w','h','e','r','e',' ','S','i','g','n','a','t','u','r','e','_',' ','=',' ',
|
||||
'\'','%','s','\'',0};
|
||||
|
||||
TRACE("(package %p, sig %p)\n", package, sig);
|
||||
rc = MSI_OpenQuery(package->db, &view, ExecSeqQuery, sig->Name);
|
||||
if (rc == ERROR_SUCCESS)
|
||||
{
|
||||
MSIRECORD *row = 0;
|
||||
WCHAR expanded[MAX_PATH];
|
||||
'w','h','e','r','e',' ',
|
||||
'S','i','g','n','a','t','u','r','e','_',' ','=',' ', '\'','%','s','\'',0};
|
||||
LPWSTR parentName = NULL, path = NULL, parent = NULL;
|
||||
WCHAR expanded[MAX_PATH];
|
||||
MSIRECORD *row;
|
||||
int depth;
|
||||
UINT rc;
|
||||
|
||||
rc = MSI_ViewExecute(view, 0);
|
||||
if (rc != ERROR_SUCCESS)
|
||||
TRACE("%s\n", debugstr_w(sig->Name));
|
||||
|
||||
*appValue = NULL;
|
||||
|
||||
row = MSI_QueryGetRecord( package->db, query, sig->Name );
|
||||
if (!row)
|
||||
{
|
||||
TRACE("MSI_ViewExecute returned %d\n", rc);
|
||||
goto end;
|
||||
}
|
||||
rc = MSI_ViewFetch(view,&row);
|
||||
if (rc != ERROR_SUCCESS)
|
||||
{
|
||||
TRACE("MSI_ViewFetch returned %d\n", rc);
|
||||
rc = ERROR_SUCCESS;
|
||||
goto end;
|
||||
TRACE("failed to query DrLocator for %s\n", debugstr_w(sig->Name));
|
||||
return ERROR_SUCCESS;
|
||||
}
|
||||
|
||||
/* check whether parent is set */
|
||||
|
@ -816,8 +806,7 @@ static UINT ACTION_AppSearchDr(MSIPACKAGE *package, LPWSTR *appValue,
|
|||
{
|
||||
MSISIGNATURE parentSig;
|
||||
|
||||
rc = ACTION_AppSearchSigName(package, parentName, &parentSig,
|
||||
&parent);
|
||||
rc = ACTION_AppSearchSigName(package, parentName, &parentSig, &parent);
|
||||
ACTION_FreeSignature(&parentSig);
|
||||
msi_free(parentName);
|
||||
}
|
||||
|
@ -827,35 +816,29 @@ static UINT ACTION_AppSearchDr(MSIPACKAGE *package, LPWSTR *appValue,
|
|||
depth = 0;
|
||||
else
|
||||
depth = MSI_RecordGetInteger(row,4);
|
||||
ACTION_ExpandAnyPath(package, path, expanded,
|
||||
sizeof(expanded) / sizeof(expanded[0]));
|
||||
ACTION_ExpandAnyPath(package, path, expanded, MAX_PATH);
|
||||
msi_free(path);
|
||||
if (parent)
|
||||
{
|
||||
path = msi_alloc((strlenW(parent) + strlenW(expanded) + 1) * sizeof(WCHAR));
|
||||
if (!path)
|
||||
{
|
||||
rc = ERROR_OUTOFMEMORY;
|
||||
goto end;
|
||||
}
|
||||
strcpyW(path, parent);
|
||||
strcatW(path, expanded);
|
||||
}
|
||||
else
|
||||
path = expanded;
|
||||
|
||||
rc = ACTION_SearchDirectory(package, sig, path, depth, appValue);
|
||||
|
||||
end:
|
||||
if (path != expanded)
|
||||
msi_free(path);
|
||||
msi_free(parent);
|
||||
if (row)
|
||||
msiobj_release(&row->hdr);
|
||||
MSI_ViewClose(view);
|
||||
msiobj_release(&view->hdr);
|
||||
}
|
||||
else
|
||||
{
|
||||
TRACE("MSI_OpenQuery returned %d\n", rc);
|
||||
rc = ERROR_SUCCESS;
|
||||
}
|
||||
|
||||
TRACE("returning %d\n", rc);
|
||||
return rc;
|
||||
|
|
Loading…
Reference in New Issue